On Thu, 5 May 2022 19:03:13 GMT, Daniel Fuchs wrote:
> Hi, please find here a patch that solves a rare intermittent test failure
> observed in the test `java/net/httpclient/ExecutorShutdown.java`
>
> A race condition coupled with some too eager synchronization was causing a
> deadlock between
On Thu, 5 May 2022 19:03:13 GMT, Daniel Fuchs wrote:
> Hi, please find here a patch that solves a rare intermittent test failure
> observed in the test `java/net/httpclient/ExecutorShutdown.java`
>
> A race condition coupled with some too eager synchronization was causing a
> deadlock between
On Thu, 5 May 2022 19:03:13 GMT, Daniel Fuchs wrote:
> Hi, please find here a patch that solves a rare intermittent test failure
> observed in the test `java/net/httpclient/ExecutorShutdown.java`
>
> A race condition coupled with some too eager synchronization was causing a
> deadlock between
On Thu, 5 May 2022 19:03:13 GMT, Daniel Fuchs wrote:
> Hi, please find here a patch that solves a rare intermittent test failure
> observed in the test `java/net/httpclient/ExecutorShutdown.java`
>
> A race condition coupled with some too eager synchronization was causing a
> deadlock between
> This is to update the method javadoc of
> java.security.Signature.getParameters() with the missing `@throws
> UnsupportedOperationException`. In addition, the wording on the returned
> parameters are updated to match those in Cipher and CipherSpi classes.
>
> CSR will be filed later.
>
>
On Thu, 5 May 2022 23:24:12 GMT, Mark Powers wrote:
> The IBM files say this at the top: DO NOT ALTER OR REMOVE COPYRIGHT NOTICES
> OR THIS FILE HEADER
That's the standard copyright notice. Let's check with Oracle's copyright
person...
-
PR:
On Thu, 5 May 2022 21:05:40 GMT, Mark Powers wrote:
>> https://bugs.openjdk.java.net/browse/JDK-8284688
>>
>> [JDK-8273046](https://bugs.openjdk.java.net/browse/JDK-8273046) is the
>> umbrella bug for this bug. The changes were too large for a single code
>> review, so it was decided to split
On Thu, 5 May 2022 21:05:40 GMT, Mark Powers wrote:
>> https://bugs.openjdk.java.net/browse/JDK-8284688
>>
>> [JDK-8273046](https://bugs.openjdk.java.net/browse/JDK-8273046) is the
>> umbrella bug for this bug. The changes were too large for a single code
>> review, so it was decided to split
On Wed, 4 May 2022 04:16:42 GMT, Xue-Lei Andrew Fan wrote:
>> How about the case when no parameters are given? Say A is the user-supplied
>> values, B is the provider specific default or random values, your suggestion
>> has A, A+B, and null. Isn't the sentence about B needed (no A and
On Thu, 5 May 2022 22:03:16 GMT, Valerie Peng wrote:
>> I think this sentence covers case B, "... or may contain additional default
>> or random parameter
>> values used by the underlying signature implementation."
>
> Sean's comment on the other PR regarding Cipher.getParameters implies
>
On Thu, 5 May 2022 21:05:40 GMT, Mark Powers wrote:
>> https://bugs.openjdk.java.net/browse/JDK-8284688
>>
>> [JDK-8273046](https://bugs.openjdk.java.net/browse/JDK-8273046) is the
>> umbrella bug for this bug. The changes were too large for a single code
>> review, so it was decided to split
> https://bugs.openjdk.java.net/browse/JDK-8284688
>
> [JDK-8273046](https://bugs.openjdk.java.net/browse/JDK-8273046) is the
> umbrella bug for this bug. The changes were too large for a single code
> review, so it was decided to split into smaller chunks. This is one such
> chunk:
>
>
On Tue, 3 May 2022 02:07:13 GMT, Xue-Lei Andrew Fan wrote:
>> Please review the update to remove finalizer method in the SunJSSE provider
>> implementation. It is one of the efforts to clean up the use of finalizer
>> method in JDK.
>
> Xue-Lei Andrew Fan has updated the pull request
On Tue, 3 May 2022 01:19:20 GMT, Weijun Wang wrote:
>> Mark Powers has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 11 commits:
>>
>> - sixth iteration
>> - Merge
>> - fifth iteration
>> - Merge
>> - fourth iteration
>> -
On Thu, 5 May 2022 06:02:14 GMT, Xue-Lei Andrew Fan wrote:
>> Hi,
>>
>> Could I have the simple update reviewed?
>>
>> In the PKCS12 key store implementation, the PBEKeySpec.clearPassword()
>> should be called in a finally try block. Otherwise, the password cleanup
>> could be interrupted
Hi, please find here a patch that solves a rare intermittent test failure
observed in the test `java/net/httpclient/ExecutorShutdown.java`
A race condition coupled with some too eager synchronization was causing a
deadlock between an Http2Connection close, a thread trying to shutdown the
> This change refactors the PBES2Core and PKCS12PBECipherCore classes in SunJCE
> provider as requested in the bug record. Functionality should remain the same
> with a clearer and simplified code/control flow with less lines of code.
> This should improve readability and maintenance. I
On Thu, 5 May 2022 06:02:14 GMT, Xue-Lei Andrew Fan wrote:
>> Hi,
>>
>> Could I have the simple update reviewed?
>>
>> In the PKCS12 key store implementation, the PBEKeySpec.clearPassword()
>> should be called in a finally try block. Otherwise, the password cleanup
>> could be interrupted
On Wed, 4 May 2022 20:32:30 GMT, Mat Carter wrote:
>> On Windows you can now access the local machine keystores using the strings
>> "Windows-MY-LOCALMACHINE" and "Windows-ROOT-LOCALMACHINE"; note the
>> application requires admin privileges.
>>
>> "Windows-MY" and "Windows-ROOT" remain
On Thu, 5 May 2022 14:32:14 GMT, Weijun Wang wrote:
>> Mat Carter has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Removed whitespace and simply passing ints between java and C++
>
> I'd like to contribute a test. Please modify it as
On Wed, 4 May 2022 20:32:30 GMT, Mat Carter wrote:
>> On Windows you can now access the local machine keystores using the strings
>> "Windows-MY-LOCALMACHINE" and "Windows-ROOT-LOCALMACHINE"; note the
>> application requires admin privileges.
>>
>> "Windows-MY" and "Windows-ROOT" remain
On Thu, 5 May 2022 06:02:14 GMT, Xue-Lei Andrew Fan wrote:
>> Hi,
>>
>> Could I have the simple update reviewed?
>>
>> In the PKCS12 key store implementation, the PBEKeySpec.clearPassword()
>> should be called in a finally try block. Otherwise, the password cleanup
>> could be interrupted
On Wed, 4 May 2022 20:32:30 GMT, Mat Carter wrote:
>> On Windows you can now access the local machine keystores using the strings
>> "Windows-MY-LOCALMACHINE" and "Windows-ROOT-LOCALMACHINE"; note the
>> application requires admin privileges.
>>
>> "Windows-MY" and "Windows-ROOT" remain
On Wed, 2 Mar 2022 19:04:26 GMT, zzambers wrote:
> When testing compatibility of jdk TLS implementation with gnutls, I have
> found a problem. The problem is, that gnutls does not like use of
> user_canceled alert when closing TLS-1.3 connection from duplexCloseOutput()
> (used by
On Wed, 4 May 2022 19:22:05 GMT, Bradford Wetmore wrote:
>> When testing compatibility of jdk TLS implementation with gnutls, I have
>> found a problem. The problem is, that gnutls does not like use of
>> user_canceled alert when closing TLS-1.3 connection from duplexCloseOutput()
>> (used by
On Wed, 4 May 2022 17:35:13 GMT, Weijun Wang wrote:
> Please merge your PR with master and I can run it for you.
Merged. Thank you!
-
PR: https://git.openjdk.java.net/jdk/pull/8377
> Hi,
>
> Could I have the simple update reviewed?
>
> In the PKCS12 key store implementation, the PBEKeySpec.clearPassword() should
> be called in a finally try block. Otherwise, the password cleanup could be
> interrupted by exceptions.
>
> Thanks,
> Xuelei
Xue-Lei Andrew Fan has updated
27 matches
Mail list logo
