Slow LoginContext.login() due to repeated ServiceLoader lookups

2019-08-27 Thread Florent Guillaume
eged([email protected]/Native Method) at javax.security.auth.login.LoginContext.invokePriv([email protected] /LoginContext.java:663) at javax.security.auth.login.LoginContext.login([email protected] /LoginContext.java:574) Thanks, Florent -- [image: Nuxeo Logo] <https://www.nuxeo.com/> Flo

Re: Slow LoginContext.login() due to repeated ServiceLoader lookups

2019-08-27 Thread Florent Guillaume
to wrap up: > https://bugs.openjdk.java.net/browse/JDK-8223260 > > Similar scenario in how the ContextFactory is searched for. My proposed > patch is to cache a factory per classloader (for the NamingManager issue > at least) > > regards, > Sean. > On 27/08/2019 16

Re: RFR: 8262316: Reducing locks in RSA Blinding [v2]

2021-04-02 Thread Florent Guillaume
On Fri, 2 Apr 2021 23:12:21 GMT, Anthony Scarpino wrote: >> According to SO, unsynchronized writes to a map can lead to lock up, see >> here: >> https://stackoverflow.com/a/1003237 >> Or here: >> https://mailinator.blogspot.com/2009/06/beautiful-race-condition.html?m=1 >> What's the performance

Re: RFR: 8265237: String.join and StringJoiner can be improved further

2021-04-14 Thread Florent Guillaume
On Wed, 14 Apr 2021 18:58:57 GMT, Peter Levart wrote: > While JDK-8148937 improved StringJoiner class by replacing internal use of > getChars that copies out characters from String elements into a char[] array > with StringBuilder which is somehow more optimal, the improvement was > marginal i

Re: RFR: 8265237: String.join and StringJoiner can be improved further

2021-04-15 Thread Florent Guillaume
On Wed, 14 Apr 2021 22:23:57 GMT, Peter Levart wrote: >> src/java.base/share/classes/java/lang/String.java line 3230: >> >>> 3228: >>> 3229: /** >>> 3230: * Designated join routine. >> >> Did you mean "dedicated"? > > No, I meant designated. It is the routine that all other public API

Re: RFR: 8273026: Slow LoginContext.login() on multi threading application [v7]

2021-11-02 Thread Florent Guillaume
On Thu, 28 Oct 2021 18:55:32 GMT, Larry-N wrote: >> This fix adds a cache of service provider classes to LoginContext (in >> particular, it's a cache of LoginModules classes). The approach helps to >> increase the performance of the LoginContext.login() method significantly, >> especially in a