On Wed, 9 Sep 2020 07:57:48 GMT, Dmitriy Dumanskiy
wrote:
>> @doom369 jcheck requires an associated issue
>
> @mrserb hello. Thanks for the review. Any further actions required from me?
Before this Enhancement can be formally reviewed, you will need a JBS bug ID.
If you are already working wit
On Thu, 10 Sep 2020 11:21:28 GMT, David Holmes wrote:
>> The code in java.base was updated to use String::isEmpty in JDK 12
>> (JDK-8215281). There was follow-up in JDK 13 to do
>> the same in the java.desktop module (JDK-8223237). Changing the remaining
>> usages make sense although I see that
On Fri, 9 Oct 2020 17:35:22 GMT, Andrew Haley wrote:
>> Marked as reviewed by aph (Reviewer).
>
> I see Linux x64 failed. However, I don't seem to be able to withdraw my patch
> approval.
> However, please consider it withdrawn.
@theRealAph if you still need to, you can withdraw your approval b
On Fri, 28 Jan 2022 14:39:31 GMT, Matteo Baccan wrote:
> Hi
>
> I have reviewed the code for removing double semicolons at the end of lines
>
> all the best
> matteo
But as the JBS title and PR title now match, this is a moot point.
-
PR: https://git.openjdk.java.net/jdk/pull/726
On Mon, 7 Mar 2022 16:40:15 GMT, Lance Andersen wrote:
> What problem are you having editing the PR header? You should be able to do
> so as the author of the PR
Exactly. You should see an "Edit" button near the right edge of the PR title.
See the attached image:
.
-
Marked as reviewed by kcr (Author).
PR: https://git.
On Wed, 30 Mar 2022 00:43:49 GMT, Alisen Chung wrote:
> redo of 8280400
Since this is identical to the original fix, I would expect the same Tier2 test
failure as reported in
[JDK-8283804](https://bugs.openjdk.java.net/browse/JDK-8283804).
-
PR: https://git.openjdk.java.net/jdk/p
On Tue, 17 Nov 2020 20:56:52 GMT, Jim Laskey wrote:
> my local branch seems to have the right sources for doc
Maybe, but your branch on GitHub does not.
-
PR: https://git.openjdk.java.net/jdk/pull/1273
On Tue, 17 Nov 2020 22:12:19 GMT, Jim Laskey wrote:
>> @kevinrushforth What is the recommended approach to remove the doc
>> edit/commit?
>
> javadoc can be found at
> http://cr.openjdk.java.net/~jlaskey/prng/doc/api/java.base/java/util/random/package-summary.html
Presuming your master branch
On Wed, 19 May 2021 13:47:53 GMT, Weijun Wang wrote:
>> Please review this implementation of [JEP
>> 411](https://openjdk.java.net/jeps/411).
>>
>> The code change is divided into 3 commits. Please review them one by one.
>>
>> 1.
>> https://github.com/openjdk/jdk/commit/576161d15423f58281e38
On Fri, 18 Jun 2021 15:21:06 GMT, Sean Mullan wrote:
> Please review this fix to backout the change to Disable SHA-1 Signed JARs
> from JDK 17 due to a startup performance regression (see
> https://bugs.openjdk.java.net/browse/JDK-8266971). The plan is to now address
> the performance issue in
On Fri, 20 Aug 2021 22:43:55 GMT, Smita Kamath wrote:
>> I would like to submit AES-GCM optimization for x86_64 architectures
>> supporting AVX3+VAES (Evex encoded AES). This optimization interleaves AES
>> and GHASH operations.
>> Performance gain of ~1.5x - 2x for message sizes 8k and above.
On Wed, 1 Dec 2021 17:03:24 GMT, Weijun Wang wrote:
> Update Public Suffix List data to the latest version at
> https://github.com/publicsuffix/list.
This is not a formal review, but it looks good to me. I verified that the new
file matches the one from the referenced upstream commit. I also d
14 matches
Mail list logo
