Changeset: f9c187839d72
Author:kevinw
Date: 2009-02-24 19:03 +
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/f9c187839d72
6809463: Missing license header in test LargeZipFile.java
Reviewed-by: alanb
! test/java/util/zip/ZipFile/LargeZipFile.java
Changeset: dde3fe2e8164
Changeset: b8004f6f4812
Author:kevinw
Date: 2009-09-22 17:01 +0100
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/b8004f6f4812
6882768: (launcher) test for 6842838 is broken
Summary: Testcase correction.
Reviewed-by: ksrini
! test/tools/launcher/6842838/Test6842838.sh
Changeset:
Changeset: d36ad8686f6d
Author:kevinw
Date: 2010-12-21 11:32 +
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/d36ad8686f6d
6968933: Clip loop() deadlock in DirectAudioDevice$DirectClip.run
Reviewed-by: amenkov
! src/share/classes/com/sun/media/sound/DirectAudioDevice.java
Hi,
This is a review request for an 8u backport of the bug:
https://bugs.openjdk.java.net/browse/JDK-8072932
It's a one-line change that backports cleanly: this is the 8u diff,
shown after applying the change for 8064331 in 8u: (not hg imported,
different paths)
jdk8u-dev/jdk$ hg diff
Hi,
This is a review request for a jdk8u backport of:
https://bugs.openjdk.java.net/browse/JDK-8064331
8u webrev:
http://cr.openjdk.java.net/~kevinw/8064331/webrev.00/
Original webrev and review email:
http://cr.openjdk.java.net/~jbachorik/8064331/webrev.01/
.
Thanks
Kevin
On 02/03/2015 16:57, Sean Mullan wrote:
Looks fine to me.
--Sean
On 03/02/2015 09:51 AM, Kevin Walls wrote:
Hi,
This is a review request for a jdk8u backport of:
https://bugs.openjdk.java.net/browse/JDK-8064331
8u webrev:
http://cr.openjdk.java.net/~kevinw/8064331/webrev.00
On Thu, 1 Jul 2021 10:38:24 GMT, Сергей Цыпанов
wrote:
>> In some JDK classes there's still the following hashCode() implementation:
>>
>> long objNum;
>>
>> public int hashCode() {
>> return (int) objNum;
>> }
>>
>> This outdated expression should be replaced with Long.hashCode(long) as
On Wed, 30 Jun 2021 11:49:51 GMT, Сергей Цыпанов
wrote:
>> In some JDK classes there's still the following hashCode() implementation:
>>
>> long objNum;
>>
>> public int hashCode() {
>> return (int) objNum;
>> }
>>
>> This outdated expression should be replaced with Long.hashCode(long)
gt; Docs/man page update to follow (JDK-8278619).
Kevin Walls has updated the pull request incrementally with one additional
commit since the last revision:
Wildcard in object filter to permit proxies, in case other activity in this
JVM changes the nameing/numbering of proxy classes.
---
On Thu, 13 Jan 2022 10:30:07 GMT, Pavel Rappo wrote:
> - Most of the typos are of a trivial kind: missing whitespace.
> - If any of the typos should be fixed in the upstream projects instead,
> please say so; I will drop those typos from the patch.
> - As I understand it, in ImageInputStream
On Thu, 13 Jan 2022 10:30:07 GMT, Pavel Rappo wrote:
> - Most of the typos are of a trivial kind: missing whitespace.
> - If any of the typos should be fixed in the upstream projects instead,
> please say so; I will drop those typos from the patch.
> - As I understand it, ` ` in
On Thu, 13 Jan 2022 11:04:43 GMT, Pavel Rappo wrote:
>> src/java.sql/share/classes/java/sql/BatchUpdateException.java line 58:
>>
>>> 56: * A JDBC driver implementation should use
>>> 57: * the constructor {@code BatchUpdateException(String reason, String
>>> SQLState,
>>> 58: * int
On Thu, 13 Jan 2022 10:30:07 GMT, Pavel Rappo wrote:
> - Most of the typos are of a trivial kind: missing whitespace.
> - If any of the typos should be fixed in the upstream projects instead,
> please say so; I will drop those typos from the patch.
> - As I understand it, ` ` in
On Wed, 16 Mar 2022 15:14:53 GMT, Daniel Fuchs wrote:
>> Removing permission checks which, in the presence of a Security Manager,
>> would check for a RuntimePermission "className.subclass". This was to
>> prevent subclassing these classes, but is no longer necessary with strong
>>
Removing permission checks which, in the presence of a Security Manager, would
check for a RuntimePermission "className.subclass". This was to prevent
subclassing these classes, but is no longer necessary with strong encapsulation
from modules.
-
Commit messages:
- 8283092: JMX
On Thu, 17 Mar 2022 13:55:22 GMT, Sean Mullan wrote:
> test/jdk/sun/management/PlatformMBeanProviderConstructorCheck.java
Thank for noticing that Sean - had run various tests but missed this. I have
an update, will add it here soon.
-
PR:
> Removing permission checks which, in the presence of a Security Manager,
> would check for a RuntimePermission "className.subclass". This was to
> prevent subclassing these classes, but is no longer necessary with strong
> encapsulation from modules.
Kevin Walls has up
On Mon, 21 Mar 2022 18:40:53 GMT, Mandy Chung wrote:
>> Kevin Walls has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Test update
>
> src/java.management/share/classes/sun/management/spi/PlatformMBeanProvid
On Tue, 15 Mar 2022 20:22:16 GMT, Kevin Walls wrote:
> Removing permission checks which, in the presence of a Security Manager,
> would check for a RuntimePermission "className.subclass". This was to
> prevent subclassing these classes, but is no longer necessary with stro
On Mon, 21 Mar 2022 20:19:03 GMT, Kevin Walls wrote:
>> Removing permission checks which, in the presence of a Security Manager,
>> would check for a RuntimePermission "className.subclass". This was to
>> prevent subclassing these classes, but is no
Reduce noise in test output by adding the @SuppressWarnings("removal")
annotation (which has already been widely applied).
-
Commit messages:
- 8272777: Clean up remaining AccessController warnings in test library
Changes: https://git.openjdk.java.net/jdk/pull/7328/files
Webrev:
On Wed, 2 Feb 2022 21:35:59 GMT, Kevin Walls wrote:
> Reduce noise in test output by adding the @SuppressWarnings("removal")
> annotation (which has already been widely applied).
This pull request has now been integrated.
Changeset: 63a00a0d
Author:Kevin Walls
U
On Wed, 2 Feb 2022 21:35:59 GMT, Kevin Walls wrote:
> Reduce noise in test output by adding the @SuppressWarnings("removal")
> annotation (which has already been widely applied).
Thanks Roger and Serguei!
-
PR: https://git.openjdk.java.net/jdk/pull/7328
On Thu, 27 Jan 2022 17:44:39 GMT, Roger Riggs wrote:
>> Kevin Walls has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Wildcard in object filter to permit proxies, in case other activity in
>> this JVM
On Mon, 10 Jan 2022 11:17:12 GMT, Kevin Walls wrote:
>> Remove the use of Security Manager from jstatd.
>> Add use of an ObjectInputFilter to restrict RMI.
>>
>> Also we can undo the property-setting Launcher.gmk change from: 8279007:
>> jstatd fails to
gt; Docs/man page update to follow (JDK-8278619).
Kevin Walls has updated the pull request incrementally with one additional
commit since the last revision:
Copyright update
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/6919/files
- new: https://git.openjdk.java
gt; Docs/man page update to follow (JDK-8278619).
Kevin Walls has updated the pull request with a new target base due to a merge
or a rebase. The incremental webrev excludes the unrelated changes brought in
by the merge/rebase. The pull request contains eight additional commits since
the last re
On Wed, 22 Dec 2021 18:14:43 GMT, Kevin Walls wrote:
> Remove the use of Security Manager from jstatd.
> Add use of an ObjectInputFilter to restrict RMI.
>
> Also we can undo the property-setting Launcher.gmk change from: 8279007:
> jstatd fails to start because SecurityMana
On Thu, 20 Jan 2022 16:54:21 GMT, Mandy Chung wrote:
> If `sun.jvmstat.monitor.remote.RemoteVm` is the only proxy interface,
> `com.sun.proxy.jdk.proxy*` should adequately cover the proxy classes created
> for `RemoteVm`.
Thanks. With that endorsement I think there are no unresolved issues
On Wed, 22 Dec 2021 18:14:43 GMT, Kevin Walls wrote:
> Remove the use of Security Manager from jstatd.
> Add use of an ObjectInputFilter to restrict RMI.
>
> Also we can undo the property-setting Launcher.gmk change from: 8279007:
> jstatd fails to start because SecurityMana
On Mon, 10 Jan 2022 11:17:12 GMT, Kevin Walls wrote:
>> Remove the use of Security Manager from jstatd.
>> Add use of an ObjectInputFilter to restrict RMI.
>>
>> Also we can undo the property-setting Launcher.gmk change from: 8279007:
>> jstatd fails to
On Wed, 19 Jan 2022 19:56:53 GMT, Mandy Chung wrote:
> Are all the proxy interfaces public?
sun.jvmstat.monitor.remote.RemoteVm is "public interface RemoteVm extends
Remote" and methods in there only return basic types.
This is in the jdk.jstatd module, where I see the module info contains
On Thu, 13 Jan 2022 10:30:07 GMT, Pavel Rappo wrote:
> - Most of the typos are of a trivial kind: missing whitespace.
> - If any of the typos should be fixed in the upstream projects instead,
> please say so; I will drop those typos from the patch.
> - As I understand it, in ImageInputStream
On Thu, 14 Apr 2022 18:04:16 GMT, Andrey Turbanov wrote:
> I found [yet another
> typo](https://github.com/kelthuzadx/jdk/commit/acb9e15bc0bf5395d1c0875f36992f692734f948)
> ...
I didn't think "JVMInvokeMethodSlack" was a typo. I think it's the idea of
"slack space" meaning leftover space.
On Tue, 15 Mar 2022 20:22:16 GMT, Kevin Walls wrote:
> Removing permission checks which, in the presence of a Security Manager,
> would check for a RuntimePermission "className.subclass". This was to
> prevent subclassing these classes, but is no longer necessary with stro
> Removing permission checks which, in the presence of a Security Manager,
> would check for a RuntimePermission "className.subclass". This was to
> prevent subclassing these classes, but is no longer necessary with strong
> encapsulation from modules.
Kevin Walls has up
On Wed, 18 May 2022 13:27:24 GMT, Alexey Ivanov wrote:
> Replaces usages of articles that follow each other in all combinations:
> a/the, an?/an?, the/the…
>
> Also, I fixed a couple of spelling mistakes.
src/hotspot/share/opto/graphKit.cpp line 3626:
> 3624: // The optional arguments are
On Wed, 18 May 2022 13:27:24 GMT, Alexey Ivanov wrote:
> Replaces usages of articles that follow each other in all combinations:
> a/the, an?/an?, the/the…
>
> Also, I fixed a couple of spelling mistakes.
OK. I started with serviceability but then went through everything as it's
hard to
On Wed, 18 May 2022 13:27:24 GMT, Alexey Ivanov wrote:
> Replaces usages of articles that follow each other in all combinations:
> a/the, an?/an?, the/the…
>
> Also, I fixed a couple of spelling mistakes.
src/jdk.jdi/share/classes/com/sun/jdi/ClassType.java line 348:
> 346:
> 347: /**
>
On Wed, 18 May 2022 13:27:24 GMT, Alexey Ivanov wrote:
> Replaces usages of articles that follow each other in all combinations:
> a/the, an?/an?, the/the…
>
> Also, I fixed a couple of spelling mistakes.
src/hotspot/share/interpreter/bytecodeUtils.cpp line 186:
> 184: static const int
On Wed, 18 May 2022 13:27:24 GMT, Alexey Ivanov wrote:
> Replaces usages of articles that follow each other in all combinations:
> a/the, an?/an?, the/the…
>
> Also, I fixed a couple of spelling mistakes.
src/hotspot/share/cds/filemap.cpp line 1914:
> 1912:
> 1913: // the current value
On Wed, 18 May 2022 13:27:24 GMT, Alexey Ivanov wrote:
> Replaces usages of articles that follow each other in all combinations:
> a/the, an?/an?, the/the…
>
> Also, I fixed a couple of spelling mistakes.
test/jdk/jdk/nio/zipfs/TestLocOffsetFromZip64EF.java line 84:
> 82:
> 83: /**
>
On Wed, 18 May 2022 13:27:24 GMT, Alexey Ivanov wrote:
> Replaces usages of articles that follow each other in all combinations:
> a/the, an?/an?, the/the…
>
> Also, I fixed a couple of spelling mistakes.
src/jdk.sctp/share/classes/com/sun/nio/sctp/ShutdownNotification.java line 28:
> 26:
>
43 matches
Mail list logo
