RE: RFR(M): 8170525: Fix minor issues in awt coding

2016-11-30 Thread Lindenmaier, Goetz
regards, Goetz. (Am I correct that your openJdk name is Vinnie?) > -Original Message- > From: Vincent Ryan [mailto:vincent.x.r...@oracle.com] > Sent: Mittwoch, 30. November 2016 14:53 > To: Lindenmaier, Goetz <goetz.lindenma...@sap.com> > Cc: awt-...@openjdk.j

RFR(M): 8170525: Fix minor issues in awt coding

2016-11-30 Thread Lindenmaier, Goetz
Hi, I'd like to propose a row of smaller fixes where code is noted down a bit questionable. SAP's quality process requires that we fix these in our internal delivery, and I Would like to share my fixes with openJdk. Some of these fixes are of more theoretical nature as how I understand the code

RE: RFR(M): 8170525: Fix minor issues in awt coding

2016-12-01 Thread Lindenmaier, Goetz
Langer, Christoph > Sent: Mittwoch, 30. November 2016 20:47 > To: Lindenmaier, Goetz <goetz.lindenma...@sap.com> > Cc: awt-...@openjdk.java.net; security-dev@openjdk.java.net; 2d- > d...@openjdk.java.net; Vincent Ryan <vincent.x.r...@oracle.com> > Subject: RE: RFR(M): 817052

RE: RFR(M): 8170525: Fix minor issues in awt coding

2016-11-30 Thread Lindenmaier, Goetz
Hi Vincent, I fixed the typo and added a remark to the first line of the bug text. Best regards, Goetz. > -Original Message- > From: Vincent Ryan [mailto:vincent.x.r...@oracle.com] > Sent: Mittwoch, 30. November 2016 17:10 > To: Lindenmaier, Goetz <goetz.lindenma..

RE: [OpenJDK 2D-Dev] RFR(M): 8170525: Fix minor issues in awt coding

2016-12-01 Thread Lindenmaier, Goetz
--- > From: Phil Race [mailto:philip.r...@oracle.com] > Sent: Mittwoch, 30. November 2016 20:59 > To: Sergey Bylokhov <sergey.bylok...@oracle.com>; Lindenmaier, Goetz > <goetz.lindenma...@sap.com>; Vincent Ryan <vincent.x.r...@oracle.com> > Cc: awt-...@openjdk.java.n

RE: [OpenJDK 2D-Dev] RFR(M): 8170525: Fix minor issues in awt coding

2016-12-01 Thread Lindenmaier, Goetz
rgey.bylok...@oracle.com>; Lindenmaier, Goetz > <goetz.lindenma...@sap.com>; Vincent Ryan <vincent.x.r...@oracle.com> > Cc: awt-...@openjdk.java.net; 2d-dev <2d-...@openjdk.java.net>; security- > d...@openjdk.java.net > Subject: Re: [OpenJDK 2D-Dev] RF

RE: [OpenJDK 2D-Dev] RFR(M): 8170525: Fix minor issues in awt coding

2016-12-01 Thread Lindenmaier, Goetz
Ah, no, that is just the field that is initialized with the Result of gtk3_get_color_for_flags() why I need to initialize it there. Best regards, Goetz. > -Original Message- > From: Lindenmaier, Goetz > Sent: Donnerstag, 1. Dezember 2016 12:10 > To: 'Prasan

RE: RFR [11] 8207846: Generalize the jdk.net.includeInExceptions security property

2018-07-20 Thread Lindenmaier, Goetz
Hi, I scanned all the changes we did to exception messages in our internal VM, see below. We print paths and sockets in a row of places, but also other information. It's wide spread, while most is in java.base. We plan to contribute these messages in the near future. Thus it'll be useful if

RE: RFR: 8211752: JNU_ThrowIOExceptionWithLastErrorAndPath - enhance some IOExceptions with path causing the issue

2018-10-12 Thread Lindenmaier, Goetz
well. > > If needed, we might use something similar to JDK-8207768 where a > category has been added for enhanced exception messages to the > java.security file . > > Best regards, Matthias > > From: Baesken, Matthias > Sent: Dienstag, 9. Oktober 2018

downport of JDK-8209965 / JDK-8210005

2018-11-16 Thread Lindenmaier, Goetz
Hi, we have a user running into jdk-8209965. The downport change has been opened in August, but not yet been worked on. Will this be downported to jdk11u? If this is not being worked on by Oracle, I would request a downport. But I don't want to interfere with your work.

8215534: [testbug] some jfr test don't check @requires vm.hasJFR

2018-12-12 Thread Lindenmaier, Goetz
Hi, These tests lack @requires vm.hasJFR, thus they are failing on AIX. http://cr.openjdk.java.net/~goetz/wr18/8215334-JFR_requires/01/ Please review. I will push this to jdk12 as it is a testbug if I miss the RDP deadline. Best regards, Goetz.

RE: 8215534: [testbug] some jfr test don't check @requires vm.hasJFR

2018-12-13 Thread Lindenmaier, Goetz
Thanks Erik! Pushed. Best regards, Goetz > -Original Message- > From: serviceability-dev On > Behalf Of Erik Gahlin > Sent: Thursday, December 13, 2018 12:34 PM > To: security-dev@openjdk.java.net; serviceability-dev (serviceability- > d...@openjdk.java.net) > Subject: Re: 8215534:

RE: downport of JDK-8209965 / JDK-8210005

2018-11-21 Thread Lindenmaier, Goetz
prepared by Oracle will not be released to the open. These two pieces of information don't fit together in my mind :) Best regards, Goetz. > -Original Message- > From: Lindenmaier, Goetz > Sent: Freitag, 16. November 2018 15:07 > To: 'Xuelei Fan' ; 'Prasadrao Kopp

RE: downport of JDK-8209965 / JDK-8210005

2018-11-21 Thread Lindenmaier, Goetz
HI Rob, thanks for the update! Seems it was accepted for 11.0.2 ... So I don't need to take action. Best regards, Goetz. > -Original Message- > From: Rob McKenna > Sent: Mittwoch, 21. November 2018 17:35 > To: Lindenmaier, Goetz > Cc: security-dev@openjdk.java.ne

RE: security/infra/java/security/cert/CertPathValidator/certification/QuoVadisCA.java fails in jdk

2018-09-18 Thread Lindenmaier, Goetz
Hi Rajan, are you working on this issue? We have this test disabled, I would like to run it again. Best regards, Goetz. > -Original Message- > From: security-dev On Behalf Of > Rajan Halade > Sent: Mittwoch, 11. Juli 2018 17:42 > To: Baesken, Matthias ; security- >

RE: jdk11u and jdk/jdk : jtreg test error in security/infra/java/security/cert/CertPathValidator/certification/ActalisCA.java

2018-12-19 Thread Lindenmaier, Goetz
ecurity- > d...@openjdk.java.net > Cc: Lindenmaier, Goetz ; Sibabrata Sahoo > > Subject: Re: jdk11u and jdk/jdk : jtreg test error in > security/infra/java/security/cert/CertPathValidator/certification/ActalisCA.ja > va > > On 11/27/18 7:36 AM, Baesken, Matthias wrote: > &

RE: RFR 8217657: Move the test for default value of jdk.includeInExceptions into own test

2019-01-23 Thread Lindenmaier, Goetz
Hi Christoph, it is a good idea to keep testing these two matters separately. Could you please document in the new test that in OpenJDK it is decided to keep this property empty? Something like: @comment In OpenJDK, this property is empty by default and on purpose. This test assures the default

RE: RFR 8217657: Move the test for default value of jdk.includeInExceptions into own test

2019-01-24 Thread Lindenmaier, Goetz
Thanks! I should have stated that I don't need a new webrev, thanks anyways. Best regards, Goetz. > -Original Message- > From: Langer, Christoph > Sent: Donnerstag, 24. Januar 2019 11:59 > To: Lindenmaier, Goetz ; OpenJDK Dev list > ; OpenJDK Network Dev list d...@o

[11u] RFR: 8213010: Supporting keys created with certmgr.exe

2019-12-21 Thread Lindenmaier, Goetz
Hi, I would like to downport this for parity with 11.0.7-Oracle. It does not apply clean because in 11 changes were applied in a different order than in 14. http://cr.openjdk.java.net/~goetz/wr19/8213010-certmgr.exe_keys-jdk11/ In ECUtil.java I had to resolve the Copyright. patching file

RE: [11u] RFR: 8213010: Supporting keys created with certmgr.exe

2019-12-23 Thread Lindenmaier, Goetz
Hi Christoph, Thanks for reviewing! Best regards, Goetz. > -Original Message- > From: Langer, Christoph > Sent: Monday, December 23, 2019 5:42 PM > To: Lindenmaier, Goetz ; jdk-updates- > d...@openjdk.java.net; OpenJDK Dev list > Subject: RE: [11u] RFR: 821301

RE: [11u] RFR: 8266293: Key protection using PBEWithMD5AndDES fails with "java.security.InvalidAlgorithmParameterException: Salt must be 8 bytes long"

2021-05-19 Thread Lindenmaier, Goetz
Hi Martin, This looks good to me. The adaption makes sense. Best regards, Goetz. From: security-dev On Behalf Of Doerr, Martin Sent: Dienstag, 18. Mai 2021 17:03 To: jdk-updates-...@openjdk.java.net; security-dev Subject: [11u] RFR: 8266293: Key protection using PBEWithMD5AndDES fails

RE: [11u] RFR: 8244683: A TSA server used by tests

2021-02-08 Thread Lindenmaier, Goetz
Hi Martin, Thanks for downporting this. Nice documentation of the changes! Looks good. Best regards, Goetz. From: Doerr, Martin Sent: Tuesday, February 2, 2021 9:28 PM To: security-dev ; jdk-updates-...@openjdk.java.net Cc: Langer, Christoph ; Lindenmaier, Goetz Subject: [11u] RFR