RFR(S): 8165689: Fix module dependencies for sun/security/pkcs11/* tests

Hello team, Could you please review the fix for below CR: Bug ID: https://bugs.openjdk.java.net/browse/JDK-8165689 WebRev: http://cr.openjdk.java.net/~skovalev/8165689/webrev.00/ Goal: make test possible to run with "--limit-modules" flag. Summary: added @modules tag into jtreg header if applic

RFR(S): 8165689: Fix module dependencies for sun/security/pkcs11/* tests

Hello team, Could you please review the fix for below CR: Bug ID: https://bugs.openjdk.java.net/browse/JDK-8165689 WebRev: http://cr.openjdk.java.net/~skovalev/8165689/webrev.00/ Goal: make test possible to run with "--limit-modules" flag. Summary: added @modules tag into jtreg header if applic

Re: RFR(S): 8165689: Fix module dependencies for sun/security/pkcs11/* tests

Hello team, This is re-request for review of very small changes. Could somebody take a look? 08.09.16 17:03, Sergei Kovalev wrote: Hello team, Could you please review the fix for below CR: Bug ID: https://bugs.openjdk.java.net/browse/JDK-8165689 WebRev: http://cr.openjdk.java.net

RFR(M): 8166032: Fix module dependencies for javax.SSL tests

Hello Team, Could you please review below fix for Bug ID: https://bugs.openjdk.java.net/browse/JDK-8166032 Code review: http://cr.openjdk.java.net/~skovalev/8166032/webrev.00/ Issue: The test should be able to pass or skipped by JTreg test suite if required modules have not been included in cu

Re: RFR(M): 8166032: Fix module dependencies for javax.SSL tests

already there, would you mind help to test whether the "/sun/security/krb5/auto" library can be removed for some tests? Thanks, Xuelei On 9/14/2016 8:22 PM, Sergei Kovalev wrote: Hello Team, Could you please review below fix for Bug ID: https://bugs.openjdk.java.net/b

Re: RFR(M): 8166032: Fix module dependencies for javax.SSL tests

n/security/krb5/auto" library can be removed for some tests? Thanks, Xuelei On 9/14/2016 8:22 PM, Sergei Kovalev wrote: Hello Team, Could you please review below fix for Bug ID: https://bugs.openjdk.java.net/browse/JDK-8166032 Code review: http://cr.openjdk.java.net/~skovalev/8166032/we

Re: RFR(S): 8165689: Fix module dependencies for sun/security/pkcs11/* tests

ailures analysis. 14.09.16 18:20, Sean Mullan wrote: Looks fine to me, but can you explain in more detail why the extra dependencies are needed, or an example using --limit-modules? These tests are not failing regularly now, so when do the missing dependencies cause failures? Thanks, Sean On

Re: RFR(M): 8166032: Fix module dependencies for javax.SSL tests

raries and the related modules. As you were already there, would you mind help to test whether the "/sun/security/krb5/auto" library can be removed for some tests? Thanks, Xuelei On 9/14/2016 8:22 PM, Sergei Kovalev wrote: Hello Team, Could you please review below fix for Bug ID:

Re: RFR(S): 8165689: Fix module dependencies for sun/security/pkcs11/* tests

Answered in other thread 14.09.16 18:54, Wang Weijun wrote: Sorry I was thinking about another bug on TLS tests -- 8166032. What exception is thrown there if the jgss module is missing? Thanks Max 在 2016年9月14日，23:44，Wang Weijun > 写道： The example shows jdk.cry

Re: RFR(S): 8165689: Fix module dependencies for sun/security/pkcs11/* tests

d to failures analysis. 14.09.16 18:20, Sean Mullan wrote: Looks fine to me, but can you explain in more detail why the extra dependencies are needed, or an example using --limit-modules? These tests are not failing regularly now, so when do the missing dependencies cause failures? Thanks, Sean

RFR(s): 8166378: Missing dependencies in several java/security tests

Hello team, Please review very small fix for several regression tests. BugID: https://bugs.openjdk.java.net/browse/JDK-8166378 WebReview: http://cr.openjdk.java.net/~skovalev/8166378/webrev.00 Issue: The tests has no declared dependencies on jdk.security modules. This leads the tests to fail i

RFR(s): 8166450: SMARTCARDIO related tests failed on compilation

Hello team, Could you please review small fix for regression tests related to smartcardio API? BugID: https://bugs.openjdk.java.net/browse/JDK-8166450 WebRev: http://cr.openjdk.java.net/~skovalev/8166450/webrev.00/ Issue: unable to run smartcardio related tests bu jtreg by default. Root cause

Re: RFR(s): 8166450: SMARTCARDIO related tests failed on compilation

choose modules described in the @modules tags? Or it's just the standard VM option and you still need to provide the module names yourself? Thanks Max On Sep 21, 2016, at 8:08 PM, Sergei Kovalev wrote: Hello team, Could you please review small fix for regression tests related to smar

Re: RFR(s): 8166378: Missing dependencies in several java/security tests

Hello team, This is re-request for review. 20.09.16 16:32, Sergei Kovalev wrote: Hello team, Please review very small fix for several regression tests. BugID: https://bugs.openjdk.java.net/browse/JDK-8166378 WebReview: http://cr.openjdk.java.net/~skovalev/8166378/webrev.00 Issue: The tests

Re: RFR(s): 8166378: Missing dependencies in several java/security tests

Resending this for review 27.09.16 15:56, Sergei Kovalev wrote: Hello team, This is re-request for review. 20.09.16 16:32, Sergei Kovalev wrote: Hello team, Please review very small fix for several regression tests. BugID: https://bugs.openjdk.java.net/browse/JDK-8166378 WebReview: http

Re: RFR(s): 8166378: Missing dependencies in several java/security tests

Thank you for review 27.09.16 16:06, Xuelei Fan wrote: Looks fine to me. Xuelei On 9/20/2016 9:32 PM, Sergei Kovalev wrote: Hello team, Please review very small fix for several regression tests. BugID: https://bugs.openjdk.java.net/browse/JDK-8166378 WebReview: http://cr.openjdk.java.net

RFR(s): 8169002: [TESTBUG] Several java/net/httpclient have undeclared dependency on java.logging module

Hello all, Please review a small fix for tests. BugID: https://bugs.openjdk.java.net/browse/JDK-8169002 WebRev: http://cr.openjdk.java.net/~skovalev/8169002/webrev.00/ Issue: Several tests from java/net/httpclient folder have undeclared dependency on java.logging module. This issue leads the t

Re: RFR(s): 8169002: [TESTBUG] Several java/net/httpclient have undeclared dependency on java.logging module

.sun.net.httpserver"); />>>>/671 ConsoleHandler ch = new ConsoleHandler(); />>>>/672 logger.setLevel(Level.ALL); />>>>/673 ch.setLevel(Level.ALL); />>>>/674 logger.addHandler(ch); />>>>//>>>>/It's recommended t

RFR(s): JDK-8169866: [TESTBUG] com/sun/security/ tests have undeclared modules dependencies

Hello team, Please review a small fix for security tests. BugID: https://bugs.openjdk.java.net/browse/JDK-8169866 Web review: http://cr.openjdk.java.net/~skovalev/8169866/webrev.00/ Issue: Tests from package com/sun/security failing in case of usage "--limit-modules java.base" command line opt

Re: RFR(s): JDK-8169866: [TESTBUG] com/sun/security/ tests have undeclared modules dependencies

R-sending request for review 17.11.16 15:43, Sergei Kovalev wrote: Hello team, Please review a small fix for security tests. BugID: https://bugs.openjdk.java.net/browse/JDK-8169866 Web review: http://cr.openjdk.java.net/~skovalev/8169866/webrev.00/ Issue: Tests from package com/sun/security

RFR(S): 8173478: SSL related tests failes with message: "java.security.NoSuchAlgorithmException: EC KeyFactory not available"

Hi team, Please review a small fix for tests. Bug ID: https://bugs.openjdk.java.net/browse/JDK-8173478 WebReview: http://cr.openjdk.java.net/~skovalev/8173478/webrev.00/ Issue: Three tests failing during execution with module limitation by "--limit-modules" command line option. Solution: decl

RFR(S): 8173763: Two security tests fail with message: "java.security.NoSuchAlgorithmException: EC KeyFactory not available"

Hi team, Please review a small fix for tests. Bug ID: https://bugs.openjdk.java.net/browse/JDK-8173763 WebReview: http://cr.openjdk.java.net/~skovalev/8173763/webrev.00/ Issue: Two tests failing during execution with module limitation by "--limit-modules" command line option. Solution: declar

RFR(s): 8176213: 78 sun/security/krb5/auto tests failing due to undeclared dependecies

Hello Team, Please review small fix for tests. BugID: https://bugs.openjdk.java.net/browse/JDK-8176213 Webrev: http://cr.openjdk.java.net/~skovalev/8176213/webrev.00 Issue: The tests failing due to undeclared dependencies on jdk.security.auth and jdk.security.jgss. Solution: add missed module

Re: RFR(s): 8176213: 78 sun/security/krb5/auto tests failing due to undeclared dependecies

urity/krb5/auto/principalProperty/PrincipalSystemPropTest.java If you get outjdk.security.auth from the module list the test will start failing. Thanks Max On 03/07/2017 12:24 AM, Sergei Kovalev wrote: Hello Team, Please review small fix for tests. BugID: https://bugs.openjdk.java.net/browse/JDK

Re: RFR(s): 8176213: 78 sun/security/krb5/auto tests failing due to undeclared dependecies

Good point. For same reason I've removed module declaration from PrincipalSystemPropTest.java. Now it uses TETS.properties config. Please take a look. http://cr.openjdk.java.net/~skovalev/8176213/webrev.01/ 07.03.17 13:30, Weijun Wang wrote: On 03/07/2017 05:50 PM, Sergei Kovalev

Re: RFR 8176296: Test sun/security/krb5/auto/Basic.java faling after adding module declaration into TEST.properties.

Thanks that let me see. Good to know. 07.03.17 17:10, Weijun Wang wrote: Please review this changeset at http://cr.openjdk.java.net/~weijun/8176296/webrev.00/ It looks with jdk.security.jgss added into @modules in TEST.properties (JDK-8176213), it cannot be exclude using --limit-modules.

RFR(s): 8177324: Some javax/security/ tests don't have correct module dependencies

Hi team, Please review below small fix for security tests. BugID: https://bugs.openjdk.java.net/browse/JDK-8177324 Review: http://cr.openjdk.java.net/~skovalev/8177324/webrev.00 Issue: missed dependency declaration in some security tests. -- With best regards, Sergei