Changeset: b9587f41fd55
Author:smarks
Date: 2013-06-18 17:18 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/rev/b9587f41fd55
8016780: README-builds.html misses crucial requirement on bootstrap JDK
Reviewed-by: dholmes, chegar
! README-builds.html
Changeset: 6729f7ef94cd
Author:smarks
Date: 2013-06-27 13:35 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6729f7ef94cd
8019224: add exception chaining to RMI CGIHandler
Reviewed-by: darcy
! src/share/classes/sun/rmi/transport/proxy/CGIHandler.java
Hi Bernd,
A fair question. The Throwable.printStackTrace() call goes to the standard
error stream, which is *usually* not mixed with the HTTP response collected
from stdout and thus shouldn't spoil the protocol. But this really depends on
how it's invoked. My assumption is that stderr is usual
Changeset: 09a77a1bdbc3
Author:henryjen
Date: 2013-07-30 15:47 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/09a77a1bdbc3
8020977: StringJoiner merges with itself not as expected
Reviewed-by: psandoz, chegar, mduigou, smarks
! src/share/classes/java/util/StringJoiner.java
!
On 8/5/13 9:16 AM, Tom Hawtin wrote:
On 01/08/2013 06:36, Xuelei Fan wrote:
An anonymous class cannot make any guarantees about serialization
compatibility since has a compiler-generated, implementation-specific
name that may vary uncontrollably. It is nonsensical for an anonymous
class to defin
Changeset: 31759750ff63
Author:smarks
Date: 2013-08-05 19:12 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/31759750ff63
8020854: change RMI javadocs to specify that remote objects are exported to the
wildcard address
Reviewed-by: rgallard, alanb
! src/share/classes/java/rm
Changeset: 12c1b78acf9a
Author:lagergren
Date: 2013-08-06 12:56 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/12c1b78acf9a
8022412: Fixed warnings in java.util root, except for HashMap
Reviewed-by: mduigou, darcy
Contributed-by: marcus.lagerg...@oracle.com
! src/share/class
On 8/5/13 7:41 PM, Bernd Eckenfels wrote:
! src/share/classes/java/rmi/server/RMISocketFactory.java
I think setting the rmi server name to localhost is a dangerous recommendation.
It might happen that it resolves to a IPv4 or IPv6 only address on a dual
socket host. And InetAddress.getLoopbackA
Changeset: 31e923842d49
Author:smarks
Date: 2013-08-06 14:24 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/31e923842d49
8022440: suppress deprecation warnings in sun.rmi
Reviewed-by: mduigou
! src/share/classes/sun/rmi/runtime/Log.java
! src/share/classes/sun/rmi/server/Act
Changeset: 8c50c27418d3
Author:smarks
Date: 2013-08-07 16:29 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8c50c27418d3
8022479: clean up warnings from sun.tools.asm
Reviewed-by: lancea, darcy
! src/share/classes/sun/tools/asm/Assembler.java
! src/share/classes/sun/tools/as
Changeset: 7496ec8bab76
Author:smarks
Date: 2013-08-22 15:54 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7496ec8bab76
8022445: fix RMISocketFactory example to avoid using localhost
Reviewed-by: chegar, alanb
! src/share/classes/java/rmi/server/RMISocketFactory.java
Changeset: 6731ea9123f2
Author:smarks
Date: 2013-09-09 14:11 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6731ea9123f2
8023447: change specification to allow RMI activation to be optional
Reviewed-by: darcy, alanb, olagneau
! src/share/classes/java/rmi/activation/Activatab
Changeset: 9fbf35589211
Author:smarks
Date: 2013-10-22 14:51 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9fbf35589211
8026427: deprecate obsolete APIs from java.rmi
Reviewed-by: alanb, dfuchs
! src/share/classes/java/rmi/RMISecurityManager.java
! src/share/classes/java/rm
Changeset: 808b9ef4f667
Author:smarks
Date: 2013-10-24 10:13 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/808b9ef4f667
8023862: deprecate HTTP proxying from RMI
Reviewed-by: mchung
! src/share/classes/java/rmi/server/RMISocketFactory.java
! src/share/classes/java/rmi/serve
Changeset: 8ea272253285
Author:smarks
Date: 2013-10-25 14:53 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8ea272253285
5063500: Formatter spec says "char" is not an integral type
7126305: Wrong Unicode value specified for format conversion character 'd'
8027287: incorrect e
Changeset: 1ea1b24c1a04
Author:smarks
Date: 2013-10-30 18:39 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1ea1b24c1a04
8023863: deprecate support for statically-generated stubs from RMI (JRMP)
4449028: exportObject() javadoc should specify behavior for null socket
factorie
Changeset: f6012ca3bdd3
Author:smarks
Date: 2013-11-12 16:59 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f6012ca3bdd3
8028027: serialver should emit declaration with the 'private' modifier
Reviewed-by: darcy, mchung, alanb, chegar
! src/share/classes/sun/tools/serialver/S
Changeset: 19d2e9649138
Author:smarks
Date: 2013-11-19 15:05 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/19d2e9649138
8028638:
java/rmi/activation/Activatable/checkRegisterInLog/CheckRegisterInLog.java fails
Reviewed-by: lancea
! test/java/rmi/testlibrary/RMID.java
Changeset: df819e356901
Author:tyan
Date: 2013-12-03 14:36 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/df819e356901
7190106: java/rmi/reliability/benchmark fails intermittently because of use of
fixed port
Reviewed-by: smarks, mduigou
! test/ProblemList.txt
! test/java/r
Changeset: accd6ffd4b3f
Author:smarks
Date: 2013-12-03 15:52 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/accd6ffd4b3f
8028757: CharSequence.subSequence improperly requires a "new" CharSequence be
returned
Reviewed-by: alanb, darcy, mduigou
! src/share/classes/java/lang/C
Changeset: c6b6b515cf4f
Author:smarks
Date: 2013-12-03 18:19 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c6b6b515cf4f
8029489: StringJoiner spec for setEmptyValue() and length() is malformatted
Reviewed-by: darcy, lancea, mduigou
! src/share/classes/java/util/StringJoiner
Changeset: 6c343d3d2721
Author:smarks
Date: 2013-12-13 18:08 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6c343d3d2721
8027536: rmic: add deprecation warning message when generating JRMP static
stubs/skeletons
Reviewed-by: mchung, dmocek
! src/share/classes/sun/rmi/rmic/M
Changeset: 449dfb061fde
Author:smarks
Date: 2010-12-20 13:47 -0800
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/449dfb061fde
6880112: Project Coin: Port JDK core library code to use diamond operator
Reviewed-by: darcy, lancea, alanb, briangoetz, mduigou, mchung
! src/share/class
Hi all,
As you may have heard [1], I'm working on updating the JDK libraries to use
some Project Coin features. Currently I'm working on converting the library
code to use the "diamond" operator for more concise generic creation
expressions. Up now is conversion of the JCA and crypto provider
Here's another batch of diamond conversion changes.
Max, can you review this please? Webrev is here:
http://cr.openjdk.java.net/~smarks/reviews/7008713/webrev.0/
Thanks!
s'marks
The third batch of diamond conversions in the security area. This one's for
Sean. Can you review this? Webrev is here:
http://cr.openjdk.java.net/~smarks/reviews/7008728/webrev.0/
In particular, take a look at
src/share/classes/javax/security/auth/Subject.java
It looks like the converter migh
On 12/22/10 5:45 PM, Weijun Wang wrote:
Looks fine.
Great!
BTW, what are we supposed to review? Besides going through the patch and making
sure each change is good, the only thing I can think of is looking for lines
need coinification but untouched. Made some simple greps and found none yet.
On 12/22/10 6:19 PM, Brad Wetmore wrote:
Using the diamond operator definitely makes the code *shorter*. Whether
it's *better* doesn't necessarily follow from that. In most cases,
though, using diamond is better, I think.
I'd be curious if you saw any instances where you thought that it would
On 12/22/10 6:17 PM, Brad Wetmore wrote:
You need to update the Copyright updates on these files to include 2010.
Is this the standard, to update the copyright to the current year anytime the
file is touched? If so, then yes, I can do this.
Minor nit, can you add a space in line 221 between
On 12/27/10 11:58 AM, Sean Mullan wrote:
One instance where I think it is debatable as to whether it improves code
readability is if the variable is declared somewhere else in the code. In these
cases I find myself scrolling upwards or searching to find the declaration to
see what type the parame
On 12/27/10 12:15 PM, Sean Mullan wrote:
On 12/22/10 8:39 PM, Stuart Marks wrote:
http://cr.openjdk.java.net/~smarks/reviews/7008728/webrev.0/
src/share/classes/com/sun/security/auth/SubjectCodeSource.java
[96] Looks like the converter also missed another one. I think this line
should be
On 12/29/10 8:28 AM, Sean Mullan wrote:
I don't really have a strong opinion, but I might be annoyed if there were a
complex set of guidelines as to when to use the diamond operator and when not
to. Anyway, maybe we should see if the JSR 334 expert group has any additional
thoughts?
I talked to
Here's an updated webrev for 7005608.
I've removed the changes that use diamond in assignment statements. In these
cases the variable is declared elsewhere, so using diamond for these makes the
code somewhat less understandable. I've left in the use of diamond for variable
initializers (which
Hi Sean,
Here's an updated webrev for 7008728 which we had discussed earlier.
Basically this webrev includes ONLY changes that use diamond in the initializer
of a variable or field declaration, where the inferred type of the diamond is
right there in the declaration. I've removed all the use o
Great, I'll make this change and push the changeset.
Thanks!
s'marks
On 1/7/11 8:35 AM, Sean Mullan wrote:
Hi Stuart,
It all looks good to me. One minor comment:
Security.java
[662]: add a space: s/Map/Map
--Sean
On 1/6/11 7:16 PM, Stuart Marks wrote:
Hi Sean,
Here's an
Changeset: 3dbc783a8073
Author:smarks
Date: 2011-01-07 15:39 -0800
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/3dbc783a8073
7008728: diamond conversion of basic security, permissions, authentication
Reviewed-by: mullan
! src/share/classes/com/sun/security/auth/PolicyFile.java
!
Oops! I made this change (and rebuilt and tested) but I forgot to qrefresh
before pushing it, so this didn't actually get in.
Hrmm, well, I guess I'll piggyback this onto one of the other pending changes
in the security area.
Sorry about that Chief,
s'marks
On 1/7/11 3:36 P
Changeset: 2a0ff59928de
Author:smarks
Date: 2011-01-10 17:06 -0800
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/2a0ff59928de
7005608: diamond conversion of JCA and crypto providers
Reviewed-by: wetmore
! src/share/classes/java/security/Security.java
! src/share/classes/sun/secur
Changeset: 6d0217114886
Author:smarks
Date: 2011-01-11 13:42 -0800
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/6d0217114886
7011095: revert diamond changes from 6880112 that occur in method args
Reviewed-by: darcy, alanb
! src/share/classes/com/sun/java/util/jar/pack/BandStruct
Hi Max,
Here, finally, is an updated webrev for 7008713. Like the other updates, this
is the automated diamond conversion but with diamonds removed from assignment
statements. This is mostly diamonds used in variable initializers. I think
there's one in a return statement in there too.
I've
Hi Max, thanks for reviewing the webrev.
On 1/11/11 5:25 PM, Weijun Wang wrote:
On 01/12/2011 08:06 AM, Stuart Marks wrote:
I think there's one in a return statement in there too.
You mean this one?
public static Pair of(A a, B b) {
- return new Pair(a,b);
+ return new Pair<>
is really frustrating.
And I prefer HashSet>, my rule is that space is only
inserted after "," unless *all* parameters have only one letter.
Thanks
Max
On 01/12/2011 11:04 AM, Stuart Marks wrote:
Hi Max, thanks for reviewing the webrev.
On 1/11/11 5:25 PM, Weijun Wang wrote:
On 0
Changeset: a5a22f93e4c5
Author:smarks
Date: 2011-01-12 13:52 -0800
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/a5a22f93e4c5
7008713: diamond conversion of kerberos5 and security tools
Reviewed-by: weijun
! src/share/classes/sun/security/krb5/Config.java
! src/share/classes/sun/
Hi Valerie,
You're up next for diamond conversion. :-)
These should be pretty straightforward. Almost all changes are variable
initializations. There's one return statement, one use of diamond in a ternary
operator (a ? b : c), and one whitespace fixup.
Webrev is here:
http://cr.openjdk.jav
Hi Andrew,
Here's another round of diamond conversion changes, this time for ssl. This
changeset is also pretty straightforward: all diamonds are in declarations with
the exception of one return statement.
Here's the webrev:
http://cr.openjdk.java.net/~smarks/reviews/7012003/webrev.0/
Thank
y more.
Thanks,
Andrew
On 1/13/2011 1:52 PM, Bradford Wetmore wrote:
Looks fine to me. Andrew can also review if you like.
Brad
On 1/12/2011 5:45 PM, Stuart Marks wrote:
Hi Andrew,
Here's another round of diamond conversion changes, this time for ssl.
This changeset is also pretty
the usage of this diamond operator. Is this so?
If not, then we need to update the sunpkcs11.jar also.
Thanks,
Valerie
On 01/12/11 05:30 PM, Stuart Marks wrote:
Hi Valerie,
You're up next for diamond conversion. :-)
These should be pretty straightforward. Almost all changes are variable
/13/11 04:15 PM, Stuart Marks wrote:
Yes, the byte codes are identical. I compiled with -g:none before and after
the changes and the classfiles are all identical. (Even though the bytecodes
are identical, the classfiles would differ because of changed line number
information, which is disabled wit
stack info will
not match the source code.
Max
On 01/14/2011 08:15 AM, Stuart Marks wrote:
Yes, the byte codes are identical. I compiled with -g:none before and
after the changes and the classfiles are all identical. (Even though the
bytecodes are identical, the classfiles would differ becau
eCache =
- new HashMap(8);
+ new HashMap<>(8);
Thanks,
Andrew
On 1/14/2011 11:02 AM, Stuart Marks wrote:
I did full clean builds of the JDK repo with -g:none, both with and
without the diamond changes. I then compared all of the .class files in
the two builds using the "cmp" comma
Changeset: d61d9bf190f5
Author:smarks
Date: 2011-01-14 15:31 -0800
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/d61d9bf190f5
7012003: diamond conversion for ssl
Reviewed-by: wetmore
! src/share/classes/sun/security/ssl/CipherSuite.java
! src/share/classes/sun/security/ssl/Cipher
Changeset: 6e33b377aa6e
Author:smarks
Date: 2011-02-16 18:22 -0800
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/6e33b377aa6e
7018392: update URLJarFile.java to use try-with-resources
Reviewed-by: alanb, chegar, hawtin
! src/share/classes/sun/net/www/protocol/jar/URLJarFile.java
Changeset: 5bf920749b97
Author:smarks
Date: 2011-02-18 12:43 -0800
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/5bf920749b97
7018385: update javax.sql classes to use try-with-resources
Reviewed-by: alanb, lancea, darcy
! src/share/classes/javax/sql/rowset/serial/SerialClob.java
Changeset: 84e339f1033b
Author:smarks
Date: 2011-02-22 15:34 -0800
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/84e339f1033b
7021209: convert lang, math, util to use try-with-resources
Reviewed-by: alanb, darcy, naoto
! src/share/classes/java/lang/Package.java
! src/share/classe
Changeset: b74f1b830484
Author:smarks
Date: 2011-02-24 22:26 -0800
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/b74f1b830484
7022383: add reference to CR for ReadLongZipFileName test to problem list
Reviewed-by: ohair
! test/ProblemList.txt
Changeset: 8887cb2f5d19
Author:smarks
Date: 2011-02-25 02:06 -0800
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/8887cb2f5d19
7021582: convert jar/zip code and tests to use try-with-resources
Reviewed-by: alanb, dholmes, sherman
! src/share/classes/java/util/jar/JarFile.java
! te
Changeset: 98d2d57d9e73
Author:smarks
Date: 2011-03-01 15:05 -0800
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/98d2d57d9e73
7022624: use try-with-resources in java.io tests
Reviewed-by: alanb
! test/java/io/File/SetLastModified.java
! test/java/io/FileOutputStream/AtomicAppend.
Changeset: 192bbf6cd5de
Author:smarks
Date: 2011-03-17 18:50 -0700
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/192bbf6cd5de
7022382: convert pack200 library code to use try-with-resources
Reviewed-by: ksrini
! src/share/classes/com/sun/java/util/jar/pack/BandStructure.java
! sr
Changeset: f326a018fd3f
Author:smarks
Date: 2011-03-24 17:26 -0700
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/f326a018fd3f
7029680: fix test/sun/misc/Version/Version.java build parsing
Reviewed-by: ohair
! test/sun/misc/Version/Version.java
Changeset: 00f3997e6aeb
Author:smarks
Date: 2011-04-20 16:30 -0700
URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/00f3997e6aeb
6896297: (rmi) fix ConcurrentModificationException causing TCK failure
Reviewed-by: alanb, dholmes, peterjones
! src/share/classes/sun/rmi/log/ReliableLog
On 6/28/11 11:46 AM, Sean Mullan wrote:
On 6/27/11 9:29 PM, Xuelei Fan wrote:
webrev: http://cr.openjdk.java.net/~xuelei/7059709/webrev.00/
It seems you could restructure this code by moving the instantiation of the
FileInputStream down just before the KeyStore.load and use a try-with-resource
On 7/7/11 10:05 PM, Bradford Wetmore wrote:
My only comment is in the diff section. I realize it's a FileInputStream and
all the bytes should be obtained on a read, but I think you might want to
consider the case of a short read for whatever reason. FileInputStream doesn't
guarantee that all byte
On 7/8/11 12:55 AM, Weijun Wang wrote:
The diff method is now --
private static void diff(String fname1, String fname2) throws Exception {
if (!Arrays.equals(Files.readAllBytes(new File(fname1).toPath()),
Files.readAllBytes(new File(fname2).toPath( {
throw new Exce
Changeset: 3f66f9ca1ba5
Author:smarks
Date: 2011-08-12 14:51 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3f66f9ca1ba5
7076526: add test MemoryMXBean/CollectionUsageThreshold to the problem list
Reviewed-by: weijun, alanb
! test/ProblemList.txt
Changeset: 43a630f11af6
Author:smarks
Date: 2011-11-30 13:11 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/43a630f11af6
7116322: enhance javac make rule with a little bit of instrumentation
Reviewed-by: dholmes, ohair
! make/common/Rules.gmk
Changeset: 0e3f706741ca
Author:smarks
Date: 2011-12-01 16:14 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0e3f706741ca
7116890: additional warnings fixes for java.io
Reviewed-by: alanb, smarks
Contributed-by: Sebastian Sickelmann
! src/share/classes/java/io/ExpiringCache.
Changeset: f4fe86bba8a2
Author:smarks
Date: 2011-12-05 16:30 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f4fe86bba8a2
7116993: fix warnings in java.applet
Reviewed-by: art, smarks
Contributed-by: Danesh Dadachanji
! src/share/classes/java/applet/Applet.java
Changeset: 77f6d4360f4b
Author:smarks
Date: 2011-12-06 10:14 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/77f6d4360f4b
7116997: fix warnings in java.util.PropertyPermission
Reviewed-by: smarks
Contributed-by: Brandon Passanisi
! src/share/classes/java/util/PropertyPermiss
Changeset: 4f0f9f9c4892
Author:smarks
Date: 2011-12-07 12:12 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4f0f9f9c4892
7117249: fix warnings in java.util.jar, .logging, .prefs, .zip
Reviewed-by: alanb, dholmes, forax, sherman, smarks
Contributed-by: Prasannaa , Martijn Verb
Webrev is here:
http://cr.openjdk.java.net/~smarks/reviews/7118546/webrev.0/
Notes:
In addition to changes to javax.xml.crypto, this webrev also includes a change
to a file in javax.script. This package (among others) is included in the same
build step as javax.xml.crypto, specifically in jdk
On 12/8/11 9:24 AM, Sean Mullan wrote:
Now that they are warning free, should there also be a change to the Makefile?
Eventually yes. I'll coordinate with Kurchi on this, but we probably want to
add -Werror to various makefiles in the future, after we do more testing to
ensure that we don't s
Changeset: 9bb7c3b97384
Author:smarks
Date: 2011-12-08 14:57 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9bb7c3b97384
7118546: fix warnings in javax.xml.crypto, javax.script
Reviewed-by: mullan
! src/share/classes/javax/script/ScriptException.java
! src/share/classes/java
Changeset: abbca81a98a7
Author:smarks
Date: 2011-12-17 08:21 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/abbca81a98a7
7122235: stop the build if javac fails
Reviewed-by: chegar, dholmes, mcimadamore, ohair
! make/common/Rules.gmk
Changeset: 3a7ea63302f8
Author:smarks
Date: 2011-12-29 16:39 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3a7ea63302f8
7122061: add -Xlint:all -Werror to warning-free build steps
Reviewed-by: chegar, alanb, dholmes, ohair
! make/com/sun/demo/jvmti/hprof/Makefile
! make/com
Changeset: 445ada5e6b4a
Author:smarks
Date: 2012-02-12 21:56 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/445ada5e6b4a
7143230: fix warnings in java.util.jar, sun.tools.jar, zipfs demo, etc.
Reviewed-by: alanb, chegar, lancea, smarks
Contributed-by: Mani Sarkar , Michael Ba
Changeset: 19c6ad447258
Author:dmocek
Date: 2012-04-04 15:57 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/19c6ad447258
7159130: add java/rmi/transport/pinClientSocketFactory to problem list
Reviewed-by: smarks
! test/ProblemList.txt
Changeset: f131d4361faf
Author:olagneau
Date: 2012-05-11 14:13 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f131d4361faf
7144861: speed up RMI activation tests
Reviewed-by: alanb, smarks, dholmes, dmocek
! test/java/rmi/activation/checkusage/CheckUsage.java
! test/java/rmi
Changeset: e309917fb9af
Author:dbhole
Date: 2012-05-24 19:00 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e309917fb9af
7117230: clean up warnings in java.text
Reviewed-by: jrose, smarks
! src/share/classes/java/text/AttributedCharacterIterator.java
! src/share/classes/java
Changeset: 9df29b658145
Author:smarks
Date: 2012-06-29 16:16 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9df29b658145
7170938: (str) incorrect wording in doc for String.subSequence
Reviewed-by: forax, mduigou
Contributed-by: Joe Bowbeer
! src/share/classes/java/lang/Stri
Changeset: b2fc66012451
Author:smarks
Date: 2012-07-02 14:11 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b2fc66012451
7176907: additional warnings cleanup in java.util, java.util.regexp,
java.util.zip
Reviewed-by: forax, khazra, smarks
Contributed-by: Mani Sarkar
! src/
Changeset: 97eb7a4b1fdd
Author:smarks
Date: 2012-07-05 15:12 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/97eb7a4b1fdd
6948101: java/rmi/transport/pinLastArguments/PinLastArguments.java failing
intermittently
Reviewed-by: dholmes, smarks
Contributed-by: Eric Wang
! test/
Changeset: 4ad204cc7433
Author:smarks
Date: 2012-07-05 15:13 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4ad204cc7433
7123972: test/java/lang/annotation/loaderLeak/Main.java fails intermittently
Reviewed-by: dholmes, smarks
Contributed-by: Eric Wang
! test/ProblemList.tx
Changeset: b6f78869c66d
Author:dmocek
Date: 2012-07-17 11:01 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b6f78869c66d
7142596: RMI JPRT tests are failing
Summary: Changed RMI tests to use random port numbers for the RMI Registry and
RMID so the tests can be run concurrent
Changeset: 89129c0737f1
Author:dmocek
Date: 2012-07-18 10:04 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/89129c0737f1
7184943: fix failing test
com/sun/jndi/rmi/registry/RegistryContext/UnbindIdempotent.java
7184946: fix failing test
com/sun/jndi/rmi/registry/RegistryCon
Changeset: 018e555a7a07
Author:dmocek
Date: 2012-07-27 16:53 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/018e555a7a07
7186111: fix bugs in
java/rmi/activation/ActivationSystem/unregisterGroup/UnregisterGroup
Reviewed-by: smarks, jgish
! test/java/rmi/activation/Activatio
Changeset: 8a82e5f9c47f
Author:dmocek
Date: 2012-08-02 18:12 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8a82e5f9c47f
7187876: ClassCastException in TCPTransport.executeAcceptLoop
Reviewed-by: dholmes, smarks
! src/share/classes/sun/rmi/transport/tcp/TCPTransport.java
Changeset: f9b11772c4b2
Author:smarks
Date: 2012-08-30 18:53 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f9b11772c4b2
7195099: update problem list with RMI test failures
Reviewed-by: alanb
! test/ProblemList.txt
Changeset: 1f7c783e4f13
Author:dxu
Date: 2012-08-31 13:42 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1f7c783e4f13
7193406: Clean-up JDK Build Warnings in java.util, java.io
Summary: Clean-up JDK Build Warnings in java.util, java.io Packages
Reviewed-by: smarks, darcy, kha
On 9/25/12 12:58 AM, Alan Bateman wrote:
On 25/09/2012 05:16, Weijun Wang wrote:
Hi Stuart
Please take a look at
http://cr.openjdk.java.net/~weijun/7200682/webrev.00/
So I am now using "java -XshowSettings:properties | grep os.arch" to find out
the arch. Not sure if there is a more formal
Changeset: ab1ab9b148dd
Author:smarks
Date: 2012-11-28 17:31 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/rev/ab1ab9b148dd
8004131: move jdi tests out of core testset
Reviewed-by: alanb, chegar
! make/jprt.properties
Changeset: 83d9f30ebeed
Author:smarks
Date: 2012-11-28 17:31 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/83d9f30ebeed
8004131: move jdi tests out of core testset
Reviewed-by: alanb, chegar
! make/jprt.properties
Changeset: 7ccf93c60c4d
Author:smarks
Date: 2012-11-29 14:43 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7ccf93c60c4d
8004134: More ProblemList.txt updates (11/2012)
Reviewed-by: alanb
Contributed-by: amy...@oracle.com
! test/ProblemList.txt
Changeset: a971516029ab
Author:jgish
Date: 2012-12-05 21:08 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a971516029ab
8004317: TestLibrary.getUnusedRandomPort() fails intermittently, but exception
not reported
Reviewed-by: alanb, dmocek, smarks
! test/java/rmi/testlibrary
Changeset: 56fd5479a98f
Author:jgish
Date: 2012-12-12 15:37 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/56fd5479a98f
8004651: TEST: java/util/logging/CheckLockLocationTest.java failed to delete
file (win)
Summary: Failure to delete test log file should be a warning instea
Changeset: 60adb69bf043
Author:smarks
Date: 2012-12-20 20:11 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/60adb69bf043
8005290: remove -showversion from RMI test library subprocess mechanism
Reviewed-by: jgish, chegar, dmocek
! test/java/rmi/testlibrary/JavaVM.java
! test/
Changeset: 0cfcba56cfa7
Author:jgish
Date: 2012-12-28 18:32 -0500
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0cfcba56cfa7
8005594: Fix to 8003265 breaks build
Summary: backout changeset 4472a641b4dc
Reviewed-by: smarks, wetmore
! src/share/classes/com/sun/jndi/dns/DnsContext.j
Changeset: cc78ceb99284
Author:jgish
Date: 2012-12-28 16:56 -0500
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/cc78ceb99284
8005118: Javadoc styles are inconsistent
Summary: use a common javadoc style in the String classes
Reviewed-by: darcy
! src/share/classes/java/lang/Abstrac
Changeset: 92c3b24a8e9a
Author:smarks
Date: 2013-01-04 16:10 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/92c3b24a8e9a
8005683: ProblemList.txt updates (01/2013)
Reviewed-by: mchung, alanb
Contributed-by: amy...@oracle.com
! test/ProblemList.txt
Changeset: 797e8a3dcd51
Author:smarks
Date: 2013-01-07 18:09 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/797e8a3dcd51
7187882: TEST_BUG: java/rmi/activation/checkusage/CheckUsage.java fails
intermittently
Summary: Tighten up JavaVM test library API, and adjust tests to ma
Changeset: 13ff1089e625
Author:jgish
Date: 2013-01-10 15:09 -0500
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/13ff1089e625
8005582: java/lang/Runtime/exec/WinCommand.java intermittent test failures
Summary: Remove file-deletion code at cleanup which conflicts with jtreg cleanup
1 - 100 of 151 matches
Mail list logo
