Re: RFR 8047765: Generate blacklist.certs in build

On 04/07/2014 07:33, Wang Weijun wrote: : Correct, and there is a jdk/make/data directory and data for other tools are already there. Webrev updated at http://cr.openjdk.java.net/~weijun/8047765/webrev.01/. Thanks for moving it, the updated webrev looks good to me. -Alan.

Re: On 8038089: TLS optional support for Kerberos cipher suites needs to be re-examine

On 21/07/2014 09:22, Wang Weijun wrote: Please review the updated webrev at http://cr.openjdk.java.net/~weijun/8038089/webrev.01 Some comment changes. Some arguments rearrangement between classes. The interface is still in sun.security.ssl. It will be easy to move it to somewhere else late

Re: On 8038089: TLS optional support for Kerberos cipher suites needs to be re-examine

On 22/07/2014 02:09, Wang Weijun wrote: : It's meant to be a general solution, and that's why I add a support() method. Said that, we have no idea what a non-KRB5 not-certificate-based cipher suite would look like. As for Krb5Helper, it's only used by KRB5 cipher suites. I don't want to modif

Re: The future of Serialization

On 09/08/2014 06:56, Peter Firmstone wrote: I've noticed there's not much interest in improving Serialization on these lists. This makes me wonder if java Serialization has lost relevance in recent years with the rise of protocol buffers apache thrift and other means of data transfer over byt

Re: The future of Serialization

On 11/08/2014 13:06, Peter Firmstone wrote: Thanks Alan, I can relate to time poverty :) I might be assuming too much, but if there's interest in doing something with Serialization, I'd be interested in learning about plans or difficulties involved in deserialization and modules. It can be a

Re: The future of Serialization

On 12/08/2014 10:03, Peter Firmstone wrote: Interesting, language features for modules, won't necessarily involve ClassLoader's (my assumptions were based on existing systems) although you'd expect modules to have their own ProtectionDomain. I think it would be reasonable to expect to that y

Re: Trusted service?

On 13/08/2014 11:10, Wang Weijun wrote: Hi All I'm working on "8038089: TLS optional support for Kerberos cipher suites needs to be re-examine" which will separate the implementation of Kerberos-related TLS ciphersuites from the other TLS codes. I am thinking of defining a ServiceLoader inter

Re: Trusted service?

On 14/08/2014 01:34, Wang Weijun wrote: Yes, I see a lot of places using if (loadProviderFromProperty()) return provider; if (loadProviderAsService()) return provider; The 1st using Class.forName() and 2nd ServiceLoader.load(). I was thinking that the 1st method will no

Re: Trusted service?

On 22/08/2014 09:09, Wang Weijun wrote: : Great, this works for me. But why does it need to be called in a doPrivileged() block? Isn't it only about JDK-internal classes/resources? It's a public API so it can be used by anyone. The question about privileges and limiting them is a good quest

Re: Replace concat String to append in StringBuilder parameters

On 25/08/2014 03:03, Wang Weijun wrote: New webrevs updated http://cr.openjdk.java.net/~weijun/8055723/core/webrev.00/ Includes modules java.base and security-related modules and the jarsigner tool http://cr.openjdk.java.net/~weijun/8055723/client/webrev.00 Includes the java.desktop mo

Re: RFR 8042900: Allow com.sun.security.jgss to be in different module than org.ietf.jgss

On 27/08/2014 08:17, Wang Weijun wrote: Hi All Please review the code change at http://cr.openjdk.java.net/~weijun/8042900/webrev.00/ The purpose of this fix is to move com.sun.security.jgss (where the ExtendedGSSXXX classes reside) out of the java.security.jgss module, since it is openj

Re: RFR 8042900: Allow com.sun.security.jgss to be in different module than org.ietf.jgss

On 28/08/2014 10:36, Wang Weijun wrote: : In fact, I have a question. Is there a way to run a test with a module invisible? I can try my tests by removing the com.sun.security.jgss classes manually but that won't work for automatic regression tests. There is requirement for launch-time config

Re: RFR 8056141: Move com.sun.security.jgss into a new module

On 28/08/2014 11:28, Wang Weijun wrote: This is the sub-task of "8042900: Allow com.sun.security.jgss to be in different module than org.ietf.jgss" that actually moves the files. Code changes include 2 parts: 1. For jdk9/dev repo: http://cr.openjdk.java.net/~weijun/8056141/webrev.00/ 2.

Re: RFR 8056141: Move com.sun.security.jgss into a new module

On 28/08/2014 14:02, Wang Weijun wrote: On Aug 28, 2014, at 18:52, Alan Bateman wrote: http://cr.openjdk.java.net/~weijun/8056141/webrev.00/ Max - the main thing is that is missing in this is the update to modules.xml, this is temporary document that is checked into the top-level repo

Re: RFR 8042900: Allow com.sun.security.jgss to be in different module than org.ietf.jgss

On 28/08/2014 10:36, Wang Weijun wrote: Hi Alan Thanks for the review. All suggestions accepted. Change for S4U2selfGSS is not related and can be reverted. I've looked through webrev.01 and you've addressed all my comments. A small item but the new JgssExtender.java needs a copyright header b

Re: RFR 8039898: sunpkcs11-solaris.cfg should be in solaris specific directory

On 11/09/2014 10:38, Magnus Ihse Bursie wrote: On 2014-09-10 18:28, Valerie Peng wrote: Could someone please review this build related change for moving sunpkcs11-solaris.cfg file to the pkcs11 module? Webrev: http://cr.openjdk.java.net/~valeriep/8039898/webrev.00/ Looks good. However, I'l

Re: RFR: JDK-8058845 : Update JCE environment for build improvements

On 21/09/2014 23:51, Bradford Wetmore wrote: Hi Sean/Mandy/Erik/Magnus/Alan/David/others, Please review: JDK-8058845 : Update JCE environment for build improvements http://cr.openjdk.java.net/~wetmore/8058845/ This change is to alleviate some of the overly-complicated steps we (Oracl

Re: RFR 8058657: Add @jdk.Exported to com.sun.jarsigner APIs

On 29/09/2014 20:14, Wang Weijun wrote: Hi All Please review the code change at http://cr.openjdk.java.net/~weijun/8058657/webrev.00/ It includes both the dev repo and dev/jdk repo. While the change in dev/jdk is useless with today's modules environment, it is included here and will be b

Re: [concurrency-interest] Here's why Atomic*FieldReference access checking is broken

On 03/10/2014 08:13, David M. Lloyd wrote: : Why the problem occurs -- The root of the problem traces back to SecurityManager.checkMemberAccess(). This method is the one remaining method in all of SecurityManager which uses the calling class context (stack) in order to de

Re: [9] rfr 8034031: [parfait] JNI exception pending in jdk/src/macosx/native/apple/security/KeystoreImpl.m

On 14/11/2014 11:08, Vincent Ryan wrote: Please review this fix to check for pending exceptions in JNI: Bug: https://bugs.openjdk.java.net/browse/JDK-8034031 Webrev: http://cr.openjdk.java.net/~vinnie/8034031/webrev.00/ This looks oka

Re: RFR: JDK-8047769 SecureRandom should be more frugal with file descriptors

On 24/12/2014 11:37, Peter Levart wrote: Hi Brad, Thanks for looking into this. Here's updated webrev: http://cr.openjdk.java.net/~plevart/jdk9-dev/FileInputStreamPool.8047769/webrev.02/ This mostly looks good to me too, except the permission checking. As I read it, getInputStream uses get

Re: RFR: JDK-8047769 SecureRandom should be more frugal with file descriptors

On 29/12/2014 09:45, Peter Levart wrote: Thanks for looking at this, Alan. You're right about File.getCanonicalFile(). It already checks read permission for a file. The additional explicit check is superfluous. I have removed it. With explicit check I wanted the API to behave uniformly rega

Re: RFR 8071562: TimestampCheck.java change removes a whitespace between command and args

On 26/01/2015 13:45, Weijun Wang wrote: Ah yes, a whitespace was mistakenly removed. Please review my fix at http://cr.openjdk.java.net/~weijun/8071562/webrev.00/ It's simply cmd = System.getProperty("java.home") + "/bin/jarsigner"; } - cmd += System.getProperty("test.too

Re: Review request 8069551: Move java.security.acl from compact3 to java.base

On 29/01/2015 20:58, Mandy Chung wrote: Webrev at: http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8069551/webrev.00 java.security.acl is superceded by java.security package since 1.2. This patch proposes to move java.security.acl package to java.base module rather than complicating the module

Re: RFR JDK-8071338: Move policytool from JRE to JDK

On 06/02/2015 02:18, Weijun Wang wrote: Hi All Please review this change at root: http://cr.openjdk.java.net/~weijun/8071338/root/webrev.00/ jdk: http://cr.openjdk.java.net/~weijun/8071338/jdk/webrev.00/ No actual java code change, just move everything inside the s.s.t.policytool into anothe

Re: [9] Review Request: 8072663: Remove the sun.security.acl package which is not used in the JDK

On 17/02/2015 20:59, Jason Uh wrote: Please review this fix, which removes the sun.security.acl package. webrev: http://cr.openjdk.java.net/~juh/8072663/00/ jbs: http://bugs.openjdk.java.net/browse/JDK-8072663 The sun.security.acl package is the default implementation of java.security.acl but

Re: RFR: JDK-8074096 Disable (most) native warnings in JDK on a per-library basis

On 04/03/2015 13:17, Magnus Ihse Bursie wrote: : I intend to file individual bugs to handle these remaining warnings, so the net result will be a completely warning free build. I also intend to file individual bugs on all the libraries that has had warnings disabled. I expect the outcome of

Re: RFR: JDK-8074096 Disable (most) native warnings in JDK on a per-library basis

On 04/03/2015 15:03, Magnus Ihse Bursie wrote: I believe all warnings are important to check! Unfortunately, this has not been done for a lot of warnings for a lot of time. :( Right, although in the past we had some areas close to be cleared of warnings, it's just that we didn't keep up the effo

Re: Review Request: 8074428, 8074429, 8074430 jdk.pack200, jdk.jartool, jdk.policytool modules

On 05/03/2015 02:55, Wang Weijun wrote: - Move keytool to jdk.security.util, it's now in java.base but keytool is not part of Java SE spec (Of course, if that means keytool will be in JDK instead of JRE please stop. But will there will the name difference anymore? I am thinking of an installer

Re: Review Request: 8074428, 8074429, 8074430 jdk.pack200, jdk.jartool, jdk.policytool modules

On 05/03/2015 01:13, Mandy Chung wrote: : Separate webrevs for each issue: 1. pack200, unpack200 to jdk.pack200 http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8074428%2b8074429%2b8074430/8074428/webrev.00/ I think this looks okay. In the unshuffle_list (for back/forward porting patches) the

Re: Review Request: 8074428, 8074429, 8074430 jdk.pack200, jdk.jartool, jdk.policytool modules

On 05/03/2015 01:13, Mandy Chung wrote: 3. policytool to jdk.policytool http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8074428%2b8074429%2b8074430/8074430/webrev.00/ This part looks good to me. -Alan

Re: Review Request: 8074428, 8074429, 8074430 jdk.pack200, jdk.jartool, jdk.policytool modules

On 05/03/2015 01:13, Mandy Chung wrote: : 2. jar, jarsigner to jdk.jartool http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8074428%2b8074429%2b8074430/8074429/webrev.00/ It seems reasonable to have both jar and jarsigner in the same module so I think this is good. This will also work if Ma

Re: RFR 8047789: auth.login.LoginContext needs to be updated to work with modules

On 20/03/2015 14:39, Wang Weijun wrote: Please review the code changes at http://cr.openjdk.java.net/~weijun/8047789/webrev.03/ LoginContext is updated to use ServiceLoader to load configured LoginModules, and fallback to reflection if it cannot find one. Please notice that the fix does n

Re: RFR 8047789: auth.login.LoginContext needs to be updated to work with modules

On 20/03/2015 14:39, Wang Weijun wrote: Please review the code changes at http://cr.openjdk.java.net/~weijun/8047789/webrev.03/ : Compatibility issue: Before this code change, any class that includes the necessary methods (initialize, login, logout, abort, commit) can be configured as a

Re: Lambda in security manager initialization fail

On 30/03/2015 21:01, Peter Levart wrote: : I think that java.lang.invoke infrastructure initialization should not need to have access to system class loader. All types it deals with are loadable by bootstrap class loader. I too have already encountered a problem because of that and my suggest

Re: JDK 9 RFR of JDK-8078334: Mark regression tests using randomness

On 24/04/2015 02:54, Joseph D. Darcy wrote: Hello, Any additional comments on marking with tests in question with a "randomness" keyword? Thanks, -Joe I don't object to this keyword although I should say that most of the (apparent) randomness that I've seen hasn't been because of tests usi

Re: JDK 9 RFR of JDK-8078334: Mark regression tests using randomness

On 29/04/2015 00:53, Joseph D. Darcy wrote: Hello, I'd like to get this changeset, or something close to it, pushed soon so we can start taking advantage of better failure triaging. Any further concerns? I should have been clearer, I don't have any issues with the proposed patch. I was mos

Re: RFR: JDK-8075706 : Policy implementation does not allow policy.provider to be on the class path

On 01/05/2015 13:48, Sean Mullan wrote: Please review this change to use the system class loader to locate a policy provider specified with the policy.provider security property. The current implementation tries to load the provider using the extension class loader. This will no longer work whe

Re: RFR: JDK-8075706 : Policy implementation does not allow policy.provider to be on the class path

On 05/05/2015 22:37, Sean Mullan wrote: I was trying to avoid too many changes, but in the end I decided it was better to refactor some of this code into a new method. So here is the new webrev: http://cr.openjdk.java.net/~mullan/webrevs/8075706/webrev.02/ Changes include: - bootstrappin

Re: RFR 7191662: JCE providers should be located via ServiceLoader,

On 22/05/2015 13:55, Chris Hegarty wrote: : I think it could be done either way. Valerie - have you considered not pushing the services configuration files with this change? With the change then the java.security configuration is still class names, not provider names, so the fallback should

Re: RFR 7191662: JCE providers should be located via ServiceLoader,

On 25/05/2015 09:53, Chris Hegarty wrote: If it is agreed that these files are needed, then I can look at expanding the ImageBuilder to do concatenate them. I agree with Mandy's point that java.security should be change to list the provider name rather than the class name. If that happens then

Re: RFR 7191662: JCE providers should be located via ServiceLoader

On 27/05/2015 23:42, Mandy Chung wrote: Valerie, Did you see my comment yesterday? http://mail.openjdk.java.net/pipermail/security-dev/2015-May/012254.html Since you have reverted the java.security to keep the classname, to avoid causing merge conflict to jimage refresh, let’s remove the M

Re: RFR: 8087283 : Add support for the XML Signature here() function to the JDK XPath implementation

On 12/06/2015 18:29, Sean Mullan wrote: Please review this change to add support for the XML Signature here() function to the JDK XPath implementation. The here function is not defined in its own namespace. Therefore it needs to be implemented by extending the function library of XPath in the s

Re: RFR 7191662: JCE providers should be located via ServiceLoader

On 16/06/2015 00:58, Valerie Peng wrote: It seems that the jimage refresh change may still take some time, so we will end up removing the makefile related changes and then deferring the ServiceLoader related changes to Jake workspace. Here is the latest webrev (Security source/test changes o

Re: [9] Review request: JDK-8129595: New DTLS tests need @modules

On 24/06/2015 11:29, Konstantin Shefov wrote: Alan, Do the tests form "test/javax/net/ssl/DTLS" compile against jake? They have just the same dependencies as "test/javax/net/ssl/TLS" and the TEST.properties file just like one suggested in this fix. If yes, it is not worth changing TEST.prop

Re: [9] Review request: JDK-8129595: New DTLS tests need @modules

On 24/06/2015 16:40, Konstantin Shefov wrote: Hi Alan, Please review updated patch. I made it using the tool Alexander Kulyakhtin has given me. http://cr.openjdk.java.net/~kshefov/8129595/webrev.01/ This looks okay to me. Thanks for sorting this out. -Alan

Re: [9] RFR(M): 8076112: Add @HotSpotIntrinsicCandidate annotation to indicate methods for which Java Runtime has intrinsics

On 25/06/2015 12:49, Zoltán Majó wrote: Hi, please review the patch for JDK-8076112. Bug: https://bugs.openjdk.java.net/browse/JDK-8076112 Problem: There is need to indicate Java methods that are potentially intrinsified by JVM. Solution: Mark intrinsified methods with the jdk.internal.Ho

Re: [9] RFR(M): 8076112: Add @HotSpotIntrinsicCandidate annotation to indicate methods for which Java Runtime has intrinsics

On 26/06/2015 16:43, Zoltán Majó wrote: I updated the indentation as well. Here is the updated webrev: - top: http://cr.openjdk.java.net/~zmajo/8076112/top/webrev.06/ - jdk: http://cr.openjdk.java.net/~zmajo/8076112/jdk/webrev.06/ - hotspot: http://cr.openjdk.java.net/~zmajo/8076112/hotspot/w

Re: RFR 8058849: test/sun/security/krb5/config/dns.sh needs to re-examined or replaced

On 29/06/2015 08:55, Weijun Wang wrote: Please review the fix at http://cr.openjdk.java.net/~weijun/8058849/webrev.00 The overridden NamingManager needs to return a Context object whose getAttributes() method returns hard coded data. Since Context includes a lot of interface methods, choos

Re: RFR 8130112: Create a common TEST.properties for @modules in test/sun/security/krb5/auto

On 02/07/2015 08:46, Weijun Wang wrote: Hi All Please take a look at http://cr.openjdk.java.net/~weijun/8130112/webrev.00/ You only need to read the jdk.patch file. Basically I just remove the @modules tags in each test and combine them into a single TEST.properties. Two other small cha

hg: jdk7/tl/jdk: 2 new changesets

Changeset: 174916d435c9 Author:alanb Date: 2010-09-03 13:11 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/174916d435c9 6965072: Need API to create SDP sockets Reviewed-by: michaelm ! make/com/Makefile + make/com/oracle/Makefile + make/com/oracle/net/Makefile ! make/docs/NON

hg: jdk7/tl/jdk: 6971706: sun/nio/cs/ext/* classes are duplicated between rt.jar, charsets.jar, and localedata.jar

Changeset: cecc431cd78a Author:alanb Date: 2010-09-07 08:36 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/cecc431cd78a 6971706: sun/nio/cs/ext/* classes are duplicated between rt.jar, charsets.jar, and localedata.jar Reviewed-by: ohair ! make/common/Release.gmk

hg: jdk7/tl/jdk: 3 new changesets

Changeset: 55eb9f25bf7a Author:alanb Date: 2010-09-10 16:36 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/55eb9f25bf7a 6881498: (file) Re-examine DirectoryStream exception handling Reviewed-by: forax ! make/java/nio/FILES_java.gmk + src/share/classes/java/nio/file/Directory

hg: jdk7/tl/jdk: 6984545: (fc) transferFrom does not throw NonReadableChannelException when target is size 0 and non-readable

Changeset: a248eb631aa2 Author:alanb Date: 2010-09-15 15:13 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/a248eb631aa2 6984545: (fc) transferFrom does not throw NonReadableChannelException when target is size 0 and non-readable Reviewed-by: forax ! src/share/classes/sun/ni

hg: jdk7/tl/jdk: 2 new changesets

Changeset: 04d9b09dbef9 Author:alanb Date: 2010-09-30 14:48 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/04d9b09dbef9 6988037: fileClose prints debug message is close fails Reviewed-by: kevinw, forax ! src/solaris/native/java/io/io_util_md.c ! src/windows/native/java/io/io

hg: jdk7/tl/jdk: 2 new changesets

Changeset: f439d8b1e84a Author:alanb Date: 2010-10-02 12:59 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/f439d8b1e84a 6979526: (file) java/nio/file/FileStore/Basic.java fails if the same file system is mounted more than once Reviewed-by: kevinw, forax ! src/solaris/classe

hg: jdk7/tl/langtools: 6907737: (file) FileVisitor and Files.walkFileTree issues

Changeset: 232919708730 Author:alanb Date: 2010-10-03 19:40 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/232919708730 6907737: (file) FileVisitor and Files.walkFileTree issues Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/nio/JavacPathFileManager.java

hg: jdk7/tl/jdk: 6989190: SO_SNDBUF/SO_RCVBUF limits should only be checked when setsockopt fails (sol)

Changeset: b8af3bab5dbf Author:alanb Date: 2010-10-04 14:17 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/b8af3bab5dbf 6989190: SO_SNDBUF/SO_RCVBUF limits should only be checked when setsockopt fails (sol) Reviewed-by: chegar, michaelm ! src/solaris/native/java/net/net_uti

hg: jdk7/tl/jdk: 6907737: (file) FileVisitor and Files.walkFileTree issues

Changeset: 81b0c1e3d5a7 Author:alanb Date: 2010-10-03 19:39 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/81b0c1e3d5a7 6907737: (file) FileVisitor and Files.walkFileTree issues Reviewed-by: sherman + src/share/classes/java/nio/file/FileSystemLoopException.java ! src/share/c

hg: jdk7/tl/jdk: 6987116: (so) test/java/nio/channels/SocketChannel/VectorIO.java failed on Solaris 11

Changeset: b468b20a98a8 Author:alanb Date: 2010-10-05 15:07 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/b468b20a98a8 6987116: (so) test/java/nio/channels/SocketChannel/VectorIO.java failed on Solaris 11 Reviewed-by: forax ! test/java/nio/channels/SocketChannel/VectorIO.j

hg: jdk7/tl/jdk: 6989903: (process) test/java/lang/ProcessBuilder/Basic.java failing with "Bad file number" (sol)

Changeset: a2b1ef1294c5 Author:alanb Date: 2010-10-07 10:35 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/a2b1ef1294c5 6989903: (process) test/java/lang/ProcessBuilder/Basic.java failing with "Bad file number" (sol) Reviewed-by: ohair, chegar ! test/java/lang/ProcessBuilde

hg: jdk7/tl/jdk: 6989466: Miscellaneous compiler warnings in java/lang, java/util, java/io, sun/misc native code

Changeset: 871cffb21423 Author:alanb Date: 2010-10-07 14:36 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/871cffb21423 6989466: Miscellaneous compiler warnings in java/lang, java/util, java/io, sun/misc native code Reviewed-by: andrew, mchung, ohair ! src/share/native/comm

hg: jdk7/tl/jdk: 2 new changesets

Changeset: fd20568bebff Author:alanb Date: 2010-10-08 10:36 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/fd20568bebff 6989116: (verifier) compiler warning messages Reviewed-by: kamg, ohair ! src/share/native/common/check_code.c Changeset: d122e96be7d2 Author:alanb Dat

hg: jdk7/tl/jdk: 6987154: HTML link to serialization guide is broken

Changeset: f0888585b6ff Author:alanb Date: 2010-10-11 09:17 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/f0888585b6ff 6987154: HTML link to serialization guide is broken Reviewed-by: skannan ! src/share/classes/java/io/package.html

hg: jdk7/tl/jdk: 6728842: File.setReadOnly does not make a directory read-only (win); ...

Changeset: b614af87d00f Author:alanb Date: 2010-10-12 08:49 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/b614af87d00f 6728842: File.setReadOnly does not make a directory read-only (win) 6464744: java/io/File/SetAccess.java ignores sticky bit Reviewed-by: forax ! src/window

hg: jdk7/tl/jdk: 6983520: java/io/pathNames/GeneralWin32.java fails with jdk7-b108 (win)

Changeset: 1d94b33a8f59 Author:alanb Date: 2010-10-12 09:46 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/1d94b33a8f59 6983520: java/io/pathNames/GeneralWin32.java fails with jdk7-b108 (win) Reviewed-by: sherman ! src/windows/native/java/io/WinNTFileSystem_md.c ! src/window

hg: jdk7/tl/jdk: 6976036: Dual-pivot quicksort update (10/2010 tune-up)

Changeset: 4cf17a89ead9 Author:alanb Date: 2010-10-15 12:10 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/4cf17a89ead9 6976036: Dual-pivot quicksort update (10/2010 tune-up) Reviewed-by: alanb Contributed-by: vladimir.yaroslavs...@oracle.com ! src/share/classes/java/util/Ar

hg: jdk7/tl/jdk: 6743526: (bf) -XX:MaxDirectMemorySize= limits memory usage rather than total capacity as intended

Changeset: f24699d8c892 Author:alanb Date: 2010-10-15 15:09 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/f24699d8c892 6743526: (bf) -XX:MaxDirectMemorySize= limits memory usage rather than total capacity as intended Reviewed-by: chegar ! src/share/classes/java/nio/Bits.ja

hg: jdk7/tl/jdk: 2 new changesets

Changeset: b79600ecf0e4 Author:alanb Date: 2010-10-18 10:29 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/b79600ecf0e4 4837564: (bf) Please make DirectByteBuffer performance enhancements Reviewed-by: chegar ! src/share/classes/java/nio/Direct-X-Buffer.java.template ! src/sh

hg: jdk7/tl/jdk: 6993267: TEST_BUG: java/nio/file/Path/InterruptCopy.java fails intermittently (win)

Changeset: d9057727e2fa Author:alanb Date: 2010-10-21 14:39 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/d9057727e2fa 6993267: TEST_BUG: java/nio/file/Path/InterruptCopy.java fails intermittently (win) Reviewed-by: forax ! test/java/nio/file/Path/InterruptCopy.java

hg: jdk7/tl/jdk: 6816049: (bf) MappedByteBuffer.force() method does not flush data correctly

Changeset: 3740c2da7cc5 Author:alanb Date: 2010-10-22 17:40 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/3740c2da7cc5 6816049: (bf) MappedByteBuffer.force() method does not flush data correctly Reviewed-by: chegar ! src/share/classes/java/nio/Direct-X-Buffer.java.template

hg: jdk7/tl/jdk: 3 new changesets

Changeset: 5a6c63deacf3 Author:alanb Date: 2010-11-02 10:05 + URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/5a6c63deacf3 6993126: (aio) remove AsynchronousDatagramChannel Reviewed-by: chegar ! make/java/nio/FILES_java.gmk - src/share/classes/java/nio/channels/AsynchronousData

hg: jdk7/tl/corba: 6996740: Yet more breakage caused by 6891766

Changeset: 76aeef3afc04 Author:alanb Date: 2010-11-02 18:27 + URL: http://hg.openjdk.java.net/jdk7/tl/corba/rev/76aeef3afc04 6996740: Yet more breakage caused by 6891766 Summary: Restore com.sun.corba.se.simpl.io.IIOPInputStream that 6891766 nuked in error Reviewed-by: asaha !

hg: jdk7/tl/jdk: 2 new changesets

Changeset: c164d0d59465 Author:alanb Date: 2010-11-09 18:56 + URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/c164d0d59465 6979009: (fc) FileChannel.read() fails to throw ClosedByInterruptException Reviewed-by: forax, sherman, chegar ! src/share/classes/java/lang/Thread.java !

hg: jdk7/tl/jdk: 6999915: TEST_BUG: test/java/nio/channels/AsynchronousSocketChannel/Leaky.java failed intermittently (win)

Changeset: f88048284eb6 Author:alanb Date: 2010-11-15 14:34 + URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/f88048284eb6 615: TEST_BUG: test/java/nio/channels/AsynchronousSocketChannel/Leaky.java failed intermittently (win) Reviewed-by: forax ! test/java/nio/channels/Asy

hg: jdk7/tl/jdk: 6613829: (docs) Readable.read() ReadOnlyBufferException is not linked

Changeset: 9ec7802cc759 Author:alanb Date: 2010-11-16 15:23 + URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/9ec7802cc759 6613829: (docs) Readable.read() ReadOnlyBufferException is not linked Reviewed-by: chegar, lancea ! src/share/classes/java/lang/Readable.java

hg: jdk7/tl/jdk: 2 new changesets

Changeset: 2e0204644cf4 Author:alanb Date: 2010-11-18 19:16 + URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/2e0204644cf4 7000913: (bf) CharBuffer.wrap, slice, position, slice leads to CharBuffer with incorrect offser Reviewed-by: forax ! src/share/classes/java/nio/StringChar

hg: jdk7/tl/jdk: 6878369: (ch) AsynchronousSocketChannel read/write methods that specify timeouts should not throw IAE

Changeset: 4d9e09600175 Author:alanb Date: 2010-11-24 09:51 + URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/4d9e09600175 6878369: (ch) AsynchronousSocketChannel read/write methods that specify timeouts should not throw IAE Reviewed-by: forax ! src/share/classes/java/nio/chan

hg: jdk7/tl/jdk: 2 new changesets

Changeset: 374cc848d797 Author:alanb Date: 2010-12-01 13:49 + URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/374cc848d797 6709457: (fc) lock/tryLock() throws IOException "Access is denied" when file opened for append [win] Reviewed-by: chegar ! src/share/classes/java/io/FileO

hg: jdk7/tl/jdk: 6927816: Demo crash in heaptracker with Non-Sun JDK due to possible violation of JNI spec

Changeset: 0ef137ae6f3b Author:alanb Date: 2010-12-15 09:15 + URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/0ef137ae6f3b 6927816: Demo crash in heaptracker with Non-Sun JDK due to possible violation of JNI spec Reviewed-by: ohair, alanb Contributed-by: spo...@uk.ibm.com ! sr

hg: jdk7/tl/jdk: 7010192: InetAddress.isReachable hits ShouldNotReachHere with hs20-b04 (win)

Changeset: 6f2d19ef67b1 Author:alanb Date: 2011-01-04 17:49 + URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/6f2d19ef67b1 7010192: InetAddress.isReachable hits ShouldNotReachHere with hs20-b04 (win) Reviewed-by: chegar ! src/windows/native/java/net/Inet4AddressImpl.c ! src/win

hg: jdk7/tl/jdk: 2 new changesets

Changeset: 5124c2a50539 Author:alanb Date: 2011-01-07 15:49 + URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/5124c2a50539 6993732: Remove the HPI Reviewed-by: ohair, lancea, chegar, mduigou, mchung, mr ! make/common/Defs-linux.gmk ! make/common/Defs-solaris.gmk ! make/common/D

hg: jdk7/tl/jdk: 7002957: (fc) FileChannel.transferTo fails to load libsendfile on Solaris 64-bit

Changeset: ee5bf287d0c4 Author:alanb Date: 2011-01-10 09:32 + URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/ee5bf287d0c4 7002957: (fc) FileChannel.transferTo fails to load libsendfile on Solaris 64-bit Reviewed-by: chegar ! make/java/nio/Makefile ! src/solaris/native/sun/nio/

Re: code review request for CR 6989705: ECC security code native code compiler warnings

Vincent Ryan wrote: Hello Alan, Please review the following webrev which removes 100's of nuisance compiler warnings generated by our ECC code: http://rialto.ireland.sun.com/~vinnie/webrevs/jdk7/6989705/webrev/ Getting rid of the #pragmas and the other changes look okay to me. The only co

hg: jdk7/tl/jdk: 7012663: javadoc warning in javax.swing.JComponent and javax.swing.plaf.synth.SynthTextPaneUI

Changeset: bf1b937076db Author:alanb Date: 2011-01-26 18:01 + URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/bf1b937076db 7012663: javadoc warning in javax.swing.JComponent and javax.swing.plaf.synth.SynthTextPaneUI Reviewed-by: alexp ! src/share/classes/javax/swing/JComponen

hg: jdk7/tl/jdk: 2 new changesets

Changeset: 236e3f2d0a6b Author:alanb Date: 2011-01-28 09:28 + URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/236e3f2d0a6b 7006126: (fs) Updates to file system API (1/2011) Reviewed-by: chegar, sherman ! make/java/java/FILES_java.gmk ! make/java/nio/FILES_java.gmk ! make/mkdemo

hg: jdk7/tl/langtools: 2 new changesets

Changeset: babf86a1ac92 Author:alanb Date: 2011-01-28 09:25 + URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/babf86a1ac92 7006126: (fs) Updates to file system API (1/2011) Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/nio/JavacPathFileManager.java ! src/share/

hg: jdk7/tl/jdk: 7015410: test/java/net/Socks/SocksProxyVersion.java needs to be updated due to 7013420

Changeset: dea360853f8b Author:alanb Date: 2011-01-28 13:26 + URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/dea360853f8b 7015410: test/java/net/Socks/SocksProxyVersion.java needs to be updated due to 7013420 Reviewed-by: chegar ! test/java/net/Socks/SocksProxyVersion.java

hg: jdk7/tl/jdk: 7014794: (file) lookupPrincipalByGroupName fails to find large NIS groups

Changeset: e2a182adb30f Author:alanb Date: 2011-02-03 13:37 + URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/e2a182adb30f 7014794: (file) lookupPrincipalByGroupName fails to find large NIS groups Reviewed-by: chegar ! src/solaris/native/sun/nio/fs/UnixNativeDispatcher.c

hg: jdk7/tl/jdk: 2 new changesets

Changeset: f34dcfeecc8d Author:alanb Date: 2011-02-07 13:53 + URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/f34dcfeecc8d 7012823: TEST_BUG: java/nio/MappedByteBuffer tests leave file mappingsthat prevent clean-up (win) Reviewed-by: forax ! test/java/nio/MappedByteBuffer/Forc

hg: jdk7/tl/jdk: 2 new changesets

Changeset: f9f321a7502c Author:alanb Date: 2011-02-07 18:01 + URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/f9f321a7502c 7017454: Residual warnings in sun/nio/** and java/io native code (win64) Reviewed-by: chegar ! src/share/native/java/io/io_util.c ! src/windows/native/java

hg: jdk7/tl/jdk: 7013585: Dual-pivot quicksort improvements for highly structured (nearly sorted) and data with small periods

Changeset: 947ce00ed7a2 Author:alanb Date: 2011-02-08 15:50 + URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/947ce00ed7a2 7013585: Dual-pivot quicksort improvements for highly structured (nearly sorted) and data with small periods Reviewed-by: mduigou, alanb Contributed-by: vl

hg: jdk7/tl/jdk: 4421494: infinite loop while parsing double literal

Changeset: 82c8c54ac1d5 Author:alanb Date: 2011-02-08 19:31 + URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/82c8c54ac1d5 4421494: infinite loop while parsing double literal Reviewed-by: darcy, alanb Contributed-by: dmitry.nadez...@oracle.com ! src/share/classes/sun/misc/Float

hg: jdk7/tl/jdk: 2 new changesets

Changeset: 6a274c4d3e00 Author:alanb Date: 2011-02-09 15:59 + URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/6a274c4d3e00 7018258: Dual-pivot updates in 7013585 can fail with ArrayIndexOutOfBoundsException Reviewed-by: alanb Contributed-by: vladimir.yaroslavs...@oracle.com !

hg: jdk7/tl/jdk: 7016704: TEST_BUG: java/nio/file/Files/walk_file_tree.sh fails with new version of find (lnx)

Changeset: fefc740bff52 Author:alanb Date: 2011-02-14 18:30 + URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/fefc740bff52 7016704: TEST_BUG: java/nio/file/Files/walk_file_tree.sh fails with new version of find (lnx) Reviewed-by: forax ! test/java/nio/file/Files/walkFileTree/P

hg: jdk7/tl/jdk: 2 new changesets

Changeset: 302877469037 Author:alanb Date: 2011-02-17 20:50 + URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/302877469037 6526860: (fc) FileChannel.position returns 0 when FileOutputStream opened in append mode Reviewed-by: forax ! src/share/classes/sun/nio/ch/FileChannelImpl

hg: jdk7/tl/jdk: 3 new changesets

Changeset: dbdafe65af60 Author:alanb Date: 2011-02-21 13:54 + URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/dbdafe65af60 7020517: (fs) FileStore.equals returns true if both volumes have the same serial number Reviewed-by: chegar ! src/windows/classes/sun/nio/fs/WindowsFileSt

hg: jdk7/tl/jdk: 7021327: Changes for 7020888 included changes to other files in error

Changeset: bac152c6491a Author:alanb Date: 2011-02-22 14:28 + URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/bac152c6491a 7021327: Changes for 7020888 included changes to other files in error Reviewed-by: chegar ! src/share/classes/java/io/BufferedReader.java ! src/share/class

Re: Review request for 7020513 : Add com.sun.xml.internal to the "package.access" property in java.security

Rama Pulavarthi wrote: : Just porting the fix along with tests from Open JDK 6 workspace, that's why I kept the old date. Does it need to be changed? This test was added then following the convention of other tests. I will check other tests in JDK 7 to see if it needs any update. Sorry Rama

Re: Review request for 7020513 : Add com.sun.xml.internal to the "package.access" property in java.security

Rama Pulavarthi wrote: Please review this updated webrev that has the patch for JDK 7 repo. http://cr.openjdk.java.net/~ohair/openjdk7/jdk7-tl-jaxws-7020513-open/webrev/ Looks good to me too. -Alan.

<    1   2   3   4   5   6   7   8   9   10   >