Re: RFR 8215643: Microbenchmarks for KeyAgreement and Cipher

Hi Adam, The iteration control annotations you are inheriting from the CryptoBase don't seem too good for the couple of your new micros I had time to try, it is too short for warmup so there is a lot of run to run variation and it will be a pain if we later run them in the weeklies. Otherwise

Re: [14] RFR JDK-8229214 "Don't use GCM with PKCS5Padding in test/micro/org/openjdk/bench/javax/crypto/"

Thanks for fixing this, looks good. Eric On 8/6/19 10:34 PM, Valerie Peng wrote: Anyone can help review this trivial test update? Bug: https://bugs.openjdk.java.net/browse/JDK-8229214 Webrev: http://cr.openjdk.java.net/~valeriep/8229214/webrev.00/ Thanks, Valerie

RFR (S) 8215521: add microbenchmark to measure AccessController.getContext

Hi everybody, Could I get some reviews for JDK-8215521 to add a new JMH for AccessController.getContext() -- this was written by Dean after a bug from almost a year ago, then we forgot about it. I made the stack depth into a parameter. JBS: https://bugs.openjdk.java.net/browse/JDK-8215521 W

Re: RFR (S) 8215521: add microbenchmark to measure AccessController.getContext

Oh thanks, I will fix it before pushing, Eric On 10/3/19 5:51 PM, Claes Redestad wrote: Hi Eric, benchmarks looks good to me! Nit: javadoc says "Benchmark measuring DoPrivileged", which doesn't look right. /Claes On 2019-10-03 23:27, eric.casp...@oracle.com wrote: Hi everybody, Could I get

Re: RFR (S) 8215521: add microbenchmark to measure AccessController.getContext

Hi Alan, Here it is: http://cr.openjdk.java.net/~ecaspole/JDK-8215521/02/webrev/ thanks, Eric On 10/4/19 02:21, Alan Bateman wrote: On 03/10/2019 22:27, eric.casp...@oracle.com wrote: : http://cr.openjdk.java.net/~ecaspole/JDK-8215521/01/webrev/ The cast is bit ugly. In other cases, we

RFR (XS): 8238189 Cleanups to AES crypto micros

Hi everyone, Get I get reviews on this small change to the AESBench crypto micro, which puts all the algorithms into the small set for convenience of testing compiler intrinsics etc. JBS: https://bugs.openjdk.java.net/browse/JDK-8238189 Webrev: http://cr.openjdk.java.net/~ecaspole/JDK-8238189

Re: [RFR] 8241680: KeyPairGen & Signature microbenchmarks need updating for disabled EC curves

Looks fine to me. Eric On 6/8/20 2:15 PM, Anthony Scarpino wrote: Hi, I need a quick code review of updates to the microbenchmarks tests for EC.  These tests used curves that are now disabled by default in 15. https://cr.openjdk.java.net/~ascarpino/8241680/webrev/ thanks Tony

Re: RFR: 8286401: Address possibly lossy conversions in Microbenchmarks [v2]

On Wed, 11 May 2022 15:50:40 GMT, Claes Redestad wrote: >> #8599 would add a new warning. This address the conversions in the >> microbenchmark component by means of making the types precise or adding >> explicit casts. There's quite a few changes in the ByteBuffers benchmarks, >> but the real

Re: RFR: 8286401: Address possibly lossy conversions in Microbenchmarks [v2]

On Wed, 11 May 2022 15:50:40 GMT, Claes Redestad wrote: >> #8599 would add a new warning. This address the conversions in the >> microbenchmark component by means of making the types precise or adding >> explicit casts. There's quite a few changes in the ByteBuffers benchmarks, >> but the real

Re: RFR: 8269827: JMH tests for AES/GCM byte[] and bytebuffers [v2]

On Fri, 2 Jul 2021 23:30:17 GMT, Anthony Scarpino wrote: >> Hi, >> >> I need a review of these new jmh tests that run AES/GCM encryption and >> decryption using byte[], heap bytebuffers, and direct bytebuffers as input >> and output buffers for single and multi-part testing. >> >> thanks >>