Re: [Fwd: Code review request: 7072353 JNDI libraries do not build with javac -Xlint:all -Werror]

2011-08-04 Thread Neil Richards
On Wed, 2011-08-03 at 11:03 -0700, Alexandre Boulgakov wrote: > Please see my responses inline. > > Thanks! > -Sasha > > On 8/2/2011 9:13 PM, Xuelei Fan wrote: > > . com/sun/jndi/toolkit/dir/SearchFilter.java > > 451 for (NamingEnumeration ve = attr.getAll(); > > 452 ve.

hg: jdk8/tl/jdk: 2 new changesets

2011-10-11 Thread neil . richards
Changeset: dd55467dd1f2 Author:ngmr Date: 2011-10-10 14:50 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/dd55467dd1f2 7099119: Remove unused dlinfo local variable in launcher code Reviewed-by: ohair, chegar, ngmr Contributed-by: Steve Poole ! src/solaris/bin/java_md.c Cha

hg: jdk8/tl/jdk: 7100054: (porting) Native code should include fcntl.h and unistd.h rather than sys/fcntl.h and sys/unistd.h

2011-10-20 Thread neil . richards
Changeset: c3da0672a882 Author:ngmr Date: 2011-10-13 12:30 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c3da0672a882 7100054: (porting) Native code should include fcntl.h and unistd.h rather than sys/fcntl.h and sys/unistd.h Summary: Use POSIX defined includes for unistd.h

hg: jdk8/tl/jdk: 7112670: Inet4AddressImpl should use getaddrinfo/getnameinfo

2011-11-22 Thread neil . richards
Changeset: 81987765cb81 Author:ngmr Date: 2011-11-11 14:40 + URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/81987765cb81 7112670: Inet4AddressImpl should use getaddrinfo/getnameinfo Reviewed-by: chegar, alanb, mduigou, ngmr Contributed-by: Charles Lee ! src/solaris/native/jav

hg: jdk8/tl/jdk: 7114558: Inet4AddressImpl should use memset (rather than bzero) and NI_MAXHOST (rather than MAXHOSTNAMELEN)

2011-11-22 Thread neil . richards
Changeset: ee2fa62fb09f Author:ngmr Date: 2011-11-22 09:51 + URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ee2fa62fb09f 7114558: Inet4AddressImpl should use memset (rather than bzero) and NI_MAXHOST (rather than MAXHOSTNAMELEN) Reviewed-by: chegar Contributed-by: Neil

hg: jdk8/tl/jdk: 7115070: (fs) lookupPrincipalByName/lookupPrincipalByGroupName should treat ESRCH as not found

2011-11-28 Thread neil . richards
Changeset: 955aae8c1106 Author:ngmr Date: 2011-11-24 11:34 + URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/955aae8c1106 7115070: (fs) lookupPrincipalByName/lookupPrincipalByGroupName should treat ESRCH as not found Reviewed-by: alanb Contributed-by: Jonathan Lu ! src/solari

hg: jdk8/tl/jdk: 7094995: Trailing daemon thread causes continuous GC in agentvm mode

2011-11-28 Thread neil . richards
, chegar, dholmes, darcy Contributed-by: Neil Richards ! test/java/util/zip/ZipFile/ClearStaleZipFileInputStreams.java

hg: jdk8/tl/jdk: 7118907: InetAddress.isReachable() should return false if sendto fails with EHOSTUNREACH

2011-12-12 Thread neil . richards
Changeset: c508f38245f8 Author:ngmr Date: 2011-12-12 11:41 + URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c508f38245f8 7118907: InetAddress.isReachable() should return false if sendto fails with EHOSTUNREACH Reviewed-by: alanb, chegar Contributed-by: Charles Lee ! src/sola

hg: jdk8/tl/jdk: 7123229: (coll) EnumMap.containsValue(null) returns true

2012-01-31 Thread neil . richards
Contributed-by: Neil Richards ! src/share/classes/java/util/EnumMap.java + test/java/util/EnumMap/UniqueNullValue.java

hg: jdk8/tl/jdk: 7133301: (process) UNIXProcess_md.c should include sys/wait.h rather than wait.h

2012-01-31 Thread neil . richards
Changeset: 13978750cb87 Author:ngmr Date: 2012-01-31 10:31 + URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/13978750cb87 7133301: (process) UNIXProcess_md.c should include sys/wait.h rather than wait.h Reviewed-by: alanb Contributed-by: Jonathan Lu ! src/solaris/native/java/l

Code review request: 6733443: JCA/JCE init does not completely reset the delayed provider selection mechanism.

2012-07-23 Thread Neil Richards
Hi all, The PKCS11 documentation [1] describes how the selection of a security provider implementation is (re-)performed each time any initialization (init*) method is called on objects of the classes: * javax.crypto.Cipher * javax.crypto.KeyAgreement * javax.crypto.Mac * j

Re: Code review request: 6733443: JCA/JCE init does not completely reset the delayed provider selection mechanism.

2012-08-08 Thread Neil Richards
will take a look and let you know my thoughts > sometime next week. > > Valerie > > On 07/23/12 21:13, Neil Richards wrote: > > Hi all, > > > > The PKCS11 documentation [1] describes how the selection of a security > > provider implementation is (re-)

hg: jdk8/tl/jdk: 8000955: Hashtable.Entry.hashCode() does not conform to Map.Entry.hashCode() defined behaviour

2012-10-17 Thread neil . richards
Changeset: 5eed4a92ca8c Author:ngmr Date: 2012-10-17 13:35 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5eed4a92ca8c 8000955: Hashtable.Entry.hashCode() does not conform to Map.Entry.hashCode() defined behaviour Reviewed-by: mduigou, alanb ! src/share/classes/java/util/Ha

RFR: Re-enable support for non-Principal implementations of PrincipalComparator

2013-02-21 Thread Neil Richards
Hi, The change made for the RFE 7019834 [1] [2] [3] is built upon the assertion that: "All PrincipalComparator implementations should already implement Principal". However, the Javadoc for com.sun.security.auth.PrincipalComparator in the JAAS specification [4] states that:

Re: RFR: Re-enable support for non-Principal implementations of PrincipalComparator

2013-02-26 Thread Neil Richards
27;m asking around nearby to see if evidence of real use breakage can be found, and will tug on this thread again if/when I have something more to share on this. Regards, Neil On Thu, 2013-02-21 at 17:38 -0500, Sean Mullan wrote: > Hi, > > On 02/21/2013 07:13 AM, Neil Richards wrote: &