Code Review Request: 8028562

2013-12-03 Thread zaiyao liu
Hi Xuelei, I can't reproduce this issue after run 900 times at windows and linux platform, for this fix just run one more round after get exception. please review: http://sqeweb.us.oracle.com/net/sqenfs-1/export1/comp/jsn/users/kevin1/webrev/8028562/webrev/ Thanks Kevin

Re: Code Review Request: 8028562

2013-12-03 Thread zaiyao liu
Hi Xuelei, Can you help to review again. http://cr.openjdk.java.net/~ewang/kevin/JDK-8028562/webrev.00/ <http://cr.openjdk.java.net/%7Eewang/kevin/JDK-8028562/webrev.00/> Thanks Kevin On 2013/12/3 19:50, Xuelei Fan wrote: On 12/3/2013 6:59 PM, zaiyao liu wrote: Hi Xuelei, I

Re: Code Review Request: 8028562

2013-12-03 Thread zaiyao liu
Hi Xuelei, Thanks for you suggestion. please review again: http://cr.openjdk.java.net/~ewang/kevin/JDK-8028562/webrev.00/ <http://cr.openjdk.java.net/%7Eewang/kevin/JDK-8028562/webrev.00/> Kevin On 2013/12/4 12:06, Xuelei Fan wrote: On 12/4/2013 11:33 AM, zaiyao liu wrote: Hi Xuelei

Re: Code Review Request: 8028562

2013-12-03 Thread zaiyao liu
Hi Xuelei, I have updated, please review:http://cr.openjdk.java.net/~ewang/kevin/JDK-8028562/webrev.00/ <http://cr.openjdk.java.net/%7Eewang/kevin/JDK-8028562/webrev.00/> Thanks Kevin On 2013/12/4 14:50, Xuelei Fan wrote: On 12/4/2013 2:36 PM, zaiyao liu wrote: Hi Xuelei, Thanks f

Re: Code Review Request: 8028562

2013-12-04 Thread zaiyao liu
Hi Xuelei, Can you help to submit this change to repository? I don't have openjdk account. Thanks Kevin On 2013/12/4 15:41, Xuelei Fan wrote: Looks fine to me. Xuelei On 12/4/2013 3:24 PM, zaiyao liu wrote: Hi Xuelei, I have updated, please review:http://cr.openjdk.java.net/~ewang/

Re: Code Review Request: 8028562

2013-12-05 Thread zaiyao liu
one more roud when read error I suggest rewording this to: // will try to read one more time if there is a read error Also, it is too late to push this for JDK 8 as it is not critical, so you will have to wait until the JDK 9 repo opens ... Thanks, Sean On 12/04/2013 07:45 PM, zaiyao liu wrote:

Re: Code Review Request: 8028562

2013-12-15 Thread zaiyao liu
Just record this email in security-dev alias. On 2013/12/6 18:23, Xuelei Fan wrote: On 12/6/2013 6:04 PM, Xuelei Fan wrote: On 12/6/2013 5:11 PM, zaiyao liu wrote: Hi Xuelei, Can you help me to post the webrev into cr.openjdk.java.net if you think fine, I don't have account, I asked Er

Re: Code Review Request: 8028562

2013-12-15 Thread zaiyao liu
Hi Andrew and Sean, Please help to review,this webrev based on JDK9: http://cr.openjdk.java.net/~pzhang/Kevin/8028562/webrev/ Thanks and Regards. Kevin On 2013/12/16 9:40, zaiyao liu wrote: Just record this email in security-dev alias. On 2013/12/6 18:23, Xuelei Fan wrote: On 12/6/2013 6

Fwd: SQE test CertPath/CertPathBuilderTest failed for java.lang.IndexOutOfBoundsException: Index: 0, Size: 0

2013-12-20 Thread zaiyao liu
Message Subject: SQE test CertPath/CertPathBuilderTest failed for java.lang.IndexOutOfBoundsException: Index: 0, Size: 0 Date: Fri, 20 Dec 2013 12:11:21 +0800 From: zaiyao liu Organization: Oracle Corporation To: JASON.UH Hi Jason, There are some sqe test CertPath

Can you give some suggestion about how build a Hacked JDK for The Malformed Certificates tests

2014-03-19 Thread zaiyao liu
Hi team, I am developing The Malformed Certificates tests, this test exist to test JDK's SSL ability to withstand attack in the form of deliberately 1.3 million malformed ASN.1-encoded data. Detail please refer test plan: http://wiki.se.oracle.com/display/JPG/Malformed+Certificates+Test+Plan

Review request for CR 8044193 Need to add known answer tests for AES cipher

2014-07-28 Thread zaiyao liu
Hello, Please help to review the tests for AES cipher. This tests test AES ciphers with different modes and padding schemes when provider change,are part of tests for bug 8044193(Open part) Bug - https://bugs.openjdk.java.net/browse/JDK-8044193 webrev- http://cr.openjdk.java.net/~rhala

[JDK-9] RFR: 8050370: Need new regressions tests for messageDigest with DigestIOStream

2014-07-31 Thread zaiyao liu
May I request you to review 1 new test to be added for messageDigest with DigestIOStream. New test are added to address following: - Test DigestInputStream and DigestOutputStream digest function when digest set on and off - Test DigestInputStream and DigestOutputStream digest function when Swa

Re: [JDK-9] RFR: 8050370: Need new regressions tests for messageDigest with DigestIOStream

2014-08-17 Thread zaiyao liu
Hi Brad, Can you help to review this new test for DigestIOStream? Thanks Kevin ? 2014/8/1 11:10, zaiyao liu ??: May I request you to review 1 new test to be added for messageDigest with DigestIOStream. New test are added to address following: - Test DigestInputStream and DigestOutputStream

Re: [JDK-9] RFR: 8050370: Need new regressions tests for messageDigest with DigestIOStream

2014-08-19 Thread zaiyao liu
, at 14:35, zaiyao liu wrote: Hi Brad, Can you help to review this new test for DigestIOStream? Thanks Kevin 于 2014/8/1 11:10, zaiyao liu 写道: May I request you to review 1 new test to be added for messageDigest with DigestIOStream. New test are added to address following: - Test

Re: [JDK-9] RFR: 8050370: Need new regressions tests for messageDigest with DigestIOStream

2014-08-19 Thread zaiyao liu
Hi Max, Sorry for the confuse, how about following chang? 136 boolean enDigest = false; 139 while ((k = dis.read()) != -1) { 144 dos.write(k); 145 if (enDigest == false) { // write data into baOut when dos and dis

[JDK-9] RFR: 8048607: Implement key generation tests

2014-08-22 Thread zaiyao liu
May I request you to review 1 new test to be added forkey generation algorithms. New test are added to address following: - Generate a secret key using key generator for specified algorithm, retrieve its value, then verify the parity of that key. JDK Issue: https://bugs.openjdk.java.net/brows

Re: [JDK-9] RFR: 8050370: Need new regressions tests for messageDigest with DigestIOStream

2014-08-24 Thread zaiyao liu
Hi Max, Please help review the change: http://cr.openjdk.java.net/~tyan/kevin/JDK-8050370/webrev02/ Thanks Kevin 于 2014/8/20 10:35, zaiyao liu 写道: Hi Max, Sorry for the confuse, how about following chang? 136 boolean enDigest = false; 139 while ((k = dis.read

[JDK-9] RFR: JDK-8048617: Tests for PKCS12 read operations

2014-08-25 Thread zaiyao liu
Hi Xuelei, May I request you to review 1 new test to be added for PKCS12 read operations. New test are added to address following: - Implement tests for read operations with PKCS12 keystore. JDK Issue:***https://bugs.openjdk.java.net/browse/JDK-8048617* Webrev: http://cr.openjdk.java.net/~tyan

Re: [JDK-9] RFR: 8050370: Need new regressions tests for messageDigest with DigestIOStream

2014-08-25 Thread zaiyao liu
Hi Max, please review again: http://cr.openjdk.java.net/~tyan/kevin/JDK-8050370/webrev03/ Thanks Kevin 于 2014/8/25 14:55, Wang Weijun 写道: lines 76 and 80, useless " " at the end of string. Otherwise looks fine. Thanks Max On Aug 25, 2014, at 14:41, zaiyao liu wrote: Hi Max, P

Re: [JDK-9] RFR: JDK-8048617: Tests for PKCS12 read operations

2014-08-26 Thread zaiyao liu
each? That will save you a lot of @run lines. Or, is there an exception? Thanks Max On Aug 25, 2014, at 15:18, zaiyao liu wrote: Hi Xuelei, May I request you to review 1 new test to be added for PKCS12 read operations. New test are added to address following: - Implement tests for read

Re: [JDK-9] RFR: JDK-8048617: Tests for PKCS12 read operations

2014-08-26 Thread zaiyao liu
Hi Max, Can you help to push this code for me? Full comments: 8048617: Tests for PKCS12 read operations Reviewed-by: weijun Contributed-by: Zaiyao Liu Thanks Kevin 于 2014/8/27 11:18, Wang Weijun 写道: Change looks fine. Thanks Max On Aug 27, 2014, at 11:12, zaiyao liu wrote: Hi Max

Re: [JDK-9] RFR: JDK-8048617: Tests for PKCS12 read operations

2014-08-26 Thread zaiyao liu
Thanks 于 2014/8/27 11:37, Wang Weijun 写道: Done at http://hg.openjdk.java.net/jdk9/dev/jdk/rev/785858138c56. --Max On Aug 27, 2014, at 11:23, zaiyao liu wrote: Hi Max, Can you help to push this code for me? Full comments: 8048617: Tests for PKCS12 read operations Reviewed-by: weijun

RFR 8048621: Implement basic keystore tests

2014-08-27 Thread zaiyao liu
Hi All, Please review the code change,the purpose of this fix is implement basic tests for keystore types supported by JDK. Webrev: http://cr.openjdk.java.net/~tyan/kevin/JDK-8048621/webrev01/ Bug: https://bugs.openjdk.java.net/browse/JDK-8048621 Thanks Kevin

RFR 8048619: Implement tests for converting PKCS12 keystores

2014-08-31 Thread zaiyao liu
Hi Max, Please review the code change,the purpose of this fix is implement tests that convert PKCS12 keystores to other formats. Webrev: http://cr.openjdk.java.net/~tyan/kevin/JDK-8048619/webrev01/ Bug:https://bugs.openjdk.java.net/browse/JDK-8048619 Thanks Kevin

Re: RFR 8048621: Implement basic keystore tests

2014-09-01 Thread zaiyao liu
Hi Xuelei, Can you help to review those tests? Thanks Kevin 于 2014/8/28 9:45, zaiyao liu 写道: Hi All, Please review the code change,the purpose of this fix is implement basic tests for keystore types supported by JDK. Webrev: http://cr.openjdk.java.net/~tyan/kevin/JDK-8048621/webrev01/ Bug

Re: RFR 8048621: Implement basic keystore tests

2014-09-02 Thread zaiyao liu
which case PKCS11 keystore is disabled? Xuelei On 9/1/2014 3:14 PM, zaiyao liu wrote: Hi Xuelei, Can you help to review those tests? Thanks Kevin 于 2014/8/28 9:45, zaiyao liu 写道: Hi All, Please review the code change,the purpose of this fix is implement basic tests for keystore types

Re: RFR 8048621: Implement basic keystore tests

2014-09-02 Thread zaiyao liu
Hi Xuelei, Can you help to push this code for me? Full comments: 8048621: Implement basic keystore tests Reviewed-by: Xuelei Fan Contributed-by: Zaiyao Liu Thanks Kevin 于 2014/9/3 12:36, Xuelei Fan 写道: Looks fine to me. Thanks, Xuelei On 9/3/2014 10:57 AM, zaiyao liu wrote: Hi Xuelei

Re: [JDK-9] RFR: 8048607: Implement key generation tests

2014-09-08 Thread zaiyao liu
Hi Xuelei, Can you help to review this test? JDK Issue: https://bugs.openjdk.java.net/browse/JDK-8048607 Webrev: http://cr.openjdk.java.net/~tyan/kevin/JDK-8048607/webrev01/ Thanks Kevin ? 2014/8/22 16:05, zaiyao liu ??: May I request you to review 1 new test to be added forkey generation

RFR JDK-8049432: Need new tests for testing TLS property jdk.tls.client.protocols with various protocols and values

2014-09-09 Thread zaiyao liu
Hi All, Please review the code change,the purpose of this fix is to address following: -Sets the property jdk.tls.client.protocols to one of this protocols:SSLv3,TLSv1,TLSv1,TLSv1.1,TLSv1.2 and TLSV(invalid) or removes this property (if any),then validates the default, supported and current

Re: RFR 8048619: Implement tests for converting PKCS12 keystores

2014-09-18 Thread zaiyao liu
Hi Max, Can you help to review it? Thanks Kevin 于 2014/9/1 13:25, Wang Weijun 写道: On vacation now. Can you look for someone else? I will be back in Sep 17 if you are not in a hurry. --Max On Sep 1, 2014, at 9:37, zaiyao liu wrote: Hi Max, Please review the code change,the purpose of

Re: RFR 8048619: Implement tests for converting PKCS12 keystores

2014-12-02 Thread zaiyao liu
Hi Max, Please help to review the update: http://cr.openjdk.java.net/~rhalade/8048619/webrev.02/ Thanks Kevin 于 2014/9/23 15:08, zaiyao liu 写道: Hi Max, Please help to check this update:http://sqeweb.us.oracle.com/net/sqenfs-1/export1/comp/jsn/users/kevin1/webrev/8048619/webrev/ Thanks

Re: RFR JDK-8049432: Need new tests for testing TLS property jdk.tls.client.protocols with various protocols and values

2014-12-02 Thread zaiyao liu
Hi Xuelei, Can you help to review this code change? Thanks and Regards. Kevin 于 2014/9/10 10:29, zaiyao liu 写道: Hi All, Please review the code change,the purpose of this fix is to address following: -Sets the property jdk.tls.client.protocols to one of this protocols:SSLv3,TLSv1,TLSv1

Re: RFR 8048619: Implement tests for converting PKCS12 keystores

2014-12-04 Thread zaiyao liu
Hi Max, Please help to check again: http://cr.openjdk.java.net/~rhalade/8048619/webrev.04/ Also please help to push it if ok: Full comments: 8048619: Implement tests for converting PKCS12 keystores Reviewed-by: weijun Contributed-by: Zaiyao Liu Thanks and Regards. Kevin 于 2014/12/3 15:37

Re: RFR JDK-8049432: Need new tests for testing TLS property jdk.tls.client.protocols with various protocols and values

2014-12-07 Thread zaiyao liu
Hi Xuelei, Please check the update: http://cr.openjdk.java.net/~rhalade/8049432/webrev.02/ Please help to push it if OK. Full comments: 8049432: Need new tests for testing TLS property jdk.tls.client.protocols with various protocols and values Reviewed-by: xuelei Contributed-by: Zaiyao Liu

Re: Review request for CR 8044193 Need to add known answer tests for AES cipher

2014-12-21 Thread zaiyao liu
? Please refer to the current /lib/security/java.policy. Thanks, Valerie On 7/28/2014 9:36 PM, zaiyao liu wrote: Hello, Please help to review the tests for AES cipher. This tests test AES ciphers with different modes and padding schemes when provider change,are part of tests for bug 8044193

Re: [JDK-9] RFR: 8048607: Implement key generation tests

2015-01-06 Thread zaiyao liu
Hi Xuelei, Thanks for review, please check the update: http://cr.openjdk.java.net/~zailiu/8044193/webrev.03/ Please help to push it if OK. Full comments: 8048607: Implement key generation tests Reviewed-by: xuelei Contributed-by: Zaiyao Liu Thanks and Regards. Kevin 在 2015/1/7 8:38, Xuelei

Re: Review request for CR 8044193 Need to add known answer tests for AES cipher

2015-01-12 Thread zaiyao liu
On 1/6/2015 3:39 PM, Rajan Halade wrote: Subject: Re: Review request for CR 8044193 Need to add known answer tests for AES cipher Date: Mon, 22 Dec 2014 11:11:38 +0800 From: zaiyao liu Organization: Oracle Corporation To: security-dev@openjdk.java.net Hi Valeries, Thanks for revi

[JDK-9] RFR: 8050371: MessageDigest tests

2015-02-09 Thread zaiyao liu
Hi all, Please help to review those 2 new tests to be added for MessageDigest, New tests are added to address following: - Fixed length hash value is returned with different data inputs - Same hash value is returned with different update and digest methods JDK issue: https://bugs.openjdk.java

[JDK-9] RFR: 8048610 Implement regression tests for bug fixes in JCE

2015-02-15 Thread zaiyao liu
Hi all, Please help to review those 2 new tests to verify following 2 JDK bug fixes in JCE: - JDK-4686632: InvalidKeyException.getMessage() returns null - JDK-4901658: Can not produce a string from key's encoded byte[] consistently JDK issue: https://bugs.openjdk.java.net/browse/JDK-8048610

Re: [JDK-9] RFR: 8050371: MessageDigest tests

2015-03-03 Thread zaiyao liu
Hi Xuelei, Thanks for review, Can you help to push it? Full comments: 8050371: MessageDigest tests Reviewed-by: xuelei Contributed-by: Zaiyao Liu Thanks again. Kevin 在 2015/3/4 13:34, Xuelei Fan 写道: Looks fine to me. Thanks, Xuelei On 2/10/2015 3:46 PM, zaiyao liu wrote: Hi all, Please

Re: [JDK-9] RFR: 8048610 Implement regression tests for bug fixes in JCE

2015-03-03 Thread zaiyao liu
lly write "if (!" --Max On 2/16/2015 9:35, zaiyao liu wrote: Hi all, Please help to review those 2 new tests to verify following 2 JDK bug fixes in JCE: - JDK-4686632: InvalidKeyException.getMessage() returns null - JDK-4901658: Can not produce a string from key'

Re: [JDK-9] RFR: 8048618 Tests for PKCS12 write operations

2015-03-18 Thread zaiyao liu
rd to page up and page down to find out what the tests are doing. Fixed, thanks. Thanks Max On Mar 18, 2015, at 13:33, zaiyao liu wrote: Hi Max, Please help to review this test: JDK issue:https://bugs.openjdk.java.net/browse/JDK-8048618 Webrev:http://cr.openjdk.java.net/~zailiu/8048618/w

Re: [JDK-9] RFR: 8048618 Tests for PKCS12 write operations

2015-03-22 Thread zaiyao liu
. Reviewed-by: weijun Contributed-by: Zaiyao Liu Thanks again. Kevin 在 2015/3/22 7:47, Wang Weijun 写道: Looks fine. One small issue: LEAD_CERT does not have a "\n" before the "-END" line. Although X509Factory accepts it this is not correct. --Max On Mar 19, 2015, at 14:0

RFR 8048820: Implement tests for SecretKeyFactory

2015-04-08 Thread zaiyao liu
Hi All, Please review a couple of new tests for SecretKeyFactory.translateKey(). https://bugs.openjdk.java.net/browse/JDK-8048820 http://cr.openjdk.java.net/~zailiu/8048820/webrev.00/ Thanks Kevin

Re: RFR 8048820: Implement tests for SecretKeyFactory

2015-05-07 Thread zaiyao liu
Hi Xuelei, Can you help to review this test code? Thanks Kevin 在 2015/4/9 14:14, zaiyao liu 写道: Hi All, Please review a couple of new tests for SecretKeyFactory.translateKey(). https://bugs.openjdk.java.net/browse/JDK-8048820 http://cr.openjdk.java.net/~zailiu/8048820/webrev.00/ Thanks

Re: RFR 8048599: Tests for key wrap and unwrap operations

2015-05-07 Thread zaiyao liu
Hi Max, Can you help to review this test code? Thanks Kevin 在 2015/4/10 9:41, zaiyao liu 写道: Hi All, Please help to review the new test for wrap and unwrap operations with crypto keys. Webrev : http://cr.openjdk.java.net/~zailiu/8048599/webrev.00/ JDK bug: https://bugs.openjdk.java.net

Re: RFR 8048820: Implement tests for SecretKeyFactory

2015-05-07 Thread zaiyao liu
Hi Xuelei, Thanks for review, Can you help to push it? Full comments: 8048820:Implement tests for SecretKeyFactory Reviewed-by: xuelei Contributed-by: Zaiyao Liu Thanks again. Kevin 在 2015/5/8 13:49, Xuelei Fan 写道: Looks fine to me. Xuelei On 5/8/2015 1:41 PM, zaiyao liu wrote: Hi Xuelei

Re: RFR 8048599: Tests for key wrap and unwrap operations

2015-05-10 Thread zaiyao liu
Hi Brad, Can you help to review this test code? Thanks Kevin 在 2015/4/10 9:41, zaiyao liu 写道: Hi All, Please help to review the new test for wrap and unwrap operations with crypto keys. Webrev : http://cr.openjdk.java.net/~zailiu/8048599/webrev.00/ JDK bug: https://bugs.openjdk.java.net