Re: Code Review Request, JDK-8146600 AVA Normalizer.Form issue

2016-09-19 Thread Wang Weijun
> On Sep 20, 2016, at 8:58 AM, Xuelei Fan wrote: >> >> I this case, a comma appears but then it is escaped. You might say it is >> unexpected, but at least after escaping, it becomes a legal string. >> > I did not get the point. A comma (",") should be escaped and it

Re: Code Review Request, JDK-8146600 AVA Normalizer.Form issue

2016-09-19 Thread Wang Weijun
Sorry. Whenever I wrote NFC, I meant NFD. Typo. > 在 2016年9月19日，23:16，Xuelei Fan 写道： > >> On 9/19/2016 11:03 PM, Wang Weijun wrote: >> After some thinking, my current opinion is. >> >> 1. Maybe NFC is better than NFKD, but I am not a Unicode expert. >> > It is updated

Re: Code Review Request, JDK-8146600 AVA Normalizer.Form issue

2016-09-19 Thread Xuelei Fan
On 9/19/2016 11:03 PM, Wang Weijun wrote: After some thinking, my current opinion is. 1. Maybe NFC is better than NFKD, but I am not a Unicode expert. It is updated from NFKD to NFD. I did not get the point. Do you mean NFC is better than NFD? 2. I think the real bug is the order of

Re: Code Review Request, JDK-8146600 AVA Normalizer.Form issue

2016-09-19 Thread Wang Weijun
After some thinking, my current opinion is. 1. Maybe NFC is better than NFKD, but I am not a Unicode expert. 2. I think the real bug is the order of escaping and normalization. The normalization (if a must) should be performed earlier right after valStr is created and only performed on valStr.

Re: Code Review Request, JDK-8146600 AVA Normalizer.Form issue

2016-09-18 Thread Xuelei Fan
On 9/19/2016 9:46 AM, Wang Weijun wrote: I am not sure of this change for several reasons: 1. I cannot find anywhere in RFC 2253 (or its new versions) mentioning normalizations. Do you know elsewhere? Normalization is not a part of RFC 2253. The spec is described in Unicode standards.

Re: Code Review Request, JDK-8146600 AVA Normalizer.Form issue

2016-09-18 Thread Wang Weijun
I am not sure of this change for several reasons: 1. I cannot find anywhere in RFC 2253 (or its new versions) mentioning normalizations. Do you know elsewhere? 2. It's not obvious to say "Hello, world!" and "Hello， world!" should be different if NFKD thinks they are. 3. Why not NFC? Although