Re: RFR: 8163126 Wrong @modules in some of jdk/* tests

> On Aug 16, 2016, at 10:17 AM, Alexandre (Shura) Iline > wrote: > > Hi. > > Please review fixes related to module dependencies in a few jdk tests: > http://cr.openjdk.java.net/~shurailine/8163126/webrev.00/index.html Looks okay. I will sponsor this patch for

Re: RFR: 8163126 Wrong @modules in some of jdk/* tests

On 17/08/2016 17:40, Alexandre (Shura) Iline wrote: Thank you! Fixed in place: http://cr.openjdk.java.net/~shurailine/8163126/webrev.00/test/jdk/security/jarsigner/Spec.java.sdiff.html Shura The updated patch looks good to me. Slightly off-topic but how close do you think we are to

Re: RFR: 8163126 Wrong @modules in some of jdk/* tests

Thank you! Fixed in place: http://cr.openjdk.java.net/~shurailine/8163126/webrev.00/test/jdk/security/jarsigner/Spec.java.sdiff.html Shura > On Aug 16, 2016, at 6:48 PM, Wang Weijun wrote: > > >> On Aug 17, 2016, at 9:26 AM, Alexandre (Shura) Iline >>

Re: RFR: 8163126 Wrong @modules in some of jdk/* tests

Hi Shura I am looking at test/jdk/security/jarsigner/Spec.java. IMHO, even on a Solaris, without the SunPKCS11 provider at runtime, this test should be able to find Signature and MessageDigest implementations from the SunRsaSign and SUN provider. Is the new @modules dependency necessary? In

RFR: 8163126 Wrong @modules in some of jdk/* tests

Hi. Please review fixes related to module dependencies in a few jdk tests: http://cr.openjdk.java.net/~shurailine/8163126/webrev.00/index.html The review contains a few cases where jdk.zipfs is added to the module list. This is happening because all TestNG tests which use compiler API require