Re: RFR 8075618: Create tests to check jarsigner work with multi-version jar

2016-12-18 Thread Wang Weijun
Hi Amanda Everything is fine. I have no other comment. Thanks Max > On Dec 19, 2016, at 2:43 PM, Amanda Jiang wrote: > > > > On 12/18/16 10:23 PM, Wang Weijun wrote: >>> Please see updated webrev : >>> http://cr.openjdk.java.net/~amjiang/8075618/webrev.04/ (also

Re: RFR 8075618: Create tests to check jarsigner work with multi-version jar

2016-12-18 Thread Wang Weijun
> On Dec 19, 2016, at 5:38 AM, Amanda Jiang wrote: > > Hi Paul, Artem and Max, > > Thanks for your comments. Please check the new webrev at: > http://cr.openjdk.java.net/~amjiang/8075618/webrev.03/ (It looks like > "cr.openjdk.java.net" is down, I also attach the

Re: RFR 8075618: Create tests to check jarsigner work with multi-version jar

2016-12-12 Thread Artem Smotrakov
You can use http://hg.openjdk.java.net/jdk9/dev/jdk/file/d4d7f1f0d688/test/lib/security/SecurityTools.java which would simplify the code. This lib was added to be used in such tests. Note that SecurityTools addresses a couple of known issues with running security tools on machines with

RFR 8075618: Create tests to check jarsigner work with multi-version jar

2016-12-12 Thread Amanda Jiang
Hi All, Please help to review following changeset, which tests that jarsigner tool works with multi-release JAR files. Webrev: http://cr.openjdk.java.net/~amjiang/8075618/webrev.01/ Bug: https://bugs.openjdk.java.net/browse/JDK-8075618 Thanks, Amanda