On 4/15/20 8:28 AM, Weijun Wang wrote:
On Apr 9, 2020, at 3:46 AM, Sean Mullan wrote:
On 4/6/20 11:11 PM, Weijun Wang wrote:
Please review the fix at
http://cr.openjdk.java.net/~weijun/8242184/webrev.00/
The major change is inside X509CRLImpl.java to allow params setting and reading.
I
> On Apr 9, 2020, at 3:46 AM, Sean Mullan wrote:
>
> On 4/6/20 11:11 PM, Weijun Wang wrote:
>> Please review the fix at
>>http://cr.openjdk.java.net/~weijun/8242184/webrev.00/
>> The major change is inside X509CRLImpl.java to allow params setting and
>> reading.
>> I also take this chance
Valerie in another reply suggested that the default parameters of the default
sigAlg depends on either the size of the key (if RSA) of the params of the key
(if RSASSA-PSS). I'll address all of these in another bug.
Thanks,
Max
> 在 2020年4月9日，03:47，Sean Mullan 写道：
>
> On 4/6/20 11:11 PM,
On 4/6/20 11:11 PM, Weijun Wang wrote:
Please review the fix at
http://cr.openjdk.java.net/~weijun/8242184/webrev.00/
The major change is inside X509CRLImpl.java to allow params setting and reading.
I also take this chance to:
1. Provide a default -sigalg for "keytool -genkeypair -keyalg
> On Apr 8, 2020, at 11:46 AM, Valerie Peng wrote:
>
> Hi Max,
>
> Not all of the comments are related to the changes in the webrev, just notice
> some PSS related inconsistency and thought I will ask:
>
>
>
> - For RSASSA-PSS keys, existing code in getDefaultAlgorithmParameterSpec(...)
Hi Max,
Not all of the comments are related to the changes in the webrev, just
notice some PSS related inconsistency and thought I will ask:
- For RSASSA-PSS keys, existing code in
getDefaultAlgorithmParameterSpec(...) (line 1121) decides the default
based on key size. I think we should
+1.
Xuelei
On 4/7/2020 5:46 PM, Hai-May Chao wrote:
Hi Max,
Changes look good to me.
Hai-May
On Apr 6, 2020, at 8:11 PM, Weijun Wang wrote:
Please review the fix at
http://cr.openjdk.java.net/~weijun/8242184/webrev.00/
The major change is inside X509CRLImpl.java to allow params
Hi Max,
Changes look good to me.
Hai-May
> On Apr 6, 2020, at 8:11 PM, Weijun Wang wrote:
>
> Please review the fix at
>
> http://cr.openjdk.java.net/~weijun/8242184/webrev.00/
>
> The major change is inside X509CRLImpl.java to allow params setting and
> reading.
>
> I also take this
Please review the fix at
http://cr.openjdk.java.net/~weijun/8242184/webrev.00/
The major change is inside X509CRLImpl.java to allow params setting and reading.
I also take this chance to:
1. Provide a default -sigalg for "keytool -genkeypair -keyalg rsassa-pss".
2. Revert a former change
