Re: code review request for CR 6989705: ECC security code native code compiler warnings

2011-01-21 Thread Alan Bateman
Vincent Ryan wrote: Hello Alan, Please review the following webrev which removes 100's of nuisance compiler warnings generated by our ECC code: http://rialto.ireland.sun.com/~vinnie/webrevs/jdk7/6989705/webrev/ Getting rid of the #pragmas and the other changes look okay to me. The only

Re: code review request for CR 6989705: ECC security code native code compiler warnings

2011-01-21 Thread Vincent Ryan
On 21/01/2011 14:42, Alan Bateman wrote: Vincent Ryan wrote: Hello Alan, Please review the following webrev which removes 100's of nuisance compiler warnings generated by our ECC code: http://rialto.ireland.sun.com/~vinnie/webrevs/jdk7/6989705/webrev/ Getting rid of the #pragmas and

Re: code review request for CR 6989705: ECC security code native code compiler warnings

2011-01-21 Thread Kelly O'Hair
On Jan 21, 2011, at 7:08 AM, Vincent Ryan wrote: On 21/01/2011 14:42, Alan Bateman wrote: Vincent Ryan wrote: Hello Alan, Please review the following webrev which removes 100's of nuisance compiler warnings generated by our ECC code:

code review request for CR 6989705: ECC security code native code compiler warnings

2011-01-20 Thread Vincent Ryan
Hello Alan, Please review the following webrev which removes 100's of nuisance compiler warnings generated by our ECC code: http://rialto.ireland.sun.com/~vinnie/webrevs/jdk7/6989705/webrev/