Re: RFR: 8209992: Align SSLSocket and SSLEngine Javadocs [v4]

2025-08-01 Thread Bradford Wetmore
On Fri, 1 Aug 2025 15:18:10 GMT, Artur Barashev wrote: >> Add a javadoc paragraph to SSLSocket.startHandshake() and >> SSLEngine.beginHandshake() methods explaining behavioral differences between >> TLSv1.3+ and TLSv1.2- versions. > > Artur Barashev has updated the pull request incrementally wi

Re: RFR: 8209992: Align SSLSocket and SSLEngine Javadocs [v3]

2025-08-01 Thread Artur Barashev
On Fri, 1 Aug 2025 00:39:32 GMT, Bradford Wetmore wrote: >> Artur Barashev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Address Brad's code review > > src/java.base/share/classes/javax/net/ssl/SSLEngine.java line 1101: > >> 1099:

Re: RFR: 8209992: Align SSLSocket and SSLEngine Javadocs [v4]

2025-08-01 Thread Artur Barashev
> Add a javadoc paragraph to SSLSocket.startHandshake() and > SSLEngine.beginHandshake() methods explaining behavioral differences between > TLSv1.3+ and TLSv1.2- versions. Artur Barashev has updated the pull request incrementally with one additional commit since the last revision: Address l

Re: RFR: 8209992: Align SSLSocket and SSLEngine Javadocs [v3]

2025-07-31 Thread Bradford Wetmore
On Thu, 31 Jul 2025 18:53:20 GMT, Artur Barashev wrote: >> Add a javadoc paragraph to SSLSocket.startHandshake() and >> SSLEngine.beginHandshake() methods explaining behavioral differences between >> TLSv1.3+ and TLSv1.2- versions. > > Artur Barashev has updated the pull request incrementally w

Re: RFR: 8209992: Align SSLSocket and SSLEngine Javadocs [v3]

2025-07-31 Thread Artur Barashev
> Add a javadoc paragraph to SSLSocket.startHandshake() and > SSLEngine.beginHandshake() methods explaining behavioral differences between > TLSv1.3+ and TLSv1.2- versions. Artur Barashev has updated the pull request incrementally with one additional commit since the last revision: Address B

Re: RFR: 8209992: Align SSLSocket and SSLEngine Javadocs [v2]

2025-07-30 Thread Bradford Wetmore
On Mon, 28 Jul 2025 14:12:12 GMT, Artur Barashev wrote: >> Add a javadoc paragraph to SSLSocket.startHandshake() and >> SSLEngine.beginHandshake() methods explaining behavioral differences between >> TLSv1.3+ and TLSv1.2- versions. > > Artur Barashev has updated the pull request incrementally w

Re: RFR: 8209992: Align SSLSocket and SSLEngine Javadocs [v2]

2025-07-28 Thread Artur Barashev
On Fri, 25 Jul 2025 20:13:00 GMT, Bradford Wetmore wrote: > The renegotiation wording should probably updated in both the > SSLSocket/SSLEngine section. As was pointed out, TLSv1.3 is not a full > renegotiation. > > You could soften some of the wording with something like (needs wordsmithing):

Re: RFR: 8209992: Align SSLSocket and SSLEngine Javadocs [v2]

2025-07-28 Thread Artur Barashev
> Add a javadoc paragraph to SSLSocket.startHandshake() and > SSLEngine.beginHandshake() methods explaining behavioral differences between > TLSv1.3+ and TLSv1.2- versions. Artur Barashev has updated the pull request incrementally with one additional commit since the last revision: Address P

Re: RFR: 8209992: Align SSLSocket and SSLEngine Javadocs

2025-07-25 Thread Bradford Wetmore
On Fri, 25 Jul 2025 16:27:42 GMT, Artur Barashev wrote: > Add a javadoc paragraph to SSLSocket.startHandshake() and > SSLEngine.beginHandshake() methods explaining behavioral differences between > TLSv1.3+ and TLSv1.2- versions. The renegotiation wording should probably updated in both the SS

RFR: 8209992: Align SSLSocket and SSLEngine Javadocs

2025-07-25 Thread Artur Barashev
Add a javadoc paragraph to SSLSocket.startHandshake() and SSLEngine.beginHandshake() methods explaining behavioral differences between TLSv1.3+ and TLSv1.2- versions. - Commit messages: - 8209992: Align SSLSocket and SSLEngine Javadocs Changes: https://git.openjdk.org/jdk/pull/264