Re: RFR: 8299817: [s390] AES-CTR mode intrinsic fails with multiple short update() calls

2023-01-16 Thread Lutz Schmidt
On Thu, 12 Jan 2023 14:29:34 GMT, Lutz Schmidt wrote: > This PR addresses an issue in the AES-CTR mode intrinsic on s390. When a > message is ciphered in multiple, small (< 16 bytes) segments, the result is > incorrect. > > This is not just a band-aid fix. The issue was taken as a chance to >

Missing test coverage for processing of pending block files in signed JARs

2023-01-16 Thread Eirik Bjørsnøs
Hi, JarVerifier supports processing of signed JARs where the block file [RSA, DSA, EC] file comes before its corresponding SF signature file. There seems to be no test coverage for this code path. This draft PR adds test coverage for processing of pending block files: https://github.com/openjdk/

Re: RFR: 8300140: ZipFile.isSignatureRelated returns true for files in META-INF subdirectories [v6]

2023-01-16 Thread Eirik Bjorsnos
> Some call sites of SignatureFileVerifier.isBlockOrSF fails to check that > files reside in META-INF directly, and not in a subdirectory of META-INF. > > The mentioned call sites needs updates to check and ignore such files. > > A new test VerifyUnrelatedSignatureFiles is added which verifies t

Re: RFR: JDK-8300133: Use generalized see and link tags in core libs [v2]

2023-01-16 Thread Daniel Fuchs
On Fri, 13 Jan 2023 22:54:47 GMT, Joe Darcy wrote: >> With generalized see and link tags that can refer to anchors (JDK-8200337), >> the see and link tags in core libraries should be updated to use this >> feature when possible. This PR covers such updates for java.base. > > Joe Darcy has updat

Re: RFR: JDK-8300133: Use generalized see and link tags in core libs [v2]

2023-01-16 Thread Daniel Fuchs
On Fri, 13 Jan 2023 22:54:47 GMT, Joe Darcy wrote: >> With generalized see and link tags that can refer to anchors (JDK-8200337), >> the see and link tags in core libraries should be updated to use this >> feature when possible. This PR covers such updates for java.base. > > Joe Darcy has updat

Re: RFR: JDK-8300133: Use generalized see and link tags in core libs [v2]

2023-01-16 Thread Roger Riggs
On Mon, 16 Jan 2023 15:06:25 GMT, Daniel Fuchs wrote: >> Joe Darcy has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fix typo found in code review. > > src/java.base/share/classes/java/lang/CharSequence.java line 76: > >> 74: * >> 75

Integrated: 8298867: Basics.java fails with SSL handshake exception

2023-01-16 Thread Matthew Donovan
On Wed, 21 Dec 2022 23:42:48 GMT, Matthew Donovan wrote: > Updated to use specific ciphersuite and TLS protocol. > Updated tests based on changes to SSLEngine implementation This pull request has now been integrated. Changeset: 06f9374e Author:Matthew Donovan Committer: Julian Waters URL: