Re: RFR: 8303480: Miscellaneous fixes to mostly invisible doc comments

2023-03-03 Thread Alexey Ivanov
On Thu, 2 Mar 2023 12:03:44 GMT, Pavel Rappo wrote: > Please review this superficial documentation cleanup that was triggered by > unrelated analysis of doc comments in JDK API. > > The only effect that this multi-area PR has on the JDK API Documentation > (i.e. the observable effect on the ge

Re: RFR: 8303480: Miscellaneous fixes to mostly invisible doc comments

2023-03-03 Thread Pavel Rappo
On Thu, 2 Mar 2023 16:23:17 GMT, Alexey Ivanov wrote: >> Please review this superficial documentation cleanup that was triggered by >> unrelated analysis of doc comments in JDK API. >> >> The only effect that this multi-area PR has on the JDK API Documentation >> (i.e. the observable effect on

Re: RFR: 8303480: Miscellaneous fixes to mostly invisible doc comments

2023-03-03 Thread Pavel Rappo
On Fri, 3 Mar 2023 08:15:49 GMT, Alexey Ivanov wrote: >> Please review this superficial documentation cleanup that was triggered by >> unrelated analysis of doc comments in JDK API. >> >> The only effect that this multi-area PR has on the JDK API Documentation >> (i.e. the observable effect on

Re: RFR: 8303480: Miscellaneous fixes to mostly invisible doc comments

2023-03-03 Thread Claes Redestad
On Fri, 3 Mar 2023 09:38:13 GMT, Pavel Rappo wrote: >> src/java.base/share/classes/java/lang/invoke/BootstrapMethodInvoker.java >> line 257: >> >>> 255: >>> 256: /** >>> 257: * @return true iff the BSM method type exactly matches >> >> I assume “iff” should “if”? > > Here and elsewhe

Re: RFR: 8303480: Miscellaneous fixes to mostly invisible doc comments

2023-03-03 Thread Alexey Ivanov
On Fri, 3 Mar 2023 10:09:27 GMT, Claes Redestad wrote: > Yes, iff means if-and-only-if and is used for extra precision in formal > logic, mathematics. I've never come across it before. With your explanations, it makes perfect sense. - PR: https://git.openjdk.org/jdk/pull/12826

Integrated: 8297955: LDAP CertStore should use LdapName and not String for DNs

2023-03-03 Thread Sean Mullan
On Thu, 23 Feb 2023 16:42:17 GMT, Sean Mullan wrote: > The LDAPCertStore implementation passes Distinguished Names in CRL and > Certificate URLs as Strings to JNDI APIs such as > LdapContext.getAttributes(String), which then treats them as CompositeNames. > This causes issues with URLs that ha

Re: RFR: JDK-8303465: KeyStore of type KeychainStore, provider Apple shows different behavior after 8278449

2023-03-03 Thread Weijun Wang
On Thu, 2 Mar 2023 13:33:53 GMT, Matthias Baesken wrote: > After 8278449, we seem to ignore in the call > > ` if (SecTrustSettingsCopyTrustSettings(certRef, > kSecTrustSettingsDomainUser, &trustSettings) == errSecItemNotFound) ` > > all trusted certs from admin and system domains, so a lot mo

Re: RFR: JDK-8303465: KeyStore of type KeychainStore, provider Apple shows different behavior after 8278449

2023-03-03 Thread Weijun Wang
On Thu, 2 Mar 2023 13:33:53 GMT, Matthias Baesken wrote: > After 8278449, we seem to ignore in the call > > ` if (SecTrustSettingsCopyTrustSettings(certRef, > kSecTrustSettingsDomainUser, &trustSettings) == errSecItemNotFound) ` > > all trusted certs from admin and system domains, so a lot mo

Re: Update to JEP draft: Key Encapsulation Mechanism API

2023-03-03 Thread Wei-Jun Wang
Hi All, The JEP draft was just updated again. The major change is that there is no more DerivedKeyParameterSpec class. Maybe it's because of the name, but we found many people treating it as a place to configure the KDF used inside a KEM. Actually the only usage of it is to give caller a chanc

Re: Update to JEP draft: Key Encapsulation Mechanism API

2023-03-03 Thread Bernd
Will „Generic“ work with ciphers which need „raw“, or is that intentionally not the case?Btw I like the simplification.GrussBernd -- http://bernd.eckenfels.net  Von: security-dev im Auftrag von Wei-Jun Wang Gesendet: Freitag, März 3, 2023 6:31 PMAn: security-...@

RFR: 8296400: pointCrlIssuers might be null in DistributionPointFetcher::verifyURL

2023-03-03 Thread Matthew Donovan
Added null-checks for pointCrlIssuers before it is accessed. - Commit messages: - 8296400: pointCrlIssuers might be null in DistributionPointFetcher::verifyURL Changes: https://git.openjdk.org/jdk/pull/12866/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=12866&range=00 Is