Re: RFR: 8350830: Values converted incorrectly when reading TLS session tickets [v3]

2025-05-07 Thread duke
On Mon, 14 Apr 2025 12:54:31 GMT, Nibedita Jena wrote: >> Session resumption without server side state was added under >> [JDK-8211018](https://bugs.openjdk.org/browse/JDK-8211018). >> While it is TLSv1.2 session resumption, the client hello message is being >> parsed in SSLSessionImpl for each

Re: RFR: 8341346: Add support for exporting TLS Keying Material [v7]

2025-05-07 Thread Bradford Wetmore
On Wed, 7 May 2025 16:28:27 GMT, Weijun Wang wrote: >> Bradford Wetmore has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Updated to use the upcoming KDF (still in preview) + bits of JDK-8353578 >> for compilation) > > src/java.base/share

Re: RFR: 8249824: s/n/w/p/https/HttpsURLConnection/CloseKeepAliveCached.java uses @ignore w/o bugid [v3]

2025-05-07 Thread Rajan Halade
On Thu, 6 Feb 2025 15:54:47 GMT, Mikhail Yankelevich wrote: >> * fully automated the test >> * removed the race condition >> * client on a thread and server on a thread options are now run together >> automatically > > Mikhail Yankelevich has updated the pull request incrementally with one > a

Re: RFR: 8353197: Document preconditions for JavaLangAccess methods [v2]

2025-05-07 Thread Volkan Yazici
On Wed, 7 May 2025 07:37:48 GMT, Alan Bateman wrote: >> Volkan Yazici has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fix typo in pre-existing JavaDoc > > src/java.base/share/classes/jdk/internal/access/JavaLangAccess.java line 302: > >

Re: RFR: 8341346: Add support for exporting TLS Keying Material [v7]

2025-05-07 Thread Weijun Wang
On Wed, 7 May 2025 05:47:30 GMT, Bradford Wetmore wrote: >> Adds the RFC 5705/8446 TLS Key Exporters API/implementation to JSSE/SunJSSE >> respectively. >> >> CSR is underway. >> >> Tests include new unit tests for TLSv1-1.3. Will run tier1-2, plus the JCK >> API (jck:api/java_security jck:a

Re: RFR: 8353197: Document preconditions for JavaLangAccess methods [v2]

2025-05-07 Thread Raffaello Giulietti
On Wed, 7 May 2025 08:02:28 GMT, Alan Bateman wrote: >> Volkan Yazici has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fix typo in pre-existing JavaDoc > > src/java.base/share/classes/jdk/internal/access/JavaLangAccess.java line 355: > >

Re: RFR: 8350830: Values converted incorrectly when reading TLS session tickets [v3]

2025-05-07 Thread Nibedita Jena
On Wed, 23 Apr 2025 20:16:17 GMT, Anthony Scarpino wrote: >> Nibedita Jena has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Updated SSLSessionImpl constructor with Record interface methods > > I will look at this.. At the time I wrote th

Re: RFR: 8353197: Document preconditions for JavaLangAccess methods [v3]

2025-05-07 Thread Volkan Yazici
> Document preconditions on certain `JavaLangAccess` methods that use > operations either unsafe and/or without range checks. Volkan Yazici has updated the pull request incrementally with one additional commit since the last revision: Prefix touched methods with `unchecked` - Ch

Re: RFR: 8353197: Document preconditions for JavaLangAccess methods [v2]

2025-05-07 Thread Volkan Yazici
On Wed, 7 May 2025 13:22:11 GMT, Raffaello Giulietti wrote: >> src/java.base/share/classes/jdk/internal/access/JavaLangAccess.java line 355: >> >>> 353: * UTF-16 representation. >>> 354: * >>> 355: * WARNING: This method does not perform any bound checks. >> >> Maybe not this P

Re: RFR: 8353197: Document preconditions for JavaLangAccess methods [v2]

2025-05-07 Thread Volkan Yazici
On Wed, 7 May 2025 07:52:37 GMT, Alan Bateman wrote: >> Volkan Yazici has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fix typo in pre-existing JavaDoc > > src/java.base/share/classes/jdk/internal/access/JavaLangAccess.java line 332: > >

Re: RFR: 8341346: Add support for exporting TLS Keying Material [v7]

2025-05-07 Thread Weijun Wang
On Wed, 7 May 2025 05:47:30 GMT, Bradford Wetmore wrote: >> Adds the RFC 5705/8446 TLS Key Exporters API/implementation to JSSE/SunJSSE >> respectively. >> >> CSR is underway. >> >> Tests include new unit tests for TLSv1-1.3. Will run tier1-2, plus the JCK >> API (jck:api/java_security jck:a

Re: RFR: 8298420: PEM API: Implementation (Preview) [v15]

2025-05-07 Thread Weijun Wang
On Fri, 2 May 2025 06:09:52 GMT, Anthony Scarpino wrote: >> Hi all, >> >> I need a code review of the PEM API. Privacy-Enhanced Mail (PEM) is a >> format for encoding and decoding cryptographic keys and certificates. It >> will be integrated into JDK24 as a Preview Feature. Preview features

Re: RFR: 8298420: PEM API: Implementation (Preview) [v15]

2025-05-07 Thread Sean Mullan
On Tue, 30 Jul 2024 21:06:06 GMT, Anthony Scarpino wrote: >> I'm afraid that someone will overwrite the java.security file and remove >> that property. Then wonder what will happen and if the error message is >> clear. > > I added the exception `SecretKeyFactory.getInstance()` will throw `Nul

Re: RFR: 8310003: Improve logging when default truststore is inaccessible

2025-05-07 Thread Sean Mullan
On Wed, 7 May 2025 03:45:06 GMT, Koushik Muthukrishnan Thirupattur wrote: > If the truststore is unavailable, JDK does not log information for > 'trustStore provider is:'. We are now adding 'unspecified' instead of keeping > empty. src/java.base/share/classes/sun/security/ssl/TrustStoreManage

Re: RFR: 8310003: Improve logging when default truststore is inaccessible [v2]

2025-05-07 Thread Koushik Muthukrishnan Thirupattur
> If the truststore is unavailable, JDK does not log information for > 'trustStore provider is:'. We are now adding 'unspecified' instead of keeping > empty. Koushik Muthukrishnan Thirupattur has updated the pull request incrementally with one additional commit since the last revision: 83100

Re: RFR: 8310003: Improve logging when default truststore is inaccessible [v2]

2025-05-07 Thread Koushik Muthukrishnan Thirupattur
On Wed, 7 May 2025 17:02:26 GMT, Sean Mullan wrote: >> Koushik Muthukrishnan Thirupattur has updated the pull request incrementally >> with one additional commit since the last revision: >> >> 8310003: Improve logging when default truststore is inaccessible > > src/java.base/share/classes/sun

Re: RFR: 8298420: PEM API: Implementation (Preview) [v15]

2025-05-07 Thread Sean Mullan
On Fri, 2 May 2025 06:09:52 GMT, Anthony Scarpino wrote: >> Hi all, >> >> I need a code review of the PEM API. Privacy-Enhanced Mail (PEM) is a >> format for encoding and decoding cryptographic keys and certificates. It >> will be integrated into JDK24 as a Preview Feature. Preview features

Re: RFR: 8249825: Tests sun/security/ssl/SSLSocketImpl/SetClientMode.java and NonAutoClose.java marked with @ignore [v4]

2025-05-07 Thread Rajan Halade
On Fri, 21 Mar 2025 12:00:57 GMT, Fernando Guallini wrote: >> The following tests are marked with @ignore (not running): >> >> - sun/security/ssl/SSLSocketImpl/SetClientMode.java: it checks that setting >> the clientMode after the handshake has begun is not permitted, but this was >> failing

Re: RFR: 8349151: Refactor test/java/security/cert/CertificateFactory/slowstream.sh to java test [v2]

2025-05-07 Thread Rajan Halade
On Mon, 3 Feb 2025 19:12:30 GMT, Mikhail Yankelevich wrote: >> Refactor test/java/security/cert/CertificateFactory/slowstream.sh to java >> test > > Mikhail Yankelevich has updated the pull request incrementally with one > additional commit since the last revision: > > cleanup Changes requ

Re: [Bug] NPE thrown from SASL GSSAPI impl on Java 11+ when TLS is used with QOP auth-int against Active Directory

2025-05-07 Thread Weibing Xiao
Hi Michael, Please share a working copy of the code to duplicate the failure scenario of NPE related to Connection.java. BTW, I checked the stack trace posted on April 28 it did not clearly show Connection::cleanup got called. Was there something missed? Thank you, Weibing From: security-dev

Re: RFR: 8341346: Add support for exporting TLS Keying Material [v8]

2025-05-07 Thread Bradford Wetmore
> Adds the RFC 5705/8446 TLS Key Exporters API/implementation to JSSE/SunJSSE > respectively. > > CSR is underway. > > Tests include new unit tests for TLSv1-1.3. Will run tier1-2, plus the JCK > API (jck:api/java_security jck:api/javax_crypto jck:api/javax_net > jck:api/javax_security jck:ap

Re: RFR: 8298420: PEM API: Implementation (Preview) [v15]

2025-05-07 Thread Sean Mullan
On Wed, 7 May 2025 16:42:20 GMT, Weijun Wang wrote: >> Anthony Scarpino has updated the pull request with a new target base due to >> a merge or a rebase. The pull request now contains 66 commits: >> >> - major code review comments update >> - Merge branch 'master' into pem >> - Merge branch

Re: RFR: 8298420: PEM API: Implementation (Preview) [v15]

2025-05-07 Thread Sean Mullan
On Fri, 2 May 2025 06:09:52 GMT, Anthony Scarpino wrote: >> Hi all, >> >> I need a code review of the PEM API. Privacy-Enhanced Mail (PEM) is a >> format for encoding and decoding cryptographic keys and certificates. It >> will be integrated into JDK24 as a Preview Feature. Preview features

Re: RFR: 8356087: Problematic KeyInfo check using key algorithm in P11SecretKeyFactory class [v2]

2025-05-07 Thread Valerie Peng
> In the PR for JDK-8348732 "SunJCE and SunPKCS11 have different PBE key > encodings", the `P11SecretKeyFactory.convertKey(...)` method is refactored to > call `getKeyInfo(keyAlgo)` and check that it's not `null`. However, this > leads to problems for the `P11Mac` object when it's initialized wi

RFR: 8356087: Problematic KeyInfo check using key algorithm in P11SecretKeyFactory class

2025-05-07 Thread Valerie Peng
In the PR for JDK-8348732 "SunJCE and SunPKCS11 have different PBE key encodings", the `P11SecretKeyFactory.convertKey(...)` method is refactored to call `getKeyInfo(keyAlgo)` and check that it's not `null`. However, this leads to problems for the `P11Mac` object when it's initialized with a key

Re: RFR: 8353197: Document preconditions for JavaLangAccess methods [v2]

2025-05-07 Thread Volkan Yazici
On Fri, 2 May 2025 14:39:55 GMT, Roger Riggs wrote: >> Volkan Yazici has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fix typo in pre-existing JavaDoc > > src/java.base/share/classes/jdk/internal/access/JavaLangAccess.java line 314: > >>

Re: RFR: 8353197: Document preconditions for JavaLangAccess methods [v2]

2025-05-07 Thread Volkan Yazici
On Wed, 7 May 2025 07:26:56 GMT, Volkan Yazici wrote: >> Document preconditions on certain `JavaLangAccess` methods that use >> operations either unsafe and/or without range checks. > > Volkan Yazici has updated the pull request incrementally with one additional > commit since the last revision

Re: RFR: 8353197: Document preconditions for JavaLangAccess methods [v2]

2025-05-07 Thread Volkan Yazici
> Document preconditions on certain `JavaLangAccess` methods that use > operations either unsafe and/or without range checks. Volkan Yazici has updated the pull request incrementally with one additional commit since the last revision: Fix typo in pre-existing JavaDoc - Changes:

Re: RFR: 8353197: Document preconditions for JavaLangAccess methods [v2]

2025-05-07 Thread Volkan Yazici
On Thu, 1 May 2025 13:00:37 GMT, Chen Liang wrote: >> Volkan Yazici has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fix typo in pre-existing JavaDoc > > src/java.base/share/classes/jdk/internal/access/JavaLangAccess.java line 315: > >>

Re: RFR: 8353197: Document preconditions for JavaLangAccess methods [v2]

2025-05-07 Thread Alan Bateman
On Wed, 7 May 2025 07:29:55 GMT, Volkan Yazici wrote: >> Document preconditions on certain `JavaLangAccess` methods that use >> operations either unsafe and/or without range checks. > > Volkan Yazici has updated the pull request incrementally with one additional > commit since the last revision

Re: RFR: 8353197: Document preconditions for JavaLangAccess methods [v2]

2025-05-07 Thread Alan Bateman
On Wed, 7 May 2025 07:29:55 GMT, Volkan Yazici wrote: >> Document preconditions on certain `JavaLangAccess` methods that use >> operations either unsafe and/or without range checks. > > Volkan Yazici has updated the pull request incrementally with one additional > commit since the last revision

Re: RFR: 8353197: Document preconditions for JavaLangAccess methods [v2]

2025-05-07 Thread Alan Bateman
On Wed, 7 May 2025 07:29:55 GMT, Volkan Yazici wrote: >> Document preconditions on certain `JavaLangAccess` methods that use >> operations either unsafe and/or without range checks. > > Volkan Yazici has updated the pull request incrementally with one additional > commit since the last revision

Re: RFR: 8353197: Document preconditions for JavaLangAccess methods [v2]

2025-05-07 Thread Jaikiran Pai
On Wed, 7 May 2025 07:29:55 GMT, Volkan Yazici wrote: >> Document preconditions on certain `JavaLangAccess` methods that use >> operations either unsafe and/or without range checks. > > Volkan Yazici has updated the pull request incrementally with one additional > commit since the last revision