RE: XML Security C++: Incomplete cleanup in XSECC14n20010315 destructor

2007-08-23 Thread Scott Cantor
> I can see how it could occur if the canonicalisation gets interrupted in > the midst of outputting Attribute nodes. This fix would work nicely, > and I think it should be safe as the code that normally cleans up > ensures mp_attributes is NULL, so it won't get called unnecessarily. Ok, I checke

Re: XML Security C++: Incomplete cleanup in XSECC14n20010315 destructor

2007-08-23 Thread Vitaly Prapirny
Berin Lautenbach wrote: Hmm. That's an interesting one. Have you seen a case where the mp_attributes list is not already clear when the destructor is called? Yes. That is why this fix has been appeared. But I can't remember those particular case for now, after almost three years :) Sorry for

Re: XML Security C++: Incomplete cleanup in XSECC14n20010315 destructor

2007-08-23 Thread Berin Lautenbach
Hmm. That's an interesting one. Have you seen a case where the mp_attributes list is not already clear when the destructor is called? I can see how it could occur if the canonicalisation gets interrupted in the midst of outputting Attribute nodes. This fix would work nicely, and I think it

RE: XML Security C++: Incomplete cleanup in XSECC14n20010315 destructor

2007-08-22 Thread Scott Cantor
> XSECC14n20010315 destructor performs delete [] m_exclNSList[i] but > m_exclNSList items was allocated with strdup and must be released > with free(). And mp_attributes cleanup is absent in code. So I > propose this version of destructor: I'll check in the free fix, but I'd like to get confirmati