Re: Samples now failing

2004-05-14 Thread Berin Lautenbach
Sean Mullan wrote: I agree with your opinion. However, I think that this is actually fixable in the test case by making sure that reference-1 is inserted in the document before the manifest is generated. . I did my normal trick of not saying everything. Yes - that's correct, and it's what I wa

Re: Samples now failing

2004-05-13 Thread Erwin van der Koogh
+1 (non-binding) to throwing exception as per berin/raul AND fixing the sample as per Sean :) +1 from me as well. If I read it properly it might break some obscure applications, but they probably should be thankful for it. Cause I can't think of serious situations where it would happen and you wo

Re: Samples now failing

2004-05-13 Thread Davanum Srinivas
+1 (non-binding) to throwing exception as per berin/raul AND fixing the sample as per Sean :) -- dims On Thu, 13 May 2004 08:36:22 -0400, Sean Mullan <[EMAIL PROTECTED]> wrote: > > Berin Lautenbach wrote: > > Yup. > > > > I've also worked out the problem, but I need some advice from everyone > >

Re: Samples now failing

2004-05-13 Thread Sean Mullan
Berin Lautenbach wrote: Yup. I've also worked out the problem, but I need some advice from everyone as to the "right" fix. The samples create a manifest object that refers to a URI in the rest of the signature. At the time the manifest is created, the element that will hold the relevant Id ha

Re: Samples now failing

2004-05-13 Thread Berin Lautenbach
Yup. I've also worked out the problem, but I need some advice from everyone as to the "right" fix. The samples create a manifest object that refers to a URI in the rest of the signature. At the time the manifest is created, the element that will hold the relevant Id has not yet been added to

Re: Samples now failing

2004-05-13 Thread raul-info
> Dims, > > I just tried to apply your new code for Merlin-23 and it's flushed out > that the mega-sample target is now throwing an exception when it > creates a non XSLT target (and so is the new 23). > > I think this is something to do with the new optimisations, but I'll > try and track it dow

Re: Samples now failing

2004-05-13 Thread raul-info
> Dims, > > I just tried to apply your new code for Merlin-23 and it's flushed out > that the mega-sample target is now throwing an exception when it > creates a non XSLT target (and so is the new 23). > > I think this is something to do with the new optimisations, but I'll > try and track it dow

Re: Samples now failing

2004-05-12 Thread Davanum Srinivas
np. we should add "mega-sample" target to the "test" itself. -- dims On Wed, 12 May 2004 22:34:29 +1000, Berin Lautenbach <[EMAIL PROTECTED]> wrote: > > Dims, > > I just tried to apply your new code for Merlin-23 and it's flushed out > that the mega-sample target is now throwing an exception w

Samples now failing

2004-05-12 Thread Berin Lautenbach
Dims, I just tried to apply your new code for Merlin-23 and it's flushed out that the mega-sample target is now throwing an exception when it creates a non XSLT target (and so is the new 23). I think this is something to do with the new optimisations, but I'll try and track it down later this