Re: RFR: 8193892: Impact of noncloneable MessageDigest implementation

Thanks for the review Brad. Yes - I'll make those changes before pushing. regards, Sean. On 23/02/2018 20:14, Brad Wetmore wrote: Minor comments.  I'm ok with leaving as is, but this seems cleaner. MyProvider.java --- Would prefer to use the non-deprecated super call.

Re: RFR 8197518: Kerberos krb5 authentication: AuthList's put method leads to performance issue

> On Feb 24, 2018, at 12:38 AM, Daniel Fuchs wrote: > > Hi Max, > > 85 // has larger timestamp. > 86 entries.addFirst(t); > > shouldn't you set oldestTime here as well? The order might be a little misleading, you addFirst() the

Re: [PATCH] JDK-8190917 : SSL session resumption, through handshake, in SSLEngine is broken for any protocols lesser than TLSv1.2

Sounds fine, thank you Xuelei. Would this later be backported to Java 9 too? -Jaikiran On 24/02/18 12:21 AM, Xuelei Fan wrote: Hi Jaikiran, Thanks a lot for the update.  Your code looks fine to me. As we are working on the re-org of the implementation[1] now, I may integrate your

Re: RFR 8197518: Kerberos krb5 authentication: AuthList's put method leads to performance issue

Updated at http://cr.openjdk.java.net/~weijun/8197518/webrev.02/. 1. ConcurrentHashMap used in MemoryCache. No more "content.remove(key)" but it's actually useless because rc.isEmpty() will not be true normally. I'll think about how to clean up unused AuthList objects in another RFE. 2.

Re: RFR 8181594: Efficient and constant-time modular arithmetic

ArrayUtil.java: === I'm not very sure how widely this utilities will be used in the future. Looks like only BigIntegerModuloP uses this classes. I may prefer to define private methods for byte array swap in BigIntegerModuloP. BigIntegerModuloP.java: === As

Re: Update mechanism for the upcoming trust store

Hello Sean, On 29/01/2018 04:30 μμ, Fotis Loukos wrote: > On 26/01/2018 11:31 μμ, Sean Mullan wrote: >> On 1/24/18 5:39 AM, Fotis Loukos wrote: You may not be aware, but the JDK does currently support a mechanism for blacklisting certificates. The lib/security/blacklisted.certs file

Re: RFR 8197518: Kerberos krb5 authentication: AuthList's put method leads to performance issue

Looks fine to me. Xuelei On 2/23/2018 6:13 AM, Weijun Wang wrote: Updated at http://cr.openjdk.java.net/~weijun/8197518/webrev.02/. 1. ConcurrentHashMap used in MemoryCache. No more "content.remove(key)" but it's actually useless because rc.isEmpty() will not be true normally. I'll think

Re: RFR 8197518: Kerberos krb5 authentication: AuthList's put method leads to performance issue

Hi Max, 85 // has larger timestamp. 86 entries.addFirst(t); shouldn't you set oldestTime here as well? best regards, -- daniel On 23/02/2018 15:21, Xuelei Fan wrote: Looks fine to me. Xuelei On 2/23/2018 6:13 AM, Weijun Wang wrote: Updated at

Re: [PATCH] JDK-8190917 : SSL session resumption, through handshake, in SSLEngine is broken for any protocols lesser than TLSv1.2

Hi Jaikiran, Thanks a lot for the update. Your code looks fine to me. As we are working on the re-org of the implementation[1] now, I may integrate your contribution shortly after the re-org changes. Thanks, Xuelei [1]:

RFR 8198645 Use System.lineSeparator() instead of getProperty("line.separator")

Please review cleanup replacements of System.getProperty("line.separator") with System.lineSeparator(). It uses the line separator from System instead of looking it up in the properties each time. Also fixed one javadoc @see reference. The affected files are in several packages:

Re: RFR 8198645 Use System.lineSeparator() instead of getProperty("line.separator")

Looks good Roger > On Feb 23, 2018, at 2:39 PM, Roger Riggs wrote: > > Please review cleanup replacements of System.getProperty("line.separator") > with System.lineSeparator(). > It uses the line separator from System instead of looking it up in the > properties each

Re: RFR: 8193892: Impact of noncloneable MessageDigest implementation

Minor comments. I'm ok with leaving as is, but this seems cleaner. MyProvider.java --- Would prefer to use the non-deprecated super call. *Digest.java Would you consider making these 3 duplicate classes into a single class, with the three public derived classes