Re: RFR 8200152: KerberosString should use UTF-8 by default

2018-04-09 Thread Weijun Wang
Thanks. Can you also review the release note at https://bugs.openjdk.java.net/browse/JDK-8201351? > On Apr 8, 2018, at 11:38 AM, Xuelei Fan wrote: > > I added myself as reviewer of the CSR. > > Xuelei > > On 4/7/2018 8:30 PM, Weijun Wang wrote: >> This is more natural.

Re: RFR 8200152: KerberosString should use UTF-8 by default

2018-04-09 Thread Xuelei Fan
I may use a title/subject that states the new state or behavior changes of a RFE. For example, "Uses UTF-8 for KerberosString". Otherwise, looks fine to me. Xuelei On 4/9/2018 7:58 PM, Weijun Wang wrote: Thanks. Can you also review the release note at

Re: RFR 8200152: KerberosString should use UTF-8 by default

2018-04-09 Thread Roger Riggs
Never mind, the latest webrev is great! On 4/9/2018 9:03 AM, Roger Riggs wrote: Hi, I've seen a variety of interpretations of non-standard input for parsing booleans and it is likely to cause confusion across properties. I'd prefer that we converge on the interpretation used in the

Re: RFR 8200152: KerberosString should use UTF-8 by default

2018-04-09 Thread Roger Riggs
Hi, I've seen a variety of interpretations of non-standard input for parsing booleans and it is likely to cause confusion across properties. I'd prefer that we converge on the interpretation used in the Boolean.parseBoolean. Which uses:  "true".equalsIgnoreCase(s); Better yet, call