Re: RFR: ChaCha20 and ChaCha20/Poly1305 Cipher implementations

2018-05-01 Thread Sean Mullan
On 4/27/18 5:21 PM, Jamil Nimeh wrote: Round 4 of updates for ChaCha20 and ChaCha20-Poly1305, minor stuff mostly: * Added words in the description of javax.crypto.Cipher recommending callers reinitialize the Cipher to use different nonces after each complete encryption or decryption

Re: RFR: ChaCha20 and ChaCha20/Poly1305 Cipher implementations

2018-05-01 Thread Sean Mullan
On 5/1/18 1:20 PM, Sean Mullan wrote: On 4/27/18 5:21 PM, Jamil Nimeh wrote: Round 4 of updates for ChaCha20 and ChaCha20-Poly1305, minor stuff mostly:   * Added words in the description of javax.crypto.Cipher recommending     callers reinitialize the Cipher to use different nonces after each

Re: RFR: ChaCha20 and ChaCha20/Poly1305 Cipher implementations

2018-05-01 Thread Jamil Nimeh
Hi Sean, many thanks for taking a detailed look at the code.  My comments are in-line On 5/1/2018 1:53 PM, Sean Mullan wrote: On 5/1/18 1:20 PM, Sean Mullan wrote: On 4/27/18 5:21 PM, Jamil Nimeh wrote: Round 4 of updates for ChaCha20 and ChaCha20-Poly1305, minor stuff mostly:   * Added

Re: RFR: ChaCha20 and ChaCha20/Poly1305 Cipher implementations

2018-05-01 Thread Jamil Nimeh
Comments in-line: On 5/1/2018 10:20 AM, Sean Mullan wrote: On 4/27/18 5:21 PM, Jamil Nimeh wrote: Round 4 of updates for ChaCha20 and ChaCha20-Poly1305, minor stuff mostly:   * Added words in the description of javax.crypto.Cipher recommending     callers reinitialize the Cipher to use

Re: RFR: ChaCha20 and ChaCha20/Poly1305 Cipher implementations

2018-05-01 Thread Jamil Nimeh
Update: forget my comment on this finding, Sean.  I'm already wrapping IOE in IAPE when IOE gets thrown so it's better to go the route you suggested.  I didn't read the method carefully enough.  375 if (dv.tag == DerValue.tag_OctetString) {  376   

Re: RFR[11] JDK-8146293 "Add Support for RSA-PSS Signature Algorithm as in PKCS#1 v2.2"

2018-05-01 Thread Valerie Peng
Hi Brad, Thanks for the review. Please find comments in line. I adopted most if not all of your comments. I have incorporated your comments into the webrev but I am still not done with it yet due to name switch from RSA-PSS to RSASSA-PSS. Will send out another email once webrev is updated.

RFR 8202086 : Improve performance characteristics of sun.security.util.MemoryCache

2018-05-01 Thread Ivan Gerasimov
Hello! This enhancement was generously contributed by Peter Levart [1]. The original webrev is found here [2]. The goal was to improve concurrent accessibility of the cache, while maintaining some additional limitations dictated by the spec. Would you please help review this fix? BUGURL:

Re: [8u-dev] 8193171 : keytool -list displays "JKS" for a PKCS12 keystore

2018-05-01 Thread Seán Coffey
Looks fine to me. regards, Sean. On 30/04/2018 20:16, Ivan Gerasimov wrote: Hello! This is 8u-dev only bug fix. It was noticed that the keytool from the latest JDK 8 update release displays type of PKCS12 keystore as JKS. Would you please help review the patch? BUGURL:

JEP Proposal: EdDSA Signatures

2018-05-01 Thread Adam Petcher
The work for X25519/X448 is wrapping up[1], so I have started thinking about EdDSA. Please review the draft JEP[2] for EdDSA, and let me know what you think. I'm not really sure what priority to give the EdDSA work, and it is optional in TLS 1.3. So if you have a particular need or desire for