Re: RFR 8212217: JGSS: Don't dispose() of creds too eagerly

I think you should put braces around the conditional statements on lines 332, 357, & 359. It would read better and avoid accidental bugs. Where does delegatedCred get used? It seems to be never set. Otherwise looks fine. You will need to add a noreg label if you can't write a test. --Sean

Re: [RFR] JDK-8213154: Update copyright headers of files in src tree that are missing Classpath exception

On 30/10/2018 17:44, Martin Balao wrote: Hi, Can I have a review for JDK-8213154 [1]?  * http://cr.openjdk.java.net/~mbalao/webrevs/8213154/8213154.webrev.00/  *

Re: [RFR] JDK-8213154: Update copyright headers of files in src tree that are missing Classpath exception

Hi, You're right, this is not relevant for a test. * http://cr.openjdk.java.net/~mbalao/webrevs/8213154/8213154.webrev.01 * http://cr.openjdk.java.net/~mbalao/webrevs/8213154/8213154.webrev.01.zip Thanks, Martin.- On Tue, Oct 30, 2018 at 2:50 PM, Alan Bateman wrote: > On 30/10/2018 17:44,

[RFR] JDK-8213154: Update copyright headers of files in src tree that are missing Classpath exception

Hi, Can I have a review for JDK-8213154 [1]? * http://cr.openjdk.java.net/~mbalao/webrevs/8213154/8213154.webrev.00/ * http://cr.openjdk.java.net/~mbalao/webrevs/8213154/8213154.webrev.00.zip Thanks, Martin.- -- [1] - https://bugs.openjdk.java.net/browse/JDK-8213154

RFR: 8207059: Update test certificates in QuoVadisCA.java test

Please review this fix to update test certificates used in QuoVadis CA tests. Webrev: http://cr.openjdk.java.net/~rhalade/8207059/webrev.00/ Thanks, Rajan

A new proposal to add methods to HttpsURLConnection to access SSLSession

Hi, For the current HttpsURLConnection, there is not much security parameters exposed in the public APIs. An application may need richer information for the underlying TLS connections, for example the negotiated TLS protocol version. Please let me know if you have concerns to add a new