RFR: 8282600: SSLSocketImpl should not use user_canceled workaround when not necessary

2022-03-03 Thread zzambers
When testing compatibility of jdk TLS implementation with gnutls, I have found a problem. The problem is, that gnutls does not like use of user_canceled alert when closing TLS-1.3 connection from duplexCloseOutput() (used by socket.close() unless shutdownOutput was called explicitly) and

Re: RFR: 8282600: SSLSocketImpl should not use user_canceled workaround when not necessary

2022-03-03 Thread Severin Gehwolf
On Wed, 2 Mar 2022 19:04:26 GMT, zzambers wrote: > When testing compatibility of jdk TLS implementation with gnutls, I have > found a problem. The problem is, that gnutls does not like use of > user_canceled alert when closing TLS-1.3 connection from duplexCloseOutput() > (used by

Re: RFR: 8282529: Fix API Note in javadoc for javax.net.ssl.SSLSocket [v2]

2022-03-03 Thread zzambers
> Fixed API Note in javadoc for javax.net.ssl.SSLSocket class. API Note was > introduced by JDK-8208526 [1]. At that point both Socket.shutdownInput() / > Socket.shutdownOutput() and InputStream.close() / OutputStream.close() > performed half-close of TLS-1.3 connection. However this behaviour

Re: RFR: 8282600: SSLSocketImpl should not use user_canceled workaround when not necessary

2022-03-03 Thread zzambers
On Thu, 3 Mar 2022 10:45:02 GMT, Severin Gehwolf wrote: >> When testing compatibility of jdk TLS implementation with gnutls, I have >> found a problem. The problem is, that gnutls does not like use of >> user_canceled alert when closing TLS-1.3 connection from duplexCloseOutput() >> (used by

Re: RFR: 8282529: Fix API Note in javadoc for javax.net.ssl.SSLSocket

2022-03-03 Thread Julian Waters
On Tue, 1 Mar 2022 17:09:57 GMT, zzambers wrote: > Fixed API Note in javadoc for javax.net.ssl.SSLSocket class. API Note was > introduced by JDK-8208526 [1]. At that point both Socket.shutdownInput() / > Socket.shutdownOutput() and InputStream.close() / OutputStream.close() > performed

Re: RFR: 8282600: SSLSocketImpl should not use user_canceled workaround when not necessary

2022-03-03 Thread zzambers
On Thu, 3 Mar 2022 15:40:31 GMT, Xue-Lei Andrew Fan wrote: >> When testing compatibility of jdk TLS implementation with gnutls, I have >> found a problem. The problem is, that gnutls does not like use of >> user_canceled alert when closing TLS-1.3 connection from duplexCloseOutput() >> (used

Re: RFR: 8282511: Use fixed certificate validation date in SSLExampleCert template [v2]

2022-03-03 Thread Xue-Lei Andrew Fan
On Tue, 1 Mar 2022 23:25:52 GMT, Rajan Halade wrote: >> Xue-Lei Andrew Fan has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Chaneg to use DateFormat > > test/jdk/javax/net/ssl/ServerName/EndingDotHostname.java line 26: > >> 24: /** >>

Re: RFR: 8282511: Use fixed certificate validation date in SSLExampleCert template [v3]

2022-03-03 Thread Rajan Halade
On Thu, 3 Mar 2022 16:31:41 GMT, Xue-Lei Andrew Fan wrote: >> May I have this test update reviewed? >> >> The certificates used in SSL testing template SSLExampleCert could expired >> in the future (for example >> [JDK-8282398](https://bugs.openjdk.java.net/browse/JDK-8282398)). It is not

Re: RFR: 8282600: SSLSocketImpl should not use user_canceled workaround when not necessary

2022-03-03 Thread Xue-Lei Andrew Fan
On Wed, 2 Mar 2022 19:04:26 GMT, zzambers wrote: > When testing compatibility of jdk TLS implementation with gnutls, I have > found a problem. The problem is, that gnutls does not like use of > user_canceled alert when closing TLS-1.3 connection from duplexCloseOutput() > (used by

Re: RFR: 8282511: Use fixed certificate validation date in SSLExampleCert template [v3]

2022-03-03 Thread Xue-Lei Andrew Fan
> May I have this test update reviewed? > > The certificates used in SSL testing template SSLExampleCert could expired in > the future (for example > [JDK-8282398](https://bugs.openjdk.java.net/browse/JDK-8282398)). It is not > always easy to replace the certificates if the template has been

Re: RFR: 8277474: jarsigner does not check if algorithm parameters are disabled [v5]

2022-03-03 Thread Hai-May Chao
> This fixes jarsigner to enforce checking against algorithm constraint > properties so when the signature algorithms parameters use disabled or legacy > algorithms, it will emit warnings accordingly. If the algorithm used in > parameters is disabled, jarsigner treats the jar as unsigned.

Re: RFR: 8277474: jarsigner does not check if algorithm parameters are disabled [v4]

2022-03-03 Thread Hai-May Chao
On Thu, 3 Mar 2022 19:35:21 GMT, Weijun Wang wrote: >> Hai-May Chao has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Removed unused string > > src/jdk.jartool/share/classes/sun/security/tools/jarsigner/Main.java line > 1418: > >> 1416:

Re: RFR: 8277474: jarsigner does not check if algorithm parameters are disabled [v6]

2022-03-03 Thread Hai-May Chao
> This fixes jarsigner to enforce checking against algorithm constraint > properties so when the signature algorithms parameters use disabled or legacy > algorithms, it will emit warnings accordingly. If the algorithm used in > parameters is disabled, jarsigner treats the jar as unsigned.

Re: RFR: 8277474: jarsigner does not check if algorithm parameters are disabled [v4]

2022-03-03 Thread Weijun Wang
On Thu, 3 Mar 2022 07:24:49 GMT, Hai-May Chao wrote: >> This fixes jarsigner to enforce checking against algorithm constraint >> properties so when the signature algorithms parameters use disabled or >> legacy algorithms, it will emit warnings accordingly. If the algorithm used >> in

RFR: 8282632: Cleanup unnecessary calls to Throwable.initCause() in java.security.jgss

2022-03-03 Thread Andrey Turbanov
Pass cause exception as constructor parameter is shorter and easier to read. - Commit messages: - [PATCH] Cleanup unnecessary calls to Throwable.initCause() in java.security.jgss Changes: https://git.openjdk.java.net/jdk/pull/7682/files Webrev:

Re: RFR: 8267319: Use larger default key sizes and algorithms based on CNSA

2022-03-03 Thread Anthony Scarpino
On Wed, 2 Mar 2022 00:13:41 GMT, Valerie Peng wrote: > It's been several years since we increased the default key sizes. Before > shifting to PQC, NSA replaced its Suite B cryptography recommendations with > the Commercial National Security Algorithm Suite which suggests: > > - SHA-384 for

Integrated: 8282511: Use fixed certificate validation date in SSLExampleCert template

2022-03-03 Thread Xue-Lei Andrew Fan
On Tue, 1 Mar 2022 22:38:30 GMT, Xue-Lei Andrew Fan wrote: > May I have this test update reviewed? > > The certificates used in SSL testing template SSLExampleCert could expired in > the future (for example > [JDK-8282398](https://bugs.openjdk.java.net/browse/JDK-8282398)). It is not >

Re: RFR: 8277474: jarsigner does not check if algorithm parameters are disabled [v6]

2022-03-03 Thread Weijun Wang
On Thu, 3 Mar 2022 22:18:53 GMT, Hai-May Chao wrote: >> This fixes jarsigner to enforce checking against algorithm constraint >> properties so when the signature algorithms parameters use disabled or >> legacy algorithms, it will emit warnings accordingly. If the algorithm used >> in

Integrated: 8277474: jarsigner does not check if algorithm parameters are disabled

2022-03-03 Thread Hai-May Chao
On Tue, 22 Feb 2022 22:00:05 GMT, Hai-May Chao wrote: > This fixes jarsigner to enforce checking against algorithm constraint > properties so when the signature algorithms parameters use disabled or legacy > algorithms, it will emit warnings accordingly. If the algorithm used in > parameters