[security-dev 00398]: hg: jdk7/tl/jdk: 2 new changesets

2008-11-11 Thread alan . bateman
Changeset: 275fa248e808 Author:alanb Date: 2008-11-11 08:59 + URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/275fa248e808 6763122: ZipFile ctor does not throw exception when file is not a zip file Reviewed-by: bristor ! src/share/native/java/util/zip/zip_util.c !

[security-dev 00432]: hg: jdk7/tl/jdk: 6593946: (bf) X-Buffer.compact() does not discard mark as specified

2008-11-25 Thread alan . bateman
Changeset: b7c47f49a53d Author:alanb Date: 2008-11-25 19:26 + URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/b7c47f49a53d 6593946: (bf) X-Buffer.compact() does not discard mark as specified Summary: InvalidMarkException now correctly thrown. Thanks to [EMAIL PROTECTED] for

[security-dev 00482]: hg: jdk7/tl/jdk: 6787009: (attach) Stub injection potentially unsafe on windows-x64

2008-12-23 Thread alan . bateman
Changeset: 3d09cc6c4ea9 Author:alanb Date: 2008-12-22 19:28 + URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/3d09cc6c4ea9 6787009: (attach) Stub injection potentially unsafe on windows-x64 Reviewed-by: mchung ! src/windows/native/sun/tools/attach/WindowsVirtualMachine.c

[security-dev 00725]: hg: jdk7/tl/jdk: 3 new changesets

2009-03-30 Thread alan . bateman
Changeset: 7264cacbddaa Author:alanb Date: 2009-03-27 15:24 + URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/7264cacbddaa 6693490: (se) select throws File exists IOException under load (lnx) Reviewed-by: sherman ! src/share/classes/sun/nio/ch/SelChImpl.java !

[security-dev 00759]: hg: jdk7/tl/jdk: 3 new changesets

2009-04-17 Thread alan . bateman
Changeset: 0b3660c68262 Author:alanb Date: 2009-04-15 14:53 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/0b3660c68262 6795561: (bf) CharBuffer.subSequence() uses wrong capacity value for new buffer Reviewed-by: sherman, iris !

[security-dev 00772]: hg: jdk7/tl/jdk: 6830721: (fc) test/java/nio/channels/AsynchronousFileChannel/Basic.java intermittent failure

2009-04-20 Thread alan . bateman
Changeset: ccd08d4b19cf Author:alanb Date: 2009-04-20 09:30 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/ccd08d4b19cf 6830721: (fc) test/java/nio/channels/AsynchronousFileChannel/Basic.java intermittent failure Reviewed-by: sherman !

[security-dev 00773]: hg: jdk7/tl/jdk: 6831461: (sample) Copy -r fails with IllegalArgumentexception: 'maxDepth' is negative

2009-04-20 Thread alan . bateman
Changeset: e281812be4ce Author:alanb Date: 2009-04-20 13:27 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/e281812be4ce 6831461: (sample) Copy -r fails with IllegalArgumentexception: 'maxDepth' is negative Reviewed-by: chegar ! src/share/sample/nio/file/Copy.java

[security-dev 00790]: hg: jdk7/tl/jdk: 6834246: (ch) AsynchronousSocketChannel#write completes with wrong number of bytes written under load (win)

2009-05-04 Thread alan . bateman
Changeset: e1a713f0361f Author:alanb Date: 2009-05-04 19:25 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/e1a713f0361f 6834246: (ch) AsynchronousSocketChannel#write completes with wrong number of bytes written under load (win) Reviewed-by: sherman !

[security-dev 00934]: hg: jdk7/tl/jdk: 2 new changesets

2009-06-28 Thread alan . bateman
Changeset: 5208d0c90d73 Author:alanb Date: 2009-06-27 21:46 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/5208d0c90d73 6838333: New I/O: Update file system API to jsr203/nio2-b101 6844313: New I/O: File timestamps should be represented by a FileTime rather than a

[security-dev 00943]: hg: jdk7/tl/jdk: 2 new changesets

2009-06-30 Thread alan . bateman
Changeset: b22f9e823be7 Author:alanb Date: 2009-06-30 11:11 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/b22f9e823be7 6843003: Windows Server 2008 R2 system recognition Reviewed-by: ohair, sherman ! src/windows/native/java/lang/java_props_md.c Changeset: d57c10cf07c5

[security-dev 01033]: hg: jdk7/tl/jdk: 3 new changesets

2009-07-31 Thread alan . bateman
Changeset: e2d9696aa701 Author:alanb Date: 2009-07-31 08:44 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/e2d9696aa701 6867101: Path.checkAccess fails with sharing violation on special files such as pagefile.sys Reviewed-by: sherman !

[security-dev 01101]: hg: jdk7/tl/jdk: 3 new changesets

2009-08-20 Thread alan . bateman
Changeset: dfece53c600f Author:alanb Date: 2009-08-20 08:39 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/dfece53c600f 6595866: File does work with symbolic links (win,vista) Reviewed-by: sherman ! src/windows/native/java/io/WinNTFileSystem_md.c +

[security-dev 01111]: hg: jdk7/tl/jdk: 3 new changesets

2009-08-23 Thread alan . bateman
Changeset: 99a55f6f1cef Author:alanb Date: 2009-08-22 17:40 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/99a55f6f1cef 6874521: Remove @note tags Reviewed-by: andrew, darcy ! src/share/classes/java/nio/channels/Channels.java !

[security-dev 01176]: hg: jdk7/tl/jdk: 4 new changesets

2009-09-05 Thread alan . bateman
Changeset: 3f87b755b1c8 Author:alanb Date: 2009-09-04 18:15 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/3f87b755b1c8 6873621: (file) FileStore.supportsFileAttributeView(ClassFileAttributeView type) returns wrong result Reviewed-by: andrew !

[security-dev 01204]: hg: jdk7/tl/jdk: 2 new changesets

2009-09-14 Thread alan . bateman
Changeset: 060c4c7082ef Author:alanb Date: 2009-09-14 15:29 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/060c4c7082ef 6529758: JVMTI Waiters demo crashes. Double free. Reviewed-by: ohair, tbell ! src/share/demo/jvmti/waiters/Agent.cpp !

[security-dev 01216]: Re: AWT Dev 6854954: Eliminate static dependency on java.awt.AWTPermission

2009-09-16 Thread Alan Bateman
Anthony Petrov wrote: Hi Alan, To contribute a little to the small nit picking process :) : 1. src/share/classes/javax/swing/JPopupMenu.java Line 415 might be realigned to keep standard indentation. 2. The copyright notices might be updated to indicate that 2009 is the year of last

[security-dev 01309]: hg: jdk7/tl/jdk: 3 new changesets

2009-10-15 Thread alan . bateman
Changeset: f6833a276c1d Author:alanb Date: 2009-10-15 11:54 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/f6833a276c1d 6883983: JarVerifier dependency on sun.security.pkcs should be removed Reviewed-by: sherman, wetmore ! src/share/classes/java/util/jar/JarVerifier.java

[security-dev 01343]: hg: jdk7/tl/jdk: 6888179: Separate out dependency on CORBA

2009-10-27 Thread alan . bateman
Changeset: 244a6868b440 Author:alanb Date: 2009-10-27 08:55 + URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/244a6868b440 6888179: Separate out dependency on CORBA Reviewed-by: dfuchs + src/share/classes/com/sun/jmx/remote/internal/IIOPHelper.java +

[security-dev 01345]: hg: jdk7/tl/jdk: 6880672: Replace quicksort in java.util.Arrays with dual-pivot implementation

2009-10-29 Thread alan . bateman
Changeset: b05abb410c52 Author:alanb Date: 2009-10-29 11:18 + URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/b05abb410c52 6880672: Replace quicksort in java.util.Arrays with dual-pivot implementation Reviewed-by: jjb Contributed-by: vladimir.yaroslavs...@sun.com,

[security-dev 01349]: hg: jdk7/tl/jdk: 6896573: Arrays.sort(long[]) fails with StackOverflowError

2009-10-30 Thread alan . bateman
Changeset: 84ae559f7129 Author:alanb Date: 2009-10-30 15:06 + URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/84ae559f7129 6896573: Arrays.sort(long[]) fails with StackOverflowError Reviewed-by: jjb Contributed-by: vladimir.yaroslavs...@sun.com !

[security-dev 01353]: hg: jdk7/tl/jdk: 6896829: test/sun/util/logging/PlatformLoggerTest.java needs @compile tag to be compiled by jtreg

2009-10-30 Thread alan . bateman
Changeset: fe9db22a220f Author:alanb Date: 2009-10-30 21:31 + URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/fe9db22a220f 6896829: test/sun/util/logging/PlatformLoggerTest.java needs @compile tag to be compiled by jtreg Reviewed-by: mchung, tbell !

[security-dev 01358]: Re: 6894643: Separate out dependency on Kerberos

2009-11-02 Thread Alan Bateman
Vincent Ryan wrote: Hello all, I'm proposing a further change that enables JSSE to work when Kerberos is not present at runtime: http://cr.openjdk.java.net/~vinnie/6894643/webrev.00/ (This continues the removal of static dependencies begun in CR 6885204.) Please comment. Thanks. This

[security-dev 01378]: hg: jdk7/tl/jdk: 2 new changesets

2009-11-10 Thread alan . bateman
Changeset: ee7a380d350e Author:alanb Date: 2009-11-10 10:51 + URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/ee7a380d350e 6898234: (dc) Multicast tests fail on OpenSolaris with vboxnet0 adapter Reviewed-by: chegar ! test/ProblemList.txt !

[security-dev 01379]: hg: jdk7/tl/jdk: 6899694: Dual-pivot quicksort improvements

2009-11-11 Thread alan . bateman
Changeset: 18c2b761548a Author:alanb Date: 2009-11-11 14:38 + URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/18c2b761548a 6899694: Dual-pivot quicksort improvements Reviewed-by: jjb Contributed-by: vladimir.yaroslavs...@sun.com, joshua.bl...@google.com !

[security-dev 01382]: hg: jdk7/tl/jdk: 2 new changesets

2009-11-12 Thread alan . bateman
Changeset: b901762bba4b Author:alanb Date: 2009-11-11 16:22 + URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/b901762bba4b 6900234: Several NIO tests should be removed from test/ProblemList.txt Reviewed-by: chegar ! test/ProblemList.txt !

[security-dev 01386]: hg: jdk7/tl/jdk: 6901318: Yet more Dual-pivot quicksort improvements

2009-11-17 Thread alan . bateman
Changeset: 9afe87deb51b Author:alanb Date: 2009-11-17 09:44 + URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/9afe87deb51b 6901318: Yet more Dual-pivot quicksort improvements Reviewed-by: jjb Contributed-by: vladimir.yaroslavs...@sun.com !

[security-dev 01405]: hg: jdk7/tl/jdk: 6888171: JMX Monitor API should not require JavaBeans to be present

2009-11-23 Thread alan . bateman
Changeset: 1ced99075109 Author:alanb Date: 2009-11-23 19:26 + URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/1ced99075109 6888171: JMX Monitor API should not require JavaBeans to be present Reviewed-by: emcmanus ! src/share/classes/com/sun/jmx/mbeanserver/Introspector.java !

[security-dev 01440]: hg: jdk7/tl/jdk: 3 new changesets

2009-12-07 Thread alan . bateman
Changeset: c68f6b6b47fd Author:alanb Date: 2009-12-07 12:24 + URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/c68f6b6b47fd 6903753: (se) Selector should implement Closeable Reviewed-by: chegar, forax ! src/share/classes/java/nio/channels/Selector.java Changeset: 587fa61c0f07

[security-dev 01446]: hg: jdk7/tl/jdk: 6905046: More Dual-pivot quicksort improvements

2009-12-08 Thread alan . bateman
Changeset: 146c8921267f Author:jjb Date: 2009-12-08 12:40 + URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/146c8921267f 6905046: More Dual-pivot quicksort improvements Summary: More improvements from the DPQ team Reviewed-by: alanb !

[security-dev 01504]: hg: jdk7/tl/jdk: 2 new changesets

2010-01-10 Thread alan . bateman
Changeset: 755dd6bdccca Author:alanb Date: 2010-01-09 19:32 + URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/755dd6bdccca 6907760: (file) OVERFLOW event should cause pending events to be purged Reviewed-by: chegar ! src/share/classes/sun/nio/fs/AbstractWatchKey.java +

[security-dev 01527]: Re: Please review changes in regression test test/java/security/Provider/Turkish.java

2010-01-18 Thread Alan Bateman
Pavel Tisnovsky wrote: Hi, please review changes in regression test jtest/java/security/Provider/Turkish.java. Webrev is available at http://cr.openjdk.java.net/~ptisnovs/Turkish/ We already discussed similar issue on jdk6-dev mailing list, concretely in this thread:

[security-dev 01531]: hg: jdk7/tl/jdk: 6917021: (file) copyTo/moveTo can overrwrite existing file when target associated with custom provider

2010-01-18 Thread alan . bateman
Changeset: 42894ae6671c Author:alanb Date: 2010-01-18 15:21 + URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/42894ae6671c 6917021: (file) copyTo/moveTo can overrwrite existing file when target associated with custom provider Reviewed-by: chegar !

[security-dev 01636]: hg: jdk7/tl/jdk: 4 new changesets

2010-02-24 Thread alan . bateman
Changeset: 38fbb2353a6a Author:alanb Date: 2010-02-23 17:56 + URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/38fbb2353a6a 6925977: (file) test/java/nio/file/Path/CheckPermissions.java fails if test.src on read-only file system Reviewed-by: chegar !

[security-dev 01649]: hg: jdk7/tl/jdk: 6929259: Remove double spaces from Dual-pivot quicksort

2010-02-27 Thread alan . bateman
Changeset: b77e94f5a601 Author:alanb Date: 2010-02-27 19:15 + URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/b77e94f5a601 6929259: Remove double spaces from Dual-pivot quicksort Reviewed-by: alanb Contributed-by: vladimir.yaroslavs...@sun.com !

[security-dev 01664]: hg: jdk7/tl/jdk: 6931216: TEST_BUG: test/java/nio/file/WatchService/LotsOfEvents.java failed with NPE

2010-03-03 Thread alan . bateman
Changeset: cddb43b12d28 Author:alanb Date: 2010-03-03 16:09 + URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/cddb43b12d28 6931216: TEST_BUG: test/java/nio/file/WatchService/LotsOfEvents.java failed with NPE Reviewed-by: chegar !

[security-dev 01697]: Re: Please review new regression test for java.net.* API

2010-03-18 Thread Alan Bateman
Christopher Hegarty -Sun Microsystems Ireland wrote: : Alan is correct there are already tests for SSL/Https in javax.net, but I believe these use self signed certs, no dependency on cacerts. OK, in that case adding a new test make sense. The test/java/net tree is probably not the best place

hg: jdk7/tl/jdk: 2 new changesets

2010-06-02 Thread alan . bateman
Changeset: 17870c6c1d4e Author:alanb Date: 2010-06-02 09:29 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/17870c6c1d4e 6950927: Testcase failure sun/management/jmxremote/bootstrap/JvmstatCountersTest.java Reviewed-by: dholmes, dcubed !

hg: jdk7/tl/jdk: 3 new changesets

2010-06-15 Thread alan . bateman
Changeset: 72022d7d4578 Author:alanb Date: 2010-06-15 16:36 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/72022d7d4578 6932744: TEST_BUG: java/nio/channels/Selector/OpRead.java failing Reviewed-by: chegar ! test/ProblemList.txt ! test/java/nio/channels/Selector/OpRead.java

hg: jdk7/tl/jdk: 6961630: TEST_BUG: Several SocketChannel and Selector tests can fail with address already in use

2010-06-16 Thread alan . bateman
Changeset: 8a4557c5dfa1 Author:alanb Date: 2010-06-16 14:24 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/8a4557c5dfa1 6961630: TEST_BUG: Several SocketChannel and Selector tests can fail with address already in use Reviewed-by: chegar ! test/ProblemList.txt !

hg: jdk7/tl/jdk: 6395224: (so) SocketChannel writer blocked on large buffer is not preempted by close method (vista)

2010-06-17 Thread alan . bateman
Changeset: 1281181df71b Author:alanb Date: 2010-06-17 17:49 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/1281181df71b 6395224: (so) SocketChannel writer blocked on large buffer is not preempted by close method (vista) Reviewed-by: chegar !

hg: jdk7/tl/jdk: 4981129: (dc) DatagramSocket created by DatagramChannel does not provide sender info

2010-06-18 Thread alan . bateman
Changeset: 6c188df7bfef Author:alanb Date: 2010-06-18 16:16 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/6c188df7bfef 4981129: (dc) DatagramSocket created by DatagramChannel does not provide sender info Reviewed-by: chegar !

hg: jdk7/tl/jdk: 2 new changesets

2010-06-23 Thread alan . bateman
Changeset: eb84b89ef3ff Author:alanb Date: 2010-06-23 20:19 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/eb84b89ef3ff 6963027: TEST_BUG: channels and buffer tests need to run in samevm mode Reviewed-by: ohair, sherman, chegar ! test/Makefile ! test/ProblemList.txt !

hg: jdk7/tl/jdk: 6947216: Even more Dual-pivot quicksort improvements

2010-07-01 Thread alan . bateman
Changeset: a5a34c696d62 Author:alanb Date: 2010-07-01 16:28 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/a5a34c696d62 6947216: Even more Dual-pivot quicksort improvements Reviewed-by: jjb Contributed-by: vladimir.yaroslavs...@sun.com !

Re: code review request: 6969292: make DNS lookup for realm/kdc really work

2010-07-17 Thread Alan Bateman
Valerie (Yu-Ching) Peng wrote: Looks fine except the following minor nit: - Why not return realm on line 1224 after a match is found? Doesn't seem necessary to continue w/ the whole for-loop. Indeed, looks like it is missing a break. -Alan.

hg: jdk7/tl/jdk: 6963907: (so) Socket adapter need to implement sendUrgentData

2010-07-21 Thread alan . bateman
Changeset: 3902c742b5b1 Author:alanb Date: 2010-07-21 18:08 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/3902c742b5b1 6963907: (so) Socket adapter need to implement sendUrgentData Reviewed-by: chegar ! make/java/nio/mapfile-linux ! make/java/nio/mapfile-solaris !

hg: jdk7/tl/jdk: 6971825: (so) improve scatter/gather implementation

2010-08-12 Thread alan . bateman
Changeset: 11ee8b471f9c Author:alanb Date: 2010-08-12 19:53 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/11ee8b471f9c 6971825: (so) improve scatter/gather implementation Reviewed-by: chegar, sherman ! src/share/classes/sun/nio/ch/DatagramChannelImpl.java !

hg: jdk7/tl/jdk: 2 new changesets

2010-08-23 Thread alan . bateman
Changeset: 47ab0dcec3e8 Author:alanb Date: 2010-08-23 17:11 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/47ab0dcec3e8 6978511: (file) Path.toRealPath should fail if not resolving links and file does not exist Reviewed-by: forax, chegar !

hg: jdk7/tl/jdk: 3 new changesets

2010-09-10 Thread alan . bateman
Changeset: 55eb9f25bf7a Author:alanb Date: 2010-09-10 16:36 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/55eb9f25bf7a 6881498: (file) Re-examine DirectoryStream exception handling Reviewed-by: forax ! make/java/nio/FILES_java.gmk +

hg: jdk7/tl/jdk: 6984545: (fc) transferFrom does not throw NonReadableChannelException when target is size 0 and non-readable

2010-09-15 Thread alan . bateman
Changeset: a248eb631aa2 Author:alanb Date: 2010-09-15 15:13 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/a248eb631aa2 6984545: (fc) transferFrom does not throw NonReadableChannelException when target is size 0 and non-readable Reviewed-by: forax !

hg: jdk7/tl/jdk: 2 new changesets

2010-09-30 Thread alan . bateman
Changeset: 04d9b09dbef9 Author:alanb Date: 2010-09-30 14:48 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/04d9b09dbef9 6988037: fileClose prints debug message is close fails Reviewed-by: kevinw, forax ! src/solaris/native/java/io/io_util_md.c !

hg: jdk7/tl/jdk: 2 new changesets

2010-10-02 Thread alan . bateman
Changeset: f439d8b1e84a Author:alanb Date: 2010-10-02 12:59 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/f439d8b1e84a 6979526: (file) java/nio/file/FileStore/Basic.java fails if the same file system is mounted more than once Reviewed-by: kevinw, forax !

hg: jdk7/tl/jdk: 6987116: (so) test/java/nio/channels/SocketChannel/VectorIO.java failed on Solaris 11

2010-10-05 Thread alan . bateman
Changeset: b468b20a98a8 Author:alanb Date: 2010-10-05 15:07 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/b468b20a98a8 6987116: (so) test/java/nio/channels/SocketChannel/VectorIO.java failed on Solaris 11 Reviewed-by: forax !

hg: jdk7/tl/jdk: 2 new changesets

2010-10-08 Thread alan . bateman
Changeset: fd20568bebff Author:alanb Date: 2010-10-08 10:36 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/fd20568bebff 6989116: (verifier) compiler warning messages Reviewed-by: kamg, ohair ! src/share/native/common/check_code.c Changeset: d122e96be7d2 Author:alanb

hg: jdk7/tl/jdk: 6987154: HTML link to serialization guide is broken

2010-10-11 Thread alan . bateman
Changeset: f0888585b6ff Author:alanb Date: 2010-10-11 09:17 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/f0888585b6ff 6987154: HTML link to serialization guide is broken Reviewed-by: skannan ! src/share/classes/java/io/package.html

hg: jdk7/tl/jdk: 6728842: File.setReadOnly does not make a directory read-only (win); ...

2010-10-12 Thread alan . bateman
Changeset: b614af87d00f Author:alanb Date: 2010-10-12 08:49 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/b614af87d00f 6728842: File.setReadOnly does not make a directory read-only (win) 6464744: java/io/File/SetAccess.java ignores sticky bit Reviewed-by: forax !

hg: jdk7/tl/jdk: 6983520: java/io/pathNames/GeneralWin32.java fails with jdk7-b108 (win)

2010-10-12 Thread alan . bateman
Changeset: 1d94b33a8f59 Author:alanb Date: 2010-10-12 09:46 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/1d94b33a8f59 6983520: java/io/pathNames/GeneralWin32.java fails with jdk7-b108 (win) Reviewed-by: sherman ! src/windows/native/java/io/WinNTFileSystem_md.c !

hg: jdk7/tl/jdk: 6976036: Dual-pivot quicksort update (10/2010 tune-up)

2010-10-15 Thread alan . bateman
Changeset: 4cf17a89ead9 Author:alanb Date: 2010-10-15 12:10 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/4cf17a89ead9 6976036: Dual-pivot quicksort update (10/2010 tune-up) Reviewed-by: alanb Contributed-by: vladimir.yaroslavs...@oracle.com !

hg: jdk7/tl/jdk: 6743526: (bf) -XX:MaxDirectMemorySize=size limits memory usage rather than total capacity as intended

2010-10-15 Thread alan . bateman
Changeset: f24699d8c892 Author:alanb Date: 2010-10-15 15:09 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/f24699d8c892 6743526: (bf) -XX:MaxDirectMemorySize=size limits memory usage rather than total capacity as intended Reviewed-by: chegar !

hg: jdk7/tl/jdk: 2 new changesets

2010-10-18 Thread alan . bateman
Changeset: b79600ecf0e4 Author:alanb Date: 2010-10-18 10:29 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/b79600ecf0e4 4837564: (bf) Please make DirectByteBuffer performance enhancements Reviewed-by: chegar ! src/share/classes/java/nio/Direct-X-Buffer.java.template !

hg: jdk7/tl/jdk: 6816049: (bf) MappedByteBuffer.force() method does not flush data correctly

2010-10-22 Thread alan . bateman
Changeset: 3740c2da7cc5 Author:alanb Date: 2010-10-22 17:40 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/3740c2da7cc5 6816049: (bf) MappedByteBuffer.force() method does not flush data correctly Reviewed-by: chegar ! src/share/classes/java/nio/Direct-X-Buffer.java.template

hg: jdk7/tl/corba: 6996740: Yet more breakage caused by 6891766

2010-11-02 Thread alan . bateman
Changeset: 76aeef3afc04 Author:alanb Date: 2010-11-02 18:27 + URL: http://hg.openjdk.java.net/jdk7/tl/corba/rev/76aeef3afc04 6996740: Yet more breakage caused by 6891766 Summary: Restore com.sun.corba.se.simpl.io.IIOPInputStream that 6891766 nuked in error Reviewed-by: asaha

hg: jdk7/tl/jdk: 2 new changesets

2010-11-09 Thread alan . bateman
Changeset: c164d0d59465 Author:alanb Date: 2010-11-09 18:56 + URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/c164d0d59465 6979009: (fc) FileChannel.read() fails to throw ClosedByInterruptException Reviewed-by: forax, sherman, chegar ! src/share/classes/java/lang/Thread.java !

hg: jdk7/tl/jdk: 6613829: (docs) Readable.read() ReadOnlyBufferException is not linked

2010-11-16 Thread alan . bateman
Changeset: 9ec7802cc759 Author:alanb Date: 2010-11-16 15:23 + URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/9ec7802cc759 6613829: (docs) Readable.read() ReadOnlyBufferException is not linked Reviewed-by: chegar, lancea ! src/share/classes/java/lang/Readable.java

hg: jdk7/tl/jdk: 2 new changesets

2010-11-18 Thread alan . bateman
Changeset: 2e0204644cf4 Author:alanb Date: 2010-11-18 19:16 + URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/2e0204644cf4 7000913: (bf) CharBuffer.wrap, slice, position, slice leads to CharBuffer with incorrect offser Reviewed-by: forax !

hg: jdk7/tl/jdk: 6878369: (ch) AsynchronousSocketChannel read/write methods that specify timeouts should not throw IAE

2010-11-24 Thread alan . bateman
Changeset: 4d9e09600175 Author:alanb Date: 2010-11-24 09:51 + URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/4d9e09600175 6878369: (ch) AsynchronousSocketChannel read/write methods that specify timeouts should not throw IAE Reviewed-by: forax !

hg: jdk7/tl/jdk: 2 new changesets

2010-12-01 Thread alan . bateman
Changeset: 374cc848d797 Author:alanb Date: 2010-12-01 13:49 + URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/374cc848d797 6709457: (fc) lock/tryLock() throws IOException Access is denied when file opened for append [win] Reviewed-by: chegar !

hg: jdk7/tl/jdk: 6927816: Demo crash in heaptracker with Non-Sun JDK due to possible violation of JNI spec

2010-12-15 Thread alan . bateman
Changeset: 0ef137ae6f3b Author:alanb Date: 2010-12-15 09:15 + URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/0ef137ae6f3b 6927816: Demo crash in heaptracker with Non-Sun JDK due to possible violation of JNI spec Reviewed-by: ohair, alanb Contributed-by: spo...@uk.ibm.com !

hg: jdk7/tl/jdk: 2 new changesets

2011-01-07 Thread alan . bateman
Changeset: 5124c2a50539 Author:alanb Date: 2011-01-07 15:49 + URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/5124c2a50539 6993732: Remove the HPI Reviewed-by: ohair, lancea, chegar, mduigou, mchung, mr ! make/common/Defs-linux.gmk ! make/common/Defs-solaris.gmk !

Re: code review request for CR 6989705: ECC security code native code compiler warnings

2011-01-21 Thread Alan Bateman
Vincent Ryan wrote: Hello Alan, Please review the following webrev which removes 100's of nuisance compiler warnings generated by our ECC code: http://rialto.ireland.sun.com/~vinnie/webrevs/jdk7/6989705/webrev/ Getting rid of the #pragmas and the other changes look okay to me. The only

hg: jdk7/tl/jdk: 7012663: javadoc warning in javax.swing.JComponent and javax.swing.plaf.synth.SynthTextPaneUI

2011-01-26 Thread alan . bateman
Changeset: bf1b937076db Author:alanb Date: 2011-01-26 18:01 + URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/bf1b937076db 7012663: javadoc warning in javax.swing.JComponent and javax.swing.plaf.synth.SynthTextPaneUI Reviewed-by: alexp !

hg: jdk7/tl/jdk: 2 new changesets

2011-01-28 Thread alan . bateman
Changeset: 236e3f2d0a6b Author:alanb Date: 2011-01-28 09:28 + URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/236e3f2d0a6b 7006126: (fs) Updates to file system API (1/2011) Reviewed-by: chegar, sherman ! make/java/java/FILES_java.gmk ! make/java/nio/FILES_java.gmk !

hg: jdk7/tl/langtools: 2 new changesets

2011-01-28 Thread alan . bateman
Changeset: babf86a1ac92 Author:alanb Date: 2011-01-28 09:25 + URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/babf86a1ac92 7006126: (fs) Updates to file system API (1/2011) Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/nio/JavacPathFileManager.java !

hg: jdk7/tl/jdk: 7015410: test/java/net/Socks/SocksProxyVersion.java needs to be updated due to 7013420

2011-01-28 Thread alan . bateman
Changeset: dea360853f8b Author:alanb Date: 2011-01-28 13:26 + URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/dea360853f8b 7015410: test/java/net/Socks/SocksProxyVersion.java needs to be updated due to 7013420 Reviewed-by: chegar ! test/java/net/Socks/SocksProxyVersion.java

hg: jdk7/tl/jdk: 7014794: (file) lookupPrincipalByGroupName fails to find large NIS groups

2011-02-03 Thread alan . bateman
Changeset: e2a182adb30f Author:alanb Date: 2011-02-03 13:37 + URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/e2a182adb30f 7014794: (file) lookupPrincipalByGroupName fails to find large NIS groups Reviewed-by: chegar ! src/solaris/native/sun/nio/fs/UnixNativeDispatcher.c

hg: jdk7/tl/jdk: 2 new changesets

2011-02-07 Thread alan . bateman
Changeset: f34dcfeecc8d Author:alanb Date: 2011-02-07 13:53 + URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/f34dcfeecc8d 7012823: TEST_BUG: java/nio/MappedByteBuffer tests leave file mappingsthat prevent clean-up (win) Reviewed-by: forax !

hg: jdk7/tl/jdk: 2 new changesets

2011-02-09 Thread alan . bateman
Changeset: 6a274c4d3e00 Author:alanb Date: 2011-02-09 15:59 + URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/6a274c4d3e00 7018258: Dual-pivot updates in 7013585 can fail with ArrayIndexOutOfBoundsException Reviewed-by: alanb Contributed-by: vladimir.yaroslavs...@oracle.com !

hg: jdk7/tl/jdk: 7016704: TEST_BUG: java/nio/file/Files/walk_file_tree.sh fails with new version of find (lnx)

2011-02-14 Thread alan . bateman
Changeset: fefc740bff52 Author:alanb Date: 2011-02-14 18:30 + URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/fefc740bff52 7016704: TEST_BUG: java/nio/file/Files/walk_file_tree.sh fails with new version of find (lnx) Reviewed-by: forax !

hg: jdk7/tl/jdk: 7023034: Files.createTempDirectory((Path)null, temp) does not throw NPE

2011-03-01 Thread alan . bateman
Changeset: b7e763a573a4 Author:alanb Date: 2011-03-01 12:03 + URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/b7e763a573a4 7023034: Files.createTempDirectory((Path)null, temp) does not throw NPE Reviewed-by: forax ! src/share/classes/java/nio/file/Files.java !

hg: jdk7/tl/jdk: 7021987: native2ascii file cannot be read error message is broken

2011-03-02 Thread alan . bateman
Changeset: 895687e879ca Author:alanb Date: 2011-03-02 16:56 + URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/895687e879ca 7021987: native2ascii file cannot be read error message is broken Reviewed-by: lancea, mchung ! src/share/classes/sun/tools/native2ascii/Main.java !

hg: jdk7/tl/jdk: 2 new changesets

2011-03-04 Thread alan . bateman
Changeset: 2fb9e2d4ef46 Author:alanb Date: 2011-03-04 09:29 + URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/2fb9e2d4ef46 6944810: (ch) Assert failure in sun.nio.ch.PendingIoCache.clearPendingIoMap [win] Reviewed-by: chegar !

Re: Review request for 7020513 : Add com.sun.xml.internal to the package.access property in java.security

2011-03-07 Thread Alan Bateman
Rama Pulavarthi wrote: Thanks for the review. We had to make additional changes to run the tests. Hopefully this is the final webrev for this issue. Please review this new webrev which also has changes to jdk/test/Makefile to run the tests.

hg: jdk7/tl/jdk: 3 new changesets

2011-03-20 Thread alan . bateman
Changeset: 0fdc4553f79f Author:alanb Date: 2011-03-18 19:46 + URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/0fdc4553f79f 7028468: (fs) FileSystems.getDefault() fails when kernel micro version contains/ends non-numeric characters Reviewed-by: forax, chegar !

hg: jdk7/tl/jdk: 2 new changesets

2011-03-29 Thread alan . bateman
Changeset: 646047d77db9 Author:alanb Date: 2011-03-30 00:59 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/646047d77db9 7026507: Bidi initialization fails if AWT not present Reviewed-by: okutsu ! src/share/classes/sun/text/bidi/BidiBase.java Changeset: a40982a82291 Author:

hg: jdk7/tl/jdk: 4 new changesets

2011-04-04 Thread alan . bateman
Changeset: 05c9c157ec51 Author:alanb Date: 2011-04-04 18:09 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/05c9c157ec51 7029979: (fs) Path.toRealPath(boolean) should be toRealPath(LinkOption...) Reviewed-by: sherman ! src/share/classes/java/nio/file/Path.java !

hg: jdk7/tl/langtools: 2 new changesets

2011-04-04 Thread alan . bateman
Changeset: 7916df9c99be Author:alanb Date: 2011-04-04 18:10 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/7916df9c99be 7029979: (fs) Path.toRealPath(boolean) should be toRealPath(LinkOption...) Reviewed-by: mcimadamore, jjg !

hg: jdk7/tl/jdk: 2 new changesets

2011-04-06 Thread alan . bateman
Changeset: cd86fbf11e33 Author:alanb Date: 2011-04-06 20:51 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/cd86fbf11e33 7034155: (ch) NullPointerException in sun.io.ch.IOUtil when OOM is thrown Reviewed-by: forax ! src/share/classes/sun/nio/ch/DatagramChannelImpl.java !

hg: jdk7/tl/jdk: 7036582: Improve test coverage of java.math.BigDecimal

2011-04-17 Thread alan . bateman
Changeset: 007b2535a7f5 Author:alanb Date: 2011-04-17 13:49 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/007b2535a7f5 7036582: Improve test coverage of java.math.BigDecimal Reviewed-by: darcy Contributed-by: sergey.kukse...@oracle.com ! test/ProblemList.txt +

hg: jdk7/tl/jdk: 2 new changesets

2011-04-26 Thread alan . bateman
Changeset: dc74b14a8753 Author:alanb Date: 2011-04-10 19:45 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/dc74b14a8753 7034532: (fs) AssertionError when working directory is UNC Reviewed-by: forax, mduigou ! src/windows/classes/sun/nio/fs/WindowsFileSystem.java Changeset:

hg: jdk7/tl/jdk: 7039186: (ch) EPoll based asynchronous I/O implementation should be portable to linux-arm and linux-ppc

2011-04-27 Thread alan . bateman
Changeset: a0dde3ff1dfd Author:alanb Date: 2011-04-27 13:46 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/a0dde3ff1dfd 7039186: (ch) EPoll based asynchronous I/O implementation should be portable to linux-arm and linux-ppc Reviewed-by: dholmes !

hg: jdk7/tl/jaxp: 5 new changesets

2011-05-09 Thread alan . bateman
Changeset: 2d68646d98ba Author:schien Date: 2011-04-28 17:44 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jaxp/rev/2d68646d98ba Added tag jdk7-b140 for changeset c8136fd161c8 ! .hgtags Changeset: e1b5ef243445 Author:schien Date: 2011-05-02 09:36 -0700 URL:

hg: jdk7/tl/langtools: 5 new changesets

2011-05-09 Thread alan . bateman
Changeset: 2637cf09460b Author:schien Date: 2011-04-28 17:44 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/2637cf09460b Added tag jdk7-b140 for changeset 258e6654aba2 ! .hgtags Changeset: 90adb5d6adc7 Author:schien Date: 2011-05-02 09:38 -0700 URL:

hg: jdk7/tl/jdk: 59 new changesets

2011-05-09 Thread alan . bateman
Changeset: 7acc942d7dcc Author:schien Date: 2011-04-28 17:44 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/7acc942d7dcc Added tag jdk7-b140 for changeset 9315c733fb17 ! .hgtags Changeset: 33a139b2a85e Author:schien Date: 2011-05-02 09:37 -0700 URL:

hg: jdk7/tl/jdk: 2 new changesets

2011-05-11 Thread alan . bateman
Changeset: 11ef1f1bd7ca Author:alanb Date: 2011-05-11 14:57 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/11ef1f1bd7ca 7043425: (fc) ClosedByInterruptException thrown but interrupt status not set Reviewed-by: dholmes, chegar !

hg: jdk7/tl/jdk: 7050358: (fs spec) Path.toUri doesn't allow custom providers to use opaque URIs

2011-06-04 Thread alan . bateman
Changeset: 53d759eb580c Author:alanb Date: 2011-06-04 11:18 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/53d759eb580c 7050358: (fs spec) Path.toUri doesn't allow custom providers to use opaque URIs Reviewed-by: sherman ! src/share/classes/java/nio/file/Path.java

Re: code review request: 7054428: test/java/security/SecureClassLoader/DefineClassByteBuffer.java error

2011-06-14 Thread Alan Bateman
Weijun Wang wrote: Hi Alan The last excluded test in jdk_security1: http://cr.openjdk.java.net/~weijun/7054428/webrev.00/ I'm not an NIO expert, but the test looks too wrong. Is there any chance for it to pass in the last 8 years? I don't think L104-105 is needed. I agree with L109 and

Re: code review request: 7054428: test/java/security/SecureClassLoader/DefineClassByteBuffer.java error

2011-06-14 Thread Alan Bateman
Weijun Wang wrote: Hi Alan The last excluded test in jdk_security1: http://cr.openjdk.java.net/~weijun/7054428/webrev.00/ I'm not an NIO expert, but the test looks too wrong. Is there any chance for it to pass in the last 8 years? I don't think L104-105 is needed. I agree with L109 and

Re: code review request: 7054428: test/java/security/SecureClassLoader/DefineClassByteBuffer.java error

2011-06-15 Thread Alan Bateman
Weijun Wang wrote: But the current test passes without closing the stream, even on Windows. I guess it's because the file opened is not in scratch directory and needs not be cleaned up. If we have to close the stream/channel, it seems the references need to saved in DummyClassLoader's

hg: jdk7/tl/jdk: 7055508: (aio) EXCEPTION_ACCESS_VIOLATION in AsynchronousSocketChannel.connect on Windows 7

2011-06-17 Thread alan . bateman
Changeset: c46f97579fe6 Author:alanb Date: 2011-06-17 16:47 +0100 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/c46f97579fe6 7055508: (aio) EXCEPTION_ACCESS_VIOLATION in AsynchronousSocketChannel.connect on Windows 7 Reviewed-by: chegar !

hg: jdk8/tl/jdk: 7056815: test/java/lang/ClassLoader/deadlock/TestOneWayDelegate.sh times out intermittently on busy machine

2011-06-21 Thread alan . bateman
Changeset: 70f14c2db078 Author:alanb Date: 2011-06-21 16:11 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/70f14c2db078 7056815: test/java/lang/ClassLoader/deadlock/TestOneWayDelegate.sh times out intermittently on busy machine Reviewed-by: mchung !

hg: jdk8/tl/jdk: 6965150: TEST_BUG: java/nio/channels/AsynchronousSocketChannel/Basic.java takes too long

2011-06-24 Thread alan . bateman
Changeset: 0ad50d4ed1cf Author:alanb Date: 2011-06-24 19:30 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0ad50d4ed1cf 6965150: TEST_BUG: java/nio/channels/AsynchronousSocketChannel/Basic.java takes too long Reviewed-by: chegar !

  1   2   3   4   5   6   7   8   >