[security-dev 01275]: Re: ECC pkcs#11 bug]

2009-10-05 Thread Tomas Gustavsson
ng HSMs as far as I can see. ECC is rolling out pretty wide in europe now with new electronic passports and other ecc cards. So getting this fixed would be quite welcome, it's a small fix. I've tested it on SafeNet HSMs myself right now. Kind regards, Tomas Gustavsson PrimeKey Soluti

[security-dev 01279]: Re: ECC pkcs#11 bug]

2009-10-06 Thread Tomas Gustavsson
Andrew John Hughes wrote: > 2009/10/6 Tomas Gustavsson : >> Hi Andrew, >> >> I guess no bug Id was created after all. >> The issue is that the pkcs#11 library returns a tag-length-value >> encoding for an EC public key, but the Sun provider expects something &g

[security-dev 01281]: Re: ECC pkcs#11 bug]

2009-10-06 Thread Tomas Gustavsson
Sweet! Let me know if you need any help testing. I'm mainly running on Ubuntu 64bit, but have access to others as well. Regards, Tomas Vincent Ryan wrote: > > Tomas Gustavsson wrote: >> Andrew John Hughes wrote: >>> 2009/10/6 Tomas Gustavsson : >>>> Hi A

[security-dev 01282]: Re: ECC pkcs#11 bug]

2009-10-06 Thread Tomas Gustavsson
un Contribution Agreement". Andrew John Hughes wrote: > 2009/10/5 Tomas Gustavsson : >> Hi Vincent and Brad, >> >> I'm not sure how things are at Sun currently. We work with Sun here in >> Sweden so we've heard a bit about wait with the Oracle story. >>

[security-dev 01283]: Re: ECC pkcs#11 bug]

2009-10-06 Thread Tomas Gustavsson
Here is another reference to this bug: http://forums.sun.com/thread.jspa?messageID=10270927 Regards, Tomas Andrew John Hughes wrote: > 2009/10/5 Tomas Gustavsson : >> Hi Vincent and Brad, >> >> I'm not sure how things are at Sun currently. We work with Sun here in

[security-dev 01306]: BrainPool EC curves?

2009-10-14 Thread Tomas Gustavsson
Hi, I'm wondering if there is any plans to support the brainpool EC curves (http://www.ecc-brainpool.org/) in openjdk (including the p11 provider)? These curves are standardized and are being used in a lot of ePassport deployments in the EU. Kind regards, Tomas Gustavsson PrimeKey Solutions AB

[security-dev 01307]: RSAwithMGF1 in p11 provider?

2009-10-14 Thread Tomas Gustavsson
Hi again :-) I'm just wondering if there are any plans to support the RSAWithMGF1 signature algorithm in the pkcs11 provider? There is already support in the JDK for it, just not through pkcs11. Kind regards, Tomas Gustavsson PrimeKey Solutions AB

[security-dev 01355]: Elliptic curve bugs?

2009-11-02 Thread Tomas Gustavsson
Hi, I found this by for Elliptic curve crypto: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6738532 It's quite old and there seems to ba a quite easy resolution to the bug (second suggested solutions). Any plans to fix it? Cheers, Tomas

[security-dev 01495]: ECC non-named parameters in ECParameters.java

2010-01-07 Thread Tomas Gustavsson
#Using%20EC%20keys. This howto naturally includes patching ECParameters to enable this code. It seems to work just fine. Does anyone know why this code is supposed to be incomplete? And what would it take to get it enabled in JDK so we don't have to patch the jdk? Kind regards, Tomas Gusta

[security-dev 01543]: Re: PING: [PATCH FOR REVIEW]: 6763530: Fix breakage of NSS-based Elliptic Curve Cryptography in OpenJDK6

2010-01-20 Thread Tomas Gustavsson
I'll second this request. This is a critical patch and many production installations have to live with this manually patched now. I know of no pkcs11 implementation that works with the current code. Regards, Tomas Gustavsson PrimeKey Solutions AB On Wed, 20 Jan 2010, Michael StJohns

[security-dev 01548]: Re: PING: [PATCH FOR REVIEW]: 6763530: Fix breakage of NSS-based Elliptic Curve Cryptography in OpenJDK6

2010-01-21 Thread Tomas Gustavsson
Wonderful! Thanks! Cheers, Tomas Vincent Ryan wrote: I hear ya. Sorry for the delay on this. I'll push the fix for OpenJDK today. On 21/01/2010 07:44, Tomas Gustavsson wrote: Now it has one more vote. /Tomas Andrew John Hughes wrote: 2010/1/20 Tomas Gustavsson : I'll s

[security-dev 01550]: Re: PING: [PATCH FOR REVIEW]: 6763530: Fix breakage of NSS-based Elliptic Curve Cryptography in OpenJDK6

2010-01-21 Thread Tomas Gustavsson
itted this is because I submitted a >>>>>>>>>> different >>>>>>>>>> EC fix https://bugs.openjdk.java.net/show_bug.cgi?id=100048 per >>>>>>>>>> the > > Mike > > > > >> On 21/01/20

[security-dev 01551]: Re: PING: [PATCH FOR REVIEW]: 6763530: Fix breakage of NSS-based Elliptic Curve Cryptography in OpenJDK6

2010-01-21 Thread Tomas Gustavsson
Now it has one more vote. /Tomas Andrew John Hughes wrote: 2010/1/20 Tomas Gustavsson : I'll second this request. This is a critical patch and many production installations have to live with this manually patched now. I know of no pkcs11 implementation that works with the current

[security-dev 01741]: Re: '\0' in alias name of a pkcs11 keystore

2010-03-26 Thread Tomas Gustavsson
Slightly off topic. Something I would like to see is API support for setting aliases when using the KeyPairGenerator. This is due to the fact that many HSMs do not allow changing an alias of private keys after they have been generated. Since the key pair generator sets a blank alias when using

[security-dev 01745]: Re: '\0' in alias name of a pkcs11 keystore

2010-03-29 Thread Tomas Gustavsson
t; Thanks, > Valerie > > On 03/26/10 00:05, Tomas Gustavsson wrote: >> >> Slightly off topic. >> Something I would like to see is API support for setting aliases when >> using the KeyPairGenerator. This is due to the fact that many HSMs do >> not allow changi

[security-dev 01750]: Re: alias in KeyPairGenerator - was: '\0' in alias name of a pkcs11 keystore

2010-03-31 Thread Tomas Gustavsson
? Thanks, Valerie On 03/26/10 00:05, Tomas Gustavsson wrote: Slightly off topic. Something I would like to see is API support for setting aliases when using the KeyPairGenerator. This is due to the fact that many HSMs do not allow changing an alias of private keys after they have been generated

Re: [security-dev 01750]: Re: alias in KeyPairGenerator - was: '\0' in alias name of a pkcs11 keystore

2010-04-19 Thread Tomas Gustavsson
what's going on and make further comments tomorrow. Mike At 03:26 AM 3/31/2010, Tomas Gustavsson wrote: Hi, Sorry if I misunderstood you. That is actually exactly how we do it, 1. Use KeyPairGenerator with P11 provider to generate key pair. 2. Create a keystore with the P11 prov

Re: [security-dev 01750]: Re: alias in KeyPairGenerator - was: '\0' in alias name of a pkcs11 keystore

2010-04-19 Thread Tomas Gustavsson
If we need it it's usually for all keys, both RSA and EC. Cheers, Tomas "Michael StJohns" wrote: >At 04:34 AM 4/19/2010, Tomas Gustavsson wrote: > >>Hi, >>Sorry being late, I was away on vacation. >> >>Yes in most cases we do use a custom PKCS11

Re: [security-dev 01750]: Re: alias in KeyPairGenerator - was: '\0' in alias name of a pkcs11 keystore

2010-04-20 Thread Tomas Gustavsson
olves your problem? Valerie On 04/19/10 08:08, Tomas Gustavsson wrote: If we need it it's usually for all keys, both RSA and EC. Cheers, Tomas "Michael StJohns" wrote: At 04:34 AM 4/19/2010, Tomas Gustavsson wrote: Hi, Sorry being late, I was away on vacation. Yes in most

Supporting SHA224WithECDSA

2010-08-25 Thread Tomas Gustavsson
Hi, The PKCS#11 provider currently does not support SHA224WithECDSA, although this is becoming a popular algorithm. I have hacked it myself to support this and the patch is basically trivial. Is it possible to get this support in the JDK? It requires only trivial modifications to AgorithmId.

Re: Supporting SHA224WithECDSA

2010-08-27 Thread Tomas Gustavsson
> > A quick look at the current JDK7 has support for SHA224withECDSA in > AlgorithmId.java already... > > Mike > > > > At 12:37 AM 8/26/2010, Tomas Gustavsson wrote: > >> Hi, >> >> The PKCS#11 provider currently does not support SHA224WithE

Status of old sun tracker issues?

2013-05-27 Thread Tomas Gustavsson
Hi, What is the master issue tracker for OpenJDK these days? We have reported https://bugs.openjdk.java.net/show_bug.cgi?id=100162 Which is closed referencing a "sun bug" id. Is the oracle tracker (which was off line for a long time) the main issue tracker for OpenJDK still? Che

Re: Status of old sun tracker issues?

2013-05-28 Thread Tomas Gustavsson
/view_bug.do?bug_id=7007966 regards, Sean. [1] https://blogs.oracle.com/darcy/entry/milestone_jira_system_of_record On 27/05/13 09:31, Tomas Gustavsson wrote: Hi, What is the master issue tracker for OpenJDK these days? We have reported https://bugs.openjdk.java.net/show_bug.cgi?id=100162 Which is

Re: [8] 7174966: With OCSP enabled on Java 7 get error 'Wrong key usage' with Comodo certificate

2013-05-30 Thread Tomas Gustavsson
It was at some point common to require digitalSignature. Many years ago when we developed support for OCSP in EJBCA, Mozilla browsers would not accept OCSP responses with only keyCertSign and crlSign. DigitalSignature was needed as well. So at least it was common behaviour some years ago. I

Re: Brainpool curves

2015-09-23 Thread Tomas Gustavsson
+1 for this. On 2015-09-17 19:53, Sean Mullan wrote: On 08/19/2015 05:48 PM, Jiri Stary wrote: Hello, do you plan to support brainpool curves for TLS in Java 9 (RFC 7027) ? There is no plan to support it in 9. There is an open RFE for supporting brainpool in JCE: https://bugs.openjdk.java.n

Re: Please Review: required security algorithms for Java SE 7 implementations

2010-12-16 Thread Tomas Gustavsson
I don't see any ECC algorithms. These are in wide use today to say the least. And will be so even more tomorrow (i.e. when Java SE 7 is out you can not live without it). Regards, Tomas On 12/15/2010 04:11 PM, Sean Mullan wrote: Hello, Currently, the Java security APIs do not specify algori

Re: Please Review: required security algorithms for Java SE 7 implementations

2010-12-17 Thread Tomas Gustavsson
--Sean > > On 12/16/2010 09:40 AM, Tomas Gustavsson wrote: >> >> I don't see any ECC algorithms. These are in wide use today to say the >> least. And will be so even more tomorrow (i.e. when Java SE 7 is out you >> can not live without it). >> >> Reg

ECC on PKCS#11, Oracle JDK?

2011-02-16 Thread Tomas Gustavsson
Now SE6 u24 is out and still no PKCS#11 ECC bugfix in Oracle JDK. What's up? It's been in OpenJDK for quite some time now. Cheers, Tomas

NSA Suite B ciphers and JDK7, i.e. review 7031343

2011-04-27 Thread Tomas Gustavsson
Hi, (changed subject as to not mess up review threads). Just a question weather this NSA Suite B effort will mean that some attention will be given to ECC ciphers and PKCS#11 in JDK 7? We have a few fix requests submitted in this area. Regards, Tomas On 04/07/2011 06:46 AM, Brad Wetmore w

Re: ECC RFE's

2011-05-10 Thread Tomas Gustavsson
st did was just to provide API support for GCM (and later CCM, likely in 8). We're really ramping down for the JDK 7 release, and I don't know what Vinnie/Valerie have in mind for the remaining time. Brad On 4/27/2011 1:34 AM, Tomas Gustavsson wrote: Hi, (changed subject as to not me

Re: Review 7053252: New regression test does not compile on windows-amd64

2011-11-02 Thread Tomas Gustavsson
Will there ever be a pkcs11 for windows-x64? Cheers, Tomas On 10/31/2011 11:33 PM, Valerie (Yu-Ching) Peng wrote: > Looks good to me. > Valerie > > On 10/31/11 14:19, Brad Wetmore wrote: >> >> Hi Valerie, >> >> http://cr.openjdk.java.net/~wetmore/7053252/ >> >> Review 7053252: New regression t

Re: Review 7053252: New regression test does not compile on windows-amd64

2011-11-21 Thread Tomas Gustavsson
Will there ever be a pkcs11 for windows-x64? Cheers, Tomas On 10/31/2011 11:33 PM, Valerie (Yu-Ching) Peng wrote: > Looks good to me. > Valerie > > On 10/31/11 14:19, Brad Wetmore wrote: >> >> Hi Valerie, >> >> http://cr.openjdk.java.net/~wetmore/7053252/ >> >> Review 7053252: New regression t

Re: JEP 131: PKCS#11 Crypto Provider for 64-bit Windows

2011-12-23 Thread Tomas Gustavsson
Cool patches! Everything we've been looking for. There should be a few patches from us in the issue tracker for SHA224WithECDSA and some other ECDSA related stuff. Cheers, Tomas On 12/22/2011 11:41 PM, mark.reinh...@oracle.com wrote: > Posted: http://openjdk.java.net/jeps/131 > > - Mark

Re: RFR 6913047: SunPKCS11 memory leak

2018-10-09 Thread Tomas Gustavsson
Hi, > Maybe its time to provide a PKCS11AttributeSpec of some sort for key > creation and for looking things up? The current model is literally > 12-15 years old AFAICT. I just though I'd second this, albeit late. We're seing the current PKCS#11 Provider model break down with some new HSMs ou

Re: Brainpool curves

2015-10-07 Thread Tomas Gustavsson
Solutions AB Lundagatan 16, 171 63 Solna, Sweden Mob: +46 (0)707421096 Internet: www.primekey.se Twitter: twitter.com/primekeyPKI ** On 2015-09-30 14:41, Laumann Andreas wrote: Am Mittwoch, den 23.09.2015, 17:27 +0200 schrieb Tomas Gustavsson: +1 for this. +1 also from my side

Re: contribute to the OpenJDK security group

2018-01-24 Thread Tomas Gustavsson
Sorry for jumping in :-) Imho the P11 layer always needs attention. To work properly we're relying on some patches, where parts was recently merged into OpenJDK. We just started testing the Amazon CloudHSM, and that requires changes to SunPKCS11 as well to work. Not always bad in SunPKCS11 as som

PKCS#11 provider issues with min and max size

2018-01-30 Thread Tomas Gustavsson
xample reverting back to the old behavior when these were ignored. Regards, Tomas Gustavsson -- ** PrimeKey Solutions AB Lundagatan 16, 171 63 Solna, Sweden Mob: +46 (0)707421096 Internet: www.primekey.se Twitter: twitter.com/primekeyPKI **

Re: PKCS#11 provider issues with min and max size

2018-02-09 Thread Tomas Gustavsson
yLen != -1) && (keySize < minKeyLen)) { >> keySize = minKeyLen; >> } >> if ((maxKeyLen != -1) && (maxKeyLen < minKeyLen)) { >> maxKeyLen = minKeyLen; >> } >> if ((maxKeyLen != -1) && (keySize > maxKeyLen)) { >> keySize = maxKeyLen; >> } >> >> 2. Allow to ignore checking of maxKeyLen by some means, i.e. allow to >> ignore checking against C_GetMechanismInfo if you know that the HSM does >> not provide sane values. I.e. an environment variable for example >> reverting back to the old behavior when these were ignored. >> >> Regards, >> Tomas Gustavsson >> >

Re: contribute to the OpenJDK security group

2018-02-09 Thread Tomas Gustavsson
ack is always welcomed. > > What do you mean with "more flexibility"? > > -- > [1] > - http://mail.openjdk.java.net/pipermail/security-dev/2017-October/016400.html > > On Wed, Jan 24, 2018 at 8:06 AM, Andrew Haley <mailto:a...@redhat.com>> wrote: >

Re: [PATCH]: Support for brainpool curves from CurveDB in SunEC

2018-02-09 Thread Tomas Gustavsson
Just FYI. SoftHSM2 from the OpenDNSSec project is a good P11 to test with, and I believe it supports brainpool in recent versions. https://github.com/opendnssec/SoftHSMv2 It works really good) Regards, Tomas On 2018-02-09 02:03, Valerie Peng wrote: > Hi Tobias, > > Just curious, which PKCS11 l

Re: PKCS#11 provider issues with min and max size

2018-02-09 Thread Tomas Gustavsson
= true CKA_DECRYPT = true CKA_SIGN = true CKA_VERIFY = true CKA_WRAP = true CKA_UNWRAP = true } - Cheers, Tomas On 2018-02-09 09:55, Tomas Gustavsson wrote: > > Hi, > > Thanks for the answer. (sorry I was out with the flu for a week) > >> I am not too k

Re: PKCS#11 provider issues with min and max size

2018-02-13 Thread Tomas Gustavsson
approach is to just add an > configuration option for disabling checking the supported key size range. > Regards, > Valerie > > On 2/9/2018 2:16 AM, Tomas Gustavsson wrote: >> I just realized that a natural place to configure provider behavior is >> in the provider constru

Re: PKCS#11 provider issues with min and max size

2018-03-15 Thread Tomas Gustavsson
n Mob: +46 (0)707421096 Internet: www.primekey.se Twitter: twitter.com/primekeyPKI ** On 2018-02-15 23:51, Valerie Peng wrote: > > Yes, please go ahead and file a bug for this. > Thanks! > Valerie > > On 2/13/2018 6:00 AM, Tomas Gustavsson wrote: >> Thanks for t

PKCS11 generateKeyPair with alias

2018-08-26 Thread Tomas Gustavsson
Hi, There is a long standing issue (since the beginning) with keyPairGeneration in the Sun PKCS#11 provider, but I thought it's time to vent it. KeyPairGenerator.generateKeyPair() only generates a keyPair, and does not set any alias or ID on the key. You can set an alias by using a sun config f