Re: RFR(T): 8230910: libsspi_bridge does not build on Windows 32bit

[Thomas Stüfe]

Thanks for the reviews, will push.

..Thomas

On Fri, Sep 13, 2019 at 2:58 PM Weijun Wang  wrote:

> Also looks fine to me. I can confirm it also builds successfully on
> windows-x64.
>
> Thanks,
> Max
>
>
> > On Sep 13, 2019, at 3:22 PM, Alan Bateman 
> wrote:
> >
> >
> > Using size_t looks okay here.
> >
> > -Alan
> >
> > On 12/09/2019 12:31, Sean Mullan wrote:
> >> This is in the security-libs area, not core-libs. Cross-posting to
> security-dev and bcc-ing core-libs-dev.
> >>
> >> --Sean
> >>
> >> On 9/12/19 6:40 AM, Thomas Stüfe wrote:
> >>> Hi all,
> >>>
> >>> may I please have reviews for the following trivial build fix.
> >>>
> >>> Bug: https://bugs.openjdk.java.net/browse/JDK-8230910
> >>> webrev:
> >>>
> http://cr.openjdk.java.net/~stuefe/webrevs/8230910-libsspi_bridge_does_not_build_on_windows_32bit/webrev.00/webrev/
> >>>
> >>> Thanks,
> >>>
> >>> Thomas
> >>>
> >
>
>

Re: RFR(T): 8230910: libsspi_bridge does not build on Windows 32bit

[Weijun Wang]

Also looks fine to me. I can confirm it also builds successfully on windows-x64.

Thanks,
Max


> On Sep 13, 2019, at 3:22 PM, Alan Bateman  wrote:
> 
> 
> Using size_t looks okay here.
> 
> -Alan
> 
> On 12/09/2019 12:31, Sean Mullan wrote:
>> This is in the security-libs area, not core-libs. Cross-posting to 
>> security-dev and bcc-ing core-libs-dev.
>> 
>> --Sean
>> 
>> On 9/12/19 6:40 AM, Thomas Stüfe wrote:
>>> Hi all,
>>> 
>>> may I please have reviews for the following trivial build fix.
>>> 
>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8230910
>>> webrev:
>>> http://cr.openjdk.java.net/~stuefe/webrevs/8230910-libsspi_bridge_does_not_build_on_windows_32bit/webrev.00/webrev/
>>>  
>>> 
>>> Thanks,
>>> 
>>> Thomas
>>> 
> 

Re: RFR(T): 8230910: libsspi_bridge does not build on Windows 32bit

[Alan Bateman]

Using size_t looks okay here.

-Alan

On 12/09/2019 12:31, Sean Mullan wrote:
This is in the security-libs area, not core-libs. Cross-posting to 
security-dev and bcc-ing core-libs-dev.


--Sean

On 9/12/19 6:40 AM, Thomas Stüfe wrote:

Hi all,

may I please have reviews for the following trivial build fix.

Bug: https://bugs.openjdk.java.net/browse/JDK-8230910
webrev:
http://cr.openjdk.java.net/~stuefe/webrevs/8230910-libsspi_bridge_does_not_build_on_windows_32bit/webrev.00/webrev/ 



Thanks,

Thomas

Re: RFR(T): 8230910: libsspi_bridge does not build on Windows 32bit

[Sean Mullan]

This is in the security-libs area, not core-libs. Cross-posting to 
security-dev and bcc-ing core-libs-dev.


--Sean

On 9/12/19 6:40 AM, Thomas Stüfe wrote:

Hi all,

may I please have reviews for the following trivial build fix.

Bug: https://bugs.openjdk.java.net/browse/JDK-8230910
webrev:
http://cr.openjdk.java.net/~stuefe/webrevs/8230910-libsspi_bridge_does_not_build_on_windows_32bit/webrev.00/webrev/

Thanks,

Thomas