Re: RFR: 8170131: Certificates not being blocked by jdk.tls.disabledAlgorithms property

2016-12-02 Thread Sean Mullan
On 12/2/16 11:41 AM, Anthony Scarpino wrote: It looks fine. One question, line 866 of the test you print the stacktrace on a success, was that intentional? No, good spot, it is leftover from debugging, I'll remove it before I push. --Sean Tony On Dec 1, 2016, at 11:02 AM, Sean Mullan wr

Re: RFR: 8170131: Certificates not being blocked by jdk.tls.disabledAlgorithms property

2016-12-02 Thread Anthony Scarpino
It looks fine. One question, line 866 of the test you print the stacktrace on a success, was that intentional? Tony > On Dec 1, 2016, at 11:02 AM, Sean Mullan wrote: > > I enhanced the test case to test more scenarios where MD5 is either disabled > via the jdk.tls.disabledAlgorithms or the jd

Re: RFR: 8170131: Certificates not being blocked by jdk.tls.disabledAlgorithms property

2016-12-01 Thread Sean Mullan
I enhanced the test case to test more scenarios where MD5 is either disabled via the jdk.tls.disabledAlgorithms or the jdk.certpath.disabledAlgorithms property. Please take another look and let me know if you are ok with it: http://cr.openjdk.java.net/~mullan/webrevs/8170131/webrev.01/ Thanks

Re: RFR: 8170131: Certificates not being blocked by jdk.tls.disabledAlgorithms property

2016-11-22 Thread Anthony Scarpino
On 11/22/2016 05:19 AM, Sean Mullan wrote: On 11/21/16 5:43 PM, Anthony Scarpino wrote: On 11/21/2016 01:09 PM, Sean Mullan wrote: Please review this fix for a bug where certificates were not being blocked if the algorithm is only listed in the jdk.tls.disabledAlgorithms property and not the jd

Re: RFR: 8170131: Certificates not being blocked by jdk.tls.disabledAlgorithms property

2016-11-22 Thread Sean Mullan
On 11/21/16 5:43 PM, Anthony Scarpino wrote: On 11/21/2016 01:09 PM, Sean Mullan wrote: Please review this fix for a bug where certificates were not being blocked if the algorithm is only listed in the jdk.tls.disabledAlgorithms property and not the jdk.certpath.disabledAlgorithms property. I h

Re: RFR: 8170131: Certificates not being blocked by jdk.tls.disabledAlgorithms property

2016-11-21 Thread Anthony Scarpino
On 11/21/2016 01:09 PM, Sean Mullan wrote: Please review this fix for a bug where certificates were not being blocked if the algorithm is only listed in the jdk.tls.disabledAlgorithms property and not the jdk.certpath.disabledAlgorithms property. I have modified an existing regression test to te