Re: RFR[15] JDK-8237977: Further update javax/net/ssl/compatibility/Compatibility.java

2020-03-25 Thread Rajan Halade
Thanks for the update. Changes look good to me. - Rajan > On Mar 25, 2020, at 1:48 AM, sha.ji...@oracle.com wrote: > > Hi Rajan, > Thanks for your suggestions. > Please review the updated webrev: > http://cr.openjdk.java.net/~jjiang/8237977/webrev.01/ >

Re: RFR[15] JDK-8237977: Further update javax/net/ssl/compatibility/Compatibility.java

2020-03-25 Thread sha . jiang
Hi Rajan, Thanks for your suggestions. Please review the updated webrev: http://cr.openjdk.java.net/~jjiang/8237977/webrev.01/ On 2020/3/25 11:08, Rajan Halade wrote: Hi John, Thanks for taking care of this fix. Your changes look good me. I have couple of suggestions: - consider changing he

Re: RFR[15] JDK-8237977: Further update javax/net/ssl/compatibility/Compatibility.java

2020-03-24 Thread Rajan Halade
Hi John, Thanks for taking care of this fix. Your changes look good me. I have couple of suggestions: - consider changing header for last column from “Why negative case” to “Reason” - for a failed test case (a testcase that succeeds when expected to fail or a testcase that fails when expected