Re: RFR 8200468: Port the native GSS-API bridge to Windows

> On Apr 13, 2018, at 9:09 AM, Valerie Peng wrote: > > Hi Max, > > Changes look fine, just some very minor nit: Maybe it's better to remove the > unused variables which currently are only commented out (GSSLibStub.c and > NativeUtil.c). Sure. > When testing, did u

Re: RFR 8200468: Port the native GSS-API bridge to Windows

Hi Valerie I updated the webrev at http://cr.openjdk.java.net/~weijun/8200468/webrev.01/ The only change is that I prepend "GSS_DLLIMP" to all gss_* functions in gssapi.h. The file has the following lines 283 #if defined (_WIN32) && defined (_MSC_VER) 284 # ifdef GSS_DLL_FILE 285 #

Re: RFR 8200468: Port the native GSS-API bridge to Windows

On 2018-04-04 10:06, Weijun Wang wrote: On Apr 4, 2018, at 3:59 PM, Magnus Ihse Bursie wrote: Hi Max, On 2018-04-04 04:19, Weijun Wang wrote: Hi All Please take a review at http://cr.openjdk.java.net/~weijun/8200468/webrev.00/ The indentation in

Re: RFR 8200468: Port the native GSS-API bridge to Windows

I've updated the patch in its original URL. Please confirm it's correct now. Thanks Max > On Apr 4, 2018, at 4:06 PM, Weijun Wang wrote: > > > >> On Apr 4, 2018, at 3:59 PM, Magnus Ihse Bursie >> wrote: >> >> Hi Max, >> >> On

Re: RFR 8200468: Port the native GSS-API bridge to Windows

Hi Max, On 2018-04-04 04:19, Weijun Wang wrote: Hi All Please take a review at http://cr.openjdk.java.net/~weijun/8200468/webrev.00/ The indentation in Lib-java.security.jgss.gmk has gone wrong. The lines in the "$(eval $(call SetupJdkLibrary" stanza should still be indented four