Re: [Security-sig] Implementation of the PEP 524

2016-08-18 Thread Nick Coghlan
On 18 August 2016 at 22:10, Nick Coghlan wrote: > OK, I'll review it on that basis, and then submit a follow-up RFE and > patch to add the warning. > > I'd like to minimise the divergence between upstream and Fedora, and > we'll at least have the warning in the downstream version. It belatedly oc

Re: [Security-sig] Implementation of the PEP 524

2016-08-18 Thread Nick Coghlan
On 18 August 2016 at 22:10, Nick Coghlan wrote: > On 18 August 2016 at 03:16, Victor Stinner wrote: >> 2016-08-17 18:39 GMT+02:00 Nick Coghlan : >>> - if blocking *is* set, it prints a warning to stderr, before trying >>> again without the GRND_NONBLOCK flag >> >> I implemented the PEP 524. Such

Re: [Security-sig] Implementation of the PEP 524

2016-08-18 Thread Nick Coghlan
On 18 August 2016 at 03:16, Victor Stinner wrote: > 2016-08-17 18:39 GMT+02:00 Nick Coghlan : >> - if blocking *is* set, it prints a warning to stderr, before trying >> again without the GRND_NONBLOCK flag > > I implemented the PEP 524. Such warning is not part of the PEP. > > Sorry, but I'm not i

Re: [Security-sig] Implementation of the PEP 524

2016-08-17 Thread Victor Stinner
2016-08-17 18:39 GMT+02:00 Nick Coghlan : > - if blocking *is* set, it prints a warning to stderr, before trying > again without the GRND_NONBLOCK flag I implemented the PEP 524. Such warning is not part of the PEP. Sorry, but I'm not interested to reopen the discussion on the PEP since the PEP w

Re: [Security-sig] Implementation of the PEP 524

2016-08-17 Thread Nick Coghlan
On 17 August 2016 at 03:28, Victor Stinner wrote: > Hi, > > I wrote a first implementation of the PEP 524 (make os.urandom blocking): > > * https://bugs.python.org/issue27776 : "PEP 524: Make os.urandom() > blocking on Linux" > * https://bugs.python.org/issue27778 : "PEP 524: Add os.getrandom()" >

[Security-sig] Implementation of the PEP 524

2016-08-16 Thread Victor Stinner
Hi, I wrote a first implementation of the PEP 524 (make os.urandom blocking): * https://bugs.python.org/issue27776 : "PEP 524: Make os.urandom() blocking on Linux" * https://bugs.python.org/issue27778 : "PEP 524: Add os.getrandom()" My patches are now waiting for your review :-) You should also