Re: [PATCH 11/13] selinux: Cleanup printk logging in netif

2018-06-19 Thread Paul Moore
On Tue, Jun 12, 2018 at 4:09 AM Peter Enderborg wrote: > > Replace printk with pr_* to avoid checkpatch warnings. > > Signed-off-by: Peter Enderborg > --- > security/selinux/netif.c | 11 --- > 1 file changed, 4 insertions(+), 7 deletions(-) Merged, thanks. > diff --git

Re: [PATCH 12/13] selinux: Cleanup printk logging in avc

2018-06-19 Thread Paul Moore
On Tue, Jun 12, 2018 at 4:09 AM Peter Enderborg wrote: > > Replace printk with pr_* to avoid checkpatch warnings. > > Signed-off-by: Peter Enderborg > --- > security/selinux/avc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Merged, thanks. > diff --git a/security/selinux/avc.c

Re: [PATCH 10/13] selinux: Cleanup printk logging in netport

2018-06-19 Thread Paul Moore
On Tue, Jun 12, 2018 at 4:09 AM Peter Enderborg wrote: > > Replace printk with pr_* to avoid checkpatch warnings. > > Signed-off-by: Peter Enderborg > --- > security/selinux/netport.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) Merged, thanks. > diff --git

Re: [PATCH 13/13] selinux: Cleanup printk logging in netnode

2018-06-19 Thread Paul Moore
On Tue, Jun 12, 2018 at 4:09 AM Peter Enderborg wrote: > > Replace printk with pr_* to avoid checkpatch warnings. > > Signed-off-by: Peter Enderborg > --- > security/selinux/netnode.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) Merged, thanks. > diff --git

Re: [PATCH 09/13] selinux: Cleanup printk logging in sidtab

2018-06-19 Thread Paul Moore
On Tue, Jun 12, 2018 at 4:09 AM Peter Enderborg wrote: > > Replace printk with pr_* to avoid checkpatch warnings. > > Signed-off-by: Peter Enderborg > --- > security/selinux/ss/sidtab.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) Merged, thanks. > diff --git

Re: [PATCH 08/13] selinux: Cleanup printk logging in netlink

2018-06-19 Thread Paul Moore
On Tue, Jun 12, 2018 at 4:09 AM Peter Enderborg wrote: > > Replace printk with pr_* to avoid checkpatch warnings. > > Signed-off-by: Peter Enderborg > --- > security/selinux/netlink.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Merged, thanks. > diff --git

Re: [PATCH 07/13] selinux: Cleanup printk logging in selinuxfs

2018-06-19 Thread Paul Moore
On Tue, Jun 12, 2018 at 4:09 AM Peter Enderborg wrote: > > Replace printk with pr_* to avoid checkpatch warnings. > > Signed-off-by: Peter Enderborg > --- > security/selinux/selinuxfs.c | 10 +- > 1 file changed, 5 insertions(+), 5 deletions(-) Merged, thanks. > diff --git

Re: 'setsebool -P' works but throws errors; changes not permanent

2018-06-19 Thread Jalus Bilieyich
On Mon, 18 Jun 2018 19:44:10 + Mike Hughes wrote: > We use Yubikey for two-factor ssh authentication which requires enabling a > Boolean called "authlogin_yubikey". It has been working fine until a few > weeks ago. Errors appear when attempting to set the policy: > > -- >

RE: 'setsebool -P' works but throws errors; changes not permanent

2018-06-19 Thread Mike Hughes
> -Original Message- > From: Stephen Smalley > Sent: Tuesday, June 19, 2018 07:39 > > On 06/18/2018 04:33 PM, Mike Hughes wrote: > >> -Original Message- > >> From: Stephen Smalley > >> Sent: Monday, June 18, 2018 15:28 > >> On 06/18/2018 03:44 PM, Mike Hughes wrote: > >>> We use

Re: [PATCH 06/13] selinux: Cleanup printk logging in services

2018-06-19 Thread Paul Moore
On Tue, Jun 12, 2018 at 4:09 AM Peter Enderborg wrote: > > Replace printk with pr_* to avoid checkpatch warnings. > > Signed-off-by: Peter Enderborg > --- > security/selinux/ss/services.c | 71 > +- > 1 file changed, 35 insertions(+), 36 deletions(-)

Re: [PATCH 05/13] selinux: Cleanup printk logging in avtab

2018-06-19 Thread Paul Moore
On Tue, Jun 12, 2018 at 4:09 AM Peter Enderborg wrote: > > Replace printk with pr_* to avoid checkpatch warnings. > > Signed-off-by: Peter Enderborg > --- > security/selinux/ss/avtab.c | 51 > +++-- > 1 file changed, 26 insertions(+), 25 deletions(-)

Re: [PATCH 02/13] selinux: Cleanup printk logging in ebitmap

2018-06-19 Thread Paul Moore
On Tue, Jun 12, 2018 at 4:09 AM Peter Enderborg wrote: > > Replace printk with pr_* to avoid checkpatch warnings. > > Signed-off-by: Peter Enderborg > --- > security/selinux/ss/ebitmap.c | 15 +++ > 1 file changed, 7 insertions(+), 8 deletions(-) Merged, thanks. > diff --git

Re: [PATCH 04/13] selinux: Cleanup printk logging in hooks

2018-06-19 Thread Paul Moore
On Tue, Jun 12, 2018 at 4:09 AM Peter Enderborg wrote: > > Replace printk with pr_* to avoid checkpatch warnings. > > Signed-off-by: Peter Enderborg > --- > security/selinux/hooks.c | 68 > +++- > 1 file changed, 33 insertions(+), 35 deletions(-)

Re: [PATCH 03/13] selinux: Cleanup printk logging in policydb

2018-06-19 Thread Paul Moore
On Tue, Jun 19, 2018 at 12:45 PM Joe Perches wrote: > > On Tue, 2018-06-19 at 12:41 -0400, Paul Moore wrote: > > On Tue, Jun 12, 2018 at 4:09 AM Peter Enderborg > > wrote: > > > > > > Replace printk with pr_* to avoid checkpatch warnings and > > > replace KERN_CONT with 2 longer prints. > > > >

Re: [PATCH 03/13] selinux: Cleanup printk logging in policydb

2018-06-19 Thread Joe Perches
On Tue, 2018-06-19 at 12:41 -0400, Paul Moore wrote: > On Tue, Jun 12, 2018 at 4:09 AM Peter Enderborg > wrote: > > > > Replace printk with pr_* to avoid checkpatch warnings and > > replace KERN_CONT with 2 longer prints. > > > > Signed-off-by: Peter Enderborg > > --- > >

Re: [PATCH 03/13] selinux: Cleanup printk logging in policydb

2018-06-19 Thread Paul Moore
On Tue, Jun 12, 2018 at 4:09 AM Peter Enderborg wrote: > > Replace printk with pr_* to avoid checkpatch warnings and > replace KERN_CONT with 2 longer prints. > > Signed-off-by: Peter Enderborg > --- > security/selinux/ss/policydb.c | 91 > +- > 1 file

Re: [PATCH 01/13] selinux: Cleanup printk logging in conditional

2018-06-19 Thread Paul Moore
On Wed, Jun 13, 2018 at 2:23 AM peter enderborg wrote: > On 06/12/2018 04:38 PM, Joe Perches wrote: > > On Tue, 2018-06-12 at 10:09 +0200, Peter Enderborg wrote: > >> Replace printk with pr_* to avoid checkpatch warnings. > > I believe it would be nicer to remove the > > "SELinux: " prefix

Re: is_selinux_enabled() after chroot()

2018-06-19 Thread Petr Lautrbach
On Mon, Jun 18, 2018 at 04:06:11PM -0400, Stephen Smalley wrote: > On 06/18/2018 03:24 PM, Petr Lautrbach wrote: > > Hello, > > > > libselinux sets selinut_mnt and has_selinux_config only in its constructor > > and > > is_selinux_enabled() and others just use selinux_mnt to check if SELinux is >

Re: 'setsebool -P' works but throws errors; changes not permanent

2018-06-19 Thread Stephen Smalley
On 06/18/2018 04:33 PM, Mike Hughes wrote: >> -Original Message- >> From: Stephen Smalley >> Sent: Monday, June 18, 2018 15:28 >> To: Mike Hughes ; selinux@tycho.nsa.gov >> Subject: Re: 'setsebool -P' works but throws errors; changes not permanent >> >> On 06/18/2018 03:44 PM, Mike Hughes