Re: [PATCH] general protection fault in sock_has_perm

2018-02-01 Thread Greg KH
On Wed, Jan 31, 2018 at 04:06:37AM -0500, Paul Moore wrote: > On Tue, Jan 30, 2018 at 5:46 PM, Greg KH wrote: > > On Tue, Jan 30, 2018 at 11:00:04AM -0800, Mark Salyzyn wrote: > >> On 01/19/2018 09:41 AM, Stephen Smalley wrote: > >> > If we can't safely dereference the

Re: [PATCH] general protection fault in sock_has_perm

2018-01-31 Thread Paul Moore
On Tue, Jan 30, 2018 at 5:46 PM, Greg KH wrote: > On Tue, Jan 30, 2018 at 11:00:04AM -0800, Mark Salyzyn wrote: >> On 01/19/2018 09:41 AM, Stephen Smalley wrote: >> > If we can't safely dereference the sock in these hooks, then that seems >> > to point back to the

Re: [PATCH] general protection fault in sock_has_perm

2018-01-30 Thread Mark Salyzyn
On 01/19/2018 09:41 AM, Stephen Smalley wrote: If we can't safely dereference the sock in these hooks, then that seems to point back to the approach used in my original code, where in ancient history I had sock_has_perm() take the socket and use its inode i_security field instead of the sock.

Re: [PATCH] general protection fault in sock_has_perm

2018-01-22 Thread Mark Salyzyn
On 01/19/2018 09:06 AM, Paul Moore wrote: On Fri, Jan 19, 2018 at 10:49 AM, Mark Salyzyn wrote: On 01/18/2018 02:36 PM, Paul Moore wrote: On Thu, Jan 18, 2018 at 4:58 PM, Mark Salyzyn wrote: general protection fault: [#1] PREEMPT SMP KASAN CPU:

Re: [PATCH] general protection fault in sock_has_perm

2018-01-19 Thread Stephen Smalley
On Fri, 2018-01-19 at 12:19 -0500, Stephen Smalley wrote: > On Thu, 2018-01-18 at 13:58 -0800, Mark Salyzyn wrote: > > general protection fault: [#1] PREEMPT SMP KASAN > > CPU: 1 PID: 14233 Comm: syz-executor2 Not tainted 4.4.112-g5f6325b > > #28 > > task: 8801d1095f00 task.stack:

Re: [PATCH] general protection fault in sock_has_perm

2018-01-19 Thread Casey Schaufler
On 1/19/2018 9:06 AM, Paul Moore wrote: > On Fri, Jan 19, 2018 at 10:49 AM, Mark Salyzyn wrote: >> On 01/18/2018 02:36 PM, Paul Moore wrote: >>> On Thu, Jan 18, 2018 at 4:58 PM, Mark Salyzyn wrote: general protection fault: [#1] PREEMPT SMP

Re: [PATCH] general protection fault in sock_has_perm

2018-01-19 Thread Mark Salyzyn
On 01/18/2018 02:36 PM, Paul Moore wrote: On Thu, Jan 18, 2018 at 4:58 PM, Mark Salyzyn wrote: general protection fault: [#1] PREEMPT SMP KASAN CPU: 1 PID: 14233 Comm: syz-executor2 Not tainted 4.4.112-g5f6325b #28 . . . [] selinux_socket_setsockopt+0x4d/0x80

Re: [PATCH] general protection fault in sock_has_perm

2018-01-19 Thread Greg KH
On Thu, Jan 18, 2018 at 01:58:45PM -0800, Mark Salyzyn wrote: > general protection fault: [#1] PREEMPT SMP KASAN > CPU: 1 PID: 14233 Comm: syz-executor2 Not tainted 4.4.112-g5f6325b #28 > task: 8801d1095f00 task.stack: 8800b595 > RIP: 0010:[] [] > sock_has_perm+0x1fe/0x3e0

[PATCH] general protection fault in sock_has_perm

2018-01-19 Thread Mark Salyzyn
general protection fault: [#1] PREEMPT SMP KASAN CPU: 1 PID: 14233 Comm: syz-executor2 Not tainted 4.4.112-g5f6325b #28 task: 8801d1095f00 task.stack: 8800b595 RIP: 0010:[] [] sock_has_perm+0x1fe/0x3e0 security/selinux/hooks.c:4069 RSP: 0018:8800b5957ce0 EFLAGS: 00010202

Re: [PATCH] general protection fault in sock_has_perm

2018-01-18 Thread Paul Moore
On Thu, Jan 18, 2018 at 4:58 PM, Mark Salyzyn wrote: > general protection fault: [#1] PREEMPT SMP KASAN > CPU: 1 PID: 14233 Comm: syz-executor2 Not tainted 4.4.112-g5f6325b #28 > task: 8801d1095f00 task.stack: 8800b595 > RIP: 0010:[] [] >