Re: [PATCH V3 0/5] selinux:Significant reduce of preempt_disable holds

2018-05-31 Thread peter enderborg
On 05/30/2018 10:34 PM, Stephen Smalley wrote: > On 05/30/2018 10:10 AM, Peter Enderborg wrote: >> The boolean change becomes a lot more heavy with this patch, >> but it is a very rare usage in compare with read only operations. >> The lock held during a policydb_copy is about 1ms on a XEON. >

Re: [PATCH V3 2/5 selinux-next] selinux: Introduce selinux_ruleset struct

2018-05-31 Thread J Freyensee
(snip) . . . -static void security_load_policycaps(struct selinux_state *state) +static void security_load_policycaps(struct selinux_state *state, +struct policydb *p) { - struct policydb *p = >ss->policydb; unsigned int i; struct

Re: [PATCH V3 3/5 selinux-next] selinux: sidtab_clone switch to use rwlock.

2018-05-31 Thread peter enderborg
On 05/30/2018 11:22 PM, J Freyensee wrote: > >>   +int sidtab_clone(struct sidtab *s, struct sidtab *d) >> +{ >> +    int i, rc = 0; > If s or d are NULL (see if() below), why would we want rc, the return value, > to be 0?  How about defaulting rc to an error value (-EINVAL)? Oops! Thanks, will

Re: [PATCH V3 0/5] selinux:Significant reduce of preempt_disable holds

2018-05-31 Thread Stephen Smalley
On 05/31/2018 05:04 AM, peter enderborg wrote: > On 05/30/2018 10:34 PM, Stephen Smalley wrote: >> On 05/30/2018 10:10 AM, Peter Enderborg wrote: >>> The boolean change becomes a lot more heavy with this patch, >>> but it is a very rare usage in compare with read only operations. >>> The lock held

Re: [PATCH V3 3/5 selinux-next] selinux: sidtab_clone switch to use rwlock.

2018-05-31 Thread J Freyensee
+int sidtab_clone(struct sidtab *s, struct sidtab *d) +{ + int i, rc = 0; If s or d are NULL (see if() below), why would we want rc, the return value, to be 0?  How about defaulting rc to an error value (-EINVAL)? + struct sidtab_node *cur; + + if (!s || !d) +

Re: [PATCH] restorecond: Fix consistancy of DESTDIR usage

2018-05-31 Thread Laurent Bigonville
Le 30/05/18 à 22:19, Nicolas Iooss a écrit : On Tue, May 29, 2018 at 9:29 AM, Laurent Bigonville wrote: From: Laurent Bigonville --- restorecond/Makefile | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/restorecond/Makefile b/restorecond/Makefile index

Re: [PATCH V3 0/5] selinux:Significant reduce of preempt_disable holds

2018-05-31 Thread Stephen Smalley
On 05/31/2018 10:21 AM, Stephen Smalley wrote: > On 05/31/2018 10:12 AM, peter enderborg wrote: >> On 05/31/2018 02:42 PM, Stephen Smalley wrote: >>> On 05/31/2018 05:04 AM, peter enderborg wrote: On 05/30/2018 10:34 PM, Stephen Smalley wrote: > On 05/30/2018 10:10 AM, Peter Enderborg

Re: [PATCH] selinux-testsuite: Add SCTP test support

2018-05-31 Thread Richard Haines via Selinux
On Wed, 2018-05-30 at 16:42 -0400, Paul Moore wrote: > On Tue, Mar 20, 2018 at 1:48 PM, Richard Haines via Selinux > wrote: > > The sctp testsuite tests all new sctp SELinux functionality. > > > > Signed-off-by: Richard Haines > > Now that the new SELinux userspace is out, I applied this to my

Re: [PATCH V3 0/5] selinux:Significant reduce of preempt_disable holds

2018-05-31 Thread peter enderborg
On 05/31/2018 02:42 PM, Stephen Smalley wrote: > On 05/31/2018 05:04 AM, peter enderborg wrote: >> On 05/30/2018 10:34 PM, Stephen Smalley wrote: >>> On 05/30/2018 10:10 AM, Peter Enderborg wrote: The boolean change becomes a lot more heavy with this patch, but it is a very rare usage in

Re: [PATCH V3 0/5] selinux:Significant reduce of preempt_disable holds

2018-05-31 Thread Stephen Smalley
On 05/31/2018 10:12 AM, peter enderborg wrote: > On 05/31/2018 02:42 PM, Stephen Smalley wrote: >> On 05/31/2018 05:04 AM, peter enderborg wrote: >>> On 05/30/2018 10:34 PM, Stephen Smalley wrote: On 05/30/2018 10:10 AM, Peter Enderborg wrote: > The boolean change becomes a lot more heavy

[PATCH] restorecond: Fix consistancy of DESTDIR usage

2018-05-31 Thread Laurent Bigonville
From: Laurent Bigonville --- restorecond/Makefile | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/restorecond/Makefile b/restorecond/Makefile index 25be18d4..8a0ada1f 100644 --- a/restorecond/Makefile +++ b/restorecond/Makefile @@ -9,8 +9,8 @@ DBUSSERVICEDIR =

Re: [PATCH] restorecond: Fix consistancy of DESTDIR usage

2018-05-31 Thread Nicolas Iooss
On Thu, May 31, 2018 at 3:18 PM, Laurent Bigonville wrote: > From: Laurent Bigonville > > --- > restorecond/Makefile | 14 +++--- > 1 file changed, 7 insertions(+), 7 deletions(-) > > diff --git a/restorecond/Makefile b/restorecond/Makefile > index 25be18d4..8a0ada1f 100644 > ---