Re: [PATCH 10/13] selinux: Cleanup printk logging in netport

[Paul Moore]

On Tue, Jun 12, 2018 at 4:09 AM Peter Enderborg
 wrote:
>
> Replace printk with pr_* to avoid checkpatch warnings.
>
> Signed-off-by: Peter Enderborg 
> ---
>  security/selinux/netport.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)

Merged, thanks.

> diff --git a/security/selinux/netport.c b/security/selinux/netport.c
> index 9ed4c5064a5e..7a141cadbffc 100644
> --- a/security/selinux/netport.c
> +++ b/security/selinux/netport.c
> @@ -173,9 +173,8 @@ static int sel_netport_sid_slow(u8 protocol, u16 pnum, 
> u32 *sid)
>  out:
> spin_unlock_bh(_netport_lock);
> if (unlikely(ret)) {
> -   printk(KERN_WARNING
> -  "SELinux: failure in sel_netport_sid_slow(),"
> -  " unable to determine network port label\n");
> +   pr_warn("SELinux: failure in %s(), unable to determine 
> network port label\n",
> +   __func__);
> kfree(new);
> }
> return ret;
> --
> 2.15.1

-- 
paul moore
www.paul-moore.com

___
Selinux mailing list
Selinux@tycho.nsa.gov
To unsubscribe, send email to selinux-le...@tycho.nsa.gov.
To get help, send an email containing "help" to selinux-requ...@tycho.nsa.gov.

[PATCH 10/13] selinux: Cleanup printk logging in netport

[Peter Enderborg]

Replace printk with pr_* to avoid checkpatch warnings.

Signed-off-by: Peter Enderborg 
---
 security/selinux/netport.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/security/selinux/netport.c b/security/selinux/netport.c
index 9ed4c5064a5e..7a141cadbffc 100644
--- a/security/selinux/netport.c
+++ b/security/selinux/netport.c
@@ -173,9 +173,8 @@ static int sel_netport_sid_slow(u8 protocol, u16 pnum, u32 
*sid)
 out:
spin_unlock_bh(_netport_lock);
if (unlikely(ret)) {
-   printk(KERN_WARNING
-  "SELinux: failure in sel_netport_sid_slow(),"
-  " unable to determine network port label\n");
+   pr_warn("SELinux: failure in %s(), unable to determine network 
port label\n",
+   __func__);
kfree(new);
}
return ret;
-- 
2.15.1


___
Selinux mailing list
Selinux@tycho.nsa.gov
To unsubscribe, send email to selinux-le...@tycho.nsa.gov.
To get help, send an email containing "help" to selinux-requ...@tycho.nsa.gov.