Re: Minor bash completion update for semanage ports

[William Roberts]

On Mon, Feb 12, 2018 at 5:58 PM, Lee Stubbs  wrote:
> Based on the semanage-port documentation, I believe the semanage ports type
> bash autocompletion may be missing a '-'. Please see the attached patch file

This isn't how we take patches on the list, please use git send-email.

With that said, the patch looks fine, please resend with git send-email

> for a possible update.
>
> -Lee



-- 
Respectfully,

William C Roberts

Minor bash completion update for semanage ports

[Lee Stubbs]

Based on the semanage-port documentation, I believe the semanage ports type
bash autocompletion may be missing a '-'. Please see the attached patch
file for a possible update.

-Lee
From 064409c216c8f64c30f40f507cacf15f16672e50 Mon Sep 17 00:00:00 2001
From: Lee Stubbs 
Date: Mon, 12 Feb 2018 20:49:03 -0500
Subject: [PATCH] Minor update for bash completion. Bash completion for ports
 is missing '-' for type. Based on documentation, it should be --type, not
 -type.

---
 python/semanage/semanage-bash-completion.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/python/semanage/semanage-bash-completion.sh 
b/python/semanage/semanage-bash-completion.sh
index 6b53292..2d811c9 100644
--- a/python/semanage/semanage-bash-completion.sh
+++ b/python/semanage/semanage-bash-completion.sh
@@ -59,7 +59,7 @@ __get_export_opts () { echo '$ALL_OPTS --f --output_file' ; }
 __get_boolean_opts () { echo '$ALL_OPTS --on -off -1 -0' ; }
 __get_user_opts () { echo '$ALL_OPTS $MANAGED_OPTS -L --level -r --range -R 
--role '; }
 __get_login_opts () { echo '$ALL_OPTS $MANAGED_OPTS -s --seuser -r --range'; }
-__get_port_opts () { echo '$ALL_OPTS $MANAGED_OPTS -t -type -r --range -p 
--proto'; }
+__get_port_opts () { echo '$ALL_OPTS $MANAGED_OPTS -t --type -r --range -p 
--proto'; }
 __get_interface_opts () { echo '$ALL_OPTS $MANAGED_OPTS -t --type '; }
 __get_node_opts () { echo '$ALL_OPTS $MANAGED_OPTS -t --type -M --mask -p 
--proto'; }
 __get_fcontext_opts () { echo '$ALL_OPTS $MANAGED_OPTS -t --type -e --equal -f 
--ftype '; }
-- 
2.2.1