Re: [PATCH] selinux: stricter parsing in mls_context_to_sid()

2018-08-06 Thread Jann Horn via Selinux
On Sat, Aug 4, 2018 at 2:01 AM Paul Moore wrote: > > On Fri, Aug 3, 2018 at 5:36 AM Jann Horn wrote: > > > > mls_context_to_sid incorrectly accepted MLS context strings that are > > followed by a dash and trailing garbage. > > > > Before this change, the following command works: > > > > # mount

Re: [PATCH] selinux: stricter parsing in mls_context_to_sid()

2018-08-06 Thread Stephen Smalley
On 08/03/2018 05:36 AM, Jann Horn wrote: mls_context_to_sid incorrectly accepted MLS context strings that are followed by a dash and trailing garbage. Before this change, the following command works: # mount -t tmpfs -o 'context=system_u:object_r:tmp_t:s0-s0:c0-BLAH' \ none mount After this

Re: [PATCH] selinux: stricter parsing in mls_context_to_sid()

2018-08-03 Thread Paul Moore
On Fri, Aug 3, 2018 at 5:36 AM Jann Horn wrote: > > mls_context_to_sid incorrectly accepted MLS context strings that are > followed by a dash and trailing garbage. > > Before this change, the following command works: > > # mount -t tmpfs -o 'context=system_u:object_r:tmp_t:s0-s0:c0-BLAH' \ > none

[PATCH] selinux: stricter parsing in mls_context_to_sid()

2018-08-03 Thread Jann Horn via Selinux
mls_context_to_sid incorrectly accepted MLS context strings that are followed by a dash and trailing garbage. Before this change, the following command works: # mount -t tmpfs -o 'context=system_u:object_r:tmp_t:s0-s0:c0-BLAH' \ none mount After this change, it fails with the following error