Re: [PATCH] selinux: move user accesses in selinuxfs out of locked regions

2018-07-02 Thread Jann Horn via Selinux
On Fri, Jun 29, 2018 at 2:38 AM Paul Moore wrote: > > On Thu, Jun 28, 2018 at 8:23 PM Paul Moore wrote: > > On Tue, Jun 26, 2018 at 8:15 AM Stephen Smalley wrote: > > > On 06/25/2018 12:34 PM, Jann Horn wrote: > > > > If a user is accessing a file in selinuxfs with a pointer to a userspace > >

Re: [PATCH] selinux: move user accesses in selinuxfs out of locked regions

2018-06-28 Thread Paul Moore
On Thu, Jun 28, 2018 at 8:38 PM Paul Moore wrote: > On Thu, Jun 28, 2018 at 8:23 PM Paul Moore wrote: > > On Tue, Jun 26, 2018 at 8:15 AM Stephen Smalley wrote: > > > On 06/25/2018 12:34 PM, Jann Horn wrote: > > > > If a user is accessing a file in selinuxfs with a pointer to a userspace > > >

Re: [PATCH] selinux: move user accesses in selinuxfs out of locked regions

2018-06-28 Thread Paul Moore
On Thu, Jun 28, 2018 at 8:23 PM Paul Moore wrote: > On Tue, Jun 26, 2018 at 8:15 AM Stephen Smalley wrote: > > On 06/25/2018 12:34 PM, Jann Horn wrote: > > > If a user is accessing a file in selinuxfs with a pointer to a userspace > > > buffer that is backed by e.g. a userfaultfd, the userspace

Re: [PATCH] selinux: move user accesses in selinuxfs out of locked regions

2018-06-28 Thread Paul Moore
On Tue, Jun 26, 2018 at 8:15 AM Stephen Smalley wrote: > On 06/25/2018 12:34 PM, Jann Horn wrote: > > If a user is accessing a file in selinuxfs with a pointer to a userspace > > buffer that is backed by e.g. a userfaultfd, the userspace access can > > stall indefinitely, which can block

Re: [PATCH] selinux: move user accesses in selinuxfs out of locked regions

2018-06-28 Thread Paul Moore
On Mon, Jun 25, 2018 at 6:40 PM Jann Horn wrote: > > On Tue, Jun 26, 2018 at 12:36 AM Paul Moore wrote: > > > > On Mon, Jun 25, 2018 at 12:34 PM Jann Horn wrote: > > > If a user is accessing a file in selinuxfs with a pointer to a userspace > > > buffer that is backed by e.g. a userfaultfd, the

Re: [PATCH] selinux: move user accesses in selinuxfs out of locked regions

2018-06-26 Thread Stephen Smalley
On 06/26/2018 08:42 AM, Jann Horn wrote: > On Tue, Jun 26, 2018 at 2:15 PM Stephen Smalley wrote: >> >> On 06/25/2018 12:34 PM, Jann Horn wrote: >>> If a user is accessing a file in selinuxfs with a pointer to a userspace >>> buffer that is backed by e.g. a userfaultfd, the userspace access can

Re: [PATCH] selinux: move user accesses in selinuxfs out of locked regions

2018-06-26 Thread Jann Horn via Selinux
On Tue, Jun 26, 2018 at 2:15 PM Stephen Smalley wrote: > > On 06/25/2018 12:34 PM, Jann Horn wrote: > > If a user is accessing a file in selinuxfs with a pointer to a userspace > > buffer that is backed by e.g. a userfaultfd, the userspace access can > > stall indefinitely, which can block

Re: [PATCH] selinux: move user accesses in selinuxfs out of locked regions

2018-06-26 Thread Stephen Smalley
On 06/25/2018 12:34 PM, Jann Horn wrote: > If a user is accessing a file in selinuxfs with a pointer to a userspace > buffer that is backed by e.g. a userfaultfd, the userspace access can > stall indefinitely, which can block fsi->mutex if it is held. > > For sel_read_policy(), remove the

Re: [PATCH] selinux: move user accesses in selinuxfs out of locked regions

2018-06-26 Thread Jann Horn via Selinux
On Tue, Jun 26, 2018 at 12:36 AM Paul Moore wrote: > > On Mon, Jun 25, 2018 at 12:34 PM Jann Horn wrote: > > If a user is accessing a file in selinuxfs with a pointer to a userspace > > buffer that is backed by e.g. a userfaultfd, the userspace access can > > stall indefinitely, which can block

Re: [PATCH] selinux: move user accesses in selinuxfs out of locked regions

2018-06-25 Thread Paul Moore
On Mon, Jun 25, 2018 at 12:34 PM Jann Horn wrote: > If a user is accessing a file in selinuxfs with a pointer to a userspace > buffer that is backed by e.g. a userfaultfd, the userspace access can > stall indefinitely, which can block fsi->mutex if it is held. > > For sel_read_policy(), remove