Re: [PATCH 5/5] libselinux: remove unused variable usercon

2018-04-16 Thread jwcart2
On 04/16/2018 11:30 AM, William Roberts wrote: On Mon, Apr 16, 2018 at 5:34 AM, Stephen Smalley wrote: On 04/13/2018 08:40 PM, William Roberts wrote: In general this series looks fine. However, checkpatch.pl is complaining about DOS line endings in your patches: For example: ERROR: DOS line

Re: [PATCH 5/5] libselinux: remove unused variable usercon

2018-04-16 Thread William Roberts
On Mon, Apr 16, 2018 at 5:34 AM, Stephen Smalley wrote: > On 04/13/2018 08:40 PM, William Roberts wrote: >> In general this series looks fine. >> >> However, checkpatch.pl is complaining about DOS line endings in your patches: >> >> For example: >> ERROR: DOS line endings >> #325: FILE: libselinux

Re: [PATCH 5/5] libselinux: remove unused variable usercon

2018-04-16 Thread Stephen Smalley
On 04/13/2018 08:40 PM, William Roberts wrote: > In general this series looks fine. > > However, checkpatch.pl is complaining about DOS line endings in your patches: > > For example: > ERROR: DOS line endings > #325: FILE: libselinux/src/label_file.h:281: > +^I^Iint alloc_stems = data->alloc_stem

Re: [PATCH 5/5] libselinux: remove unused variable usercon

2018-04-14 Thread Nicolas Iooss
On Sat, Apr 14, 2018 at 2:40 AM, William Roberts wrote: > In general this series looks fine. > > However, checkpatch.pl is complaining about DOS line endings in your patches: > > For example: > ERROR: DOS line endings > #325: FILE: libselinux/src/label_file.h:281: > +^I^Iint alloc_stems = data->al

Re: [PATCH 5/5] libselinux: remove unused variable usercon

2018-04-13 Thread William Roberts
In general this series looks fine. However, checkpatch.pl is complaining about DOS line endings in your patches: For example: ERROR: DOS line endings #325: FILE: libselinux/src/label_file.h:281: +^I^Iint alloc_stems = data->alloc_stems * 2 + 16;^M$ On Fri, Apr 13, 2018 at 1:34 PM, Nicolas Io