Yep, I've added setApprovedRevForParsing function and related hooks into
REL1_25 ApprovedRevs ( slightly modified - removed $alreadyRun check )
and it works fine.
11.05.2016 3:46, Yaron Koren пишет:
> Hi Vedmaka,
>
> Ah, interesting. The change you're talking about is this one, from 2013:
>
> ht
Hi Vedmaka,
Ah, interesting. The change you're talking about is this one, from 2013:
https://git.wikimedia.org/commit/mediawiki%2Fextensions%2FApprovedRevs.git/01eb9f11db32c9ec365cdb5251c80ebea2da40d4
...and that change is based on this patch:
https://www.mediawiki.org/wiki/Extension_talk:Appro
After some more spent on investigation i must conclude that, generally,
there is no reason semantic properties in not-approved pages for not to
appear. They should appear, because no one stops them.
I guess things broken in REL1_21 branch of ApprovedRevs when
$wgHooks['ParserBeforeInternalParse
Ok, so, here are my results:
I am not sure why this is happening, but it is definitely happening:
1. In ApprovedRevsHooks::setSearchText there is
ApprovedRevs::getApprovedRevID called
2. in ApprovedRevs::getApprovedRevID $dbr->selectField( .. ) called (
only first time, then cached in self::$mA
Hey Yaron, thanks for a lightning speed response :)
Yep, page is displaying correctly (blank), but i am able to find it by
searching its contents via search (huh?).
I made some quick debug and figured out that
ApprovedRevsHooks::updateLinksAfterEdit
properly sends empty $text to LinksUpdate, h
That's certainly not intended behavior. Is the page displaying correctly,
i.e. blank? And can you find by searching on its contents from
Special:Search? (Hopefully not.)
Also, I'd recommend upgrading to the latest Approved Revs version, 0.7.1 -
who knows, that might be a bug that got fixed.
On Fr
Hi, Guys!
I did not touch ApprovedRevs for long time, so, maybe, I forgot some
details, but recently i was surprised a bit:
I am using MW 1.25.1 + SMW 2.3.1 + ApprovedRevs 0.7 (REL1_25 branch)
ApprovedRevs configured with $egApprovedRevsBlankIfUnapproved = true;
Once i create or edit page (as n