Re: [SMW-devel] Exceptions in SMW

2013-07-30 Thread Jeroen De Dauw
Hey, For example, currently only 33.33 of the SMW code base is covered > which means anyone who cares is surely invited to pitch in. > Thanks for working on this James! And indeed, contributions here are much appreciated. PS: When relying on InvalidArgumentException you get an error message > ou

Re: [SMW-devel] Exceptions in SMW

2013-07-23 Thread James HK
Hi, Well, it was mainly me because the DataItemException and other generic exceptions were itching me for some time especially during unit testing. I deliberately choose MWException as deriving class for the time being because a lot of work needs to be done in order to get SMW to a stage where uni

[SMW-devel] Exceptions in SMW

2013-07-23 Thread Jeroen De Dauw
Hey, I noticed some work was done on exceptions in SMW recently - nice :) A few thoughts on how it can be further improved: Right now they all derive from MWException, not sure what good this does. This creates binding to MW all over the place, while this is probably not needed anywhere. At lea