Re: [SMW-devel] SMW/GraphViz interop bug

2014-11-29 Thread Keith Welter
James, thanks for the prompt reply. I'm satisfied that disabling the SMW hooks when GraphViz does an upload will have no bad consequences because GraphViz does not supply any page text on this code path. A user could edit the file page after the upload is complete and supply page text/annotations

Re: [SMW-devel] SMW/GraphViz interop bug

2014-11-29 Thread James HK
Hi, This may be of interest, Stephan run into a similar `Parser->lock` issue on MW 1.24 with SF (see [0]). [0] https://github.com/WikiApiary/WikiApiary/issues/209#issuecomment-64195735 Cheers On 11/30/14, James HK wrote: > Hi, > > Just to clarify, NewRevisionFromEditComplete does not have (or

Re: [SMW-devel] SMW/GraphViz interop bug

2014-11-29 Thread James HK
Hi, Just to clarify, NewRevisionFromEditComplete does not have (or for that matter makes) access to the Parser directly and relies on the information provided by WikitextContent::prepareContentForEdit object. Whether WikitextContent::prepareContentForEdit returns an `editinfo` object from a cached

[SMW-devel] SMW/GraphViz interop bug

2014-11-29 Thread Keith Welter
Hi, I'm looking for some input on a fix I wrote for an SMW/GraphViz interop bug (phabricator T75073 ). To recap the bug: 1. The GraphViz extension uploaded a file (a graph image) from the context of a Parser::parse call. 2. The upload triggered