Re: Should Sequel continue shipping tests in the gem?

2020-01-31 Thread Jeremy Evans
On Saturday, January 18, 2020 at 11:27:50 AM UTC-8, Jeremy Evans wrote: > > Sequel has always shipped tests in the gem, so that users and packagers > can test it without cloning the repository, but it does make the gem > significantly larger. I'm open to feedback on whether Sequel should >

Re: Should Sequel continue shipping tests in the gem?

2020-01-19 Thread Adam Daniels
No strong feelings either way; when I run Sequel tests I'm normally authoring a patch, which means I have the git repository anyways. I have to wonder how frequently the tests in the gem are being run tho. That said, I can imagine the tests in something with a C extension (such as sequel_pg)

Re: Should Sequel continue shipping tests in the gem?

2020-01-19 Thread abhijit nandy
I've never run the Sequel tests, so I'm fine with them not being included in the gem. The source can anyway be downloaded if testing is to be done. - Abhijit. On Sun, Jan 19, 2020 at 12:57 AM Jeremy Evans wrote: > Sequel has always shipped tests in the gem, so that users and packagers > can

Re: Should Sequel continue shipping tests in the gem?

2020-01-19 Thread Marcelo Pereira
I would guess most of the time users are not running Sequel tests and, if one wants to run them, it's simple enough to clone the repository - so I would say not shipping the tests sounds like a good idea. No strong opinions on this one, though - having the tests in the gem is, of course, not a

Should Sequel continue shipping tests in the gem?

2020-01-18 Thread Jeremy Evans
Sequel has always shipped tests in the gem, so that users and packagers can test it without cloning the repository, but it does make the gem significantly larger. I'm open to feedback on whether Sequel should continue to do this, so if you feel strongly one way or the other, please respond.