OK
So AbstractStoreMessageManager doesn't implement MessageMapper (and it
was in your javadoc :)
... and implements Mailbox (the org.apache.james.imap.mailbox.Mailbox,
not the org.apache.james.imap.store.mail.model.Mailbox...)
The org.apache.james.imap.mailbox.Mailbox has much too do with
Comments inline..
2010/8/20 Eric Charles e...@apache.org:
OK
So AbstractStoreMessageManager doesn't implement MessageMapper (and it was
in your javadoc :)
... and implements Mailbox (the org.apache.james.imap.mailbox.Mailbox, not
the org.apache.james.imap.store.mail.model.Mailbox...)
yep
Hi Norman,
The following hierarchy is obvious and gives services such as create,
login, logout, search on *mailboxes*:
MailboxManager (interface)
/|\
|
DelegatingMailboxManagerimpl (abstract)
/|\
|
StoreMailboxManager (abstract)
Author: eric
Date: Fri Aug 20 14:15:50 2010
New Revision: 987516
URL: http://svn.apache.org/viewvc?rev=987516view=rev
Log:
Add svn:ignore property.
Modified:
james/imap/trunk/maildir/ (props changed)
Propchange: james/imap/trunk/maildir/
Hi guys,
I began looking into the API stuff. I'd like to simplify the Mapper
hierarchy, which however will have no direct impact on the API. Will
upload a patch tomorrow.
I agree, we should name the interface MessageManager, that's what I
thought.
The proposal_v3 is reasonable, I think. To make
Hi All,
Comments inside.
Tks,
Eric
On 08/20/2010 04:53 PM, Tim-Christian Mundt wrote:
Hi guys,
I began looking into the API stuff. I'd like to simplify the Mapper
hierarchy, which however will have no direct impact on the API. Will
upload a patch tomorrow.
Will look at it :)
I agree, we
Ok so its seems like you like the proposal_v3 so far (just minor
naming changes etc). I will commit it then and try to improve the
javadocs a bit etc..
Thx for the review..
Bye,
Norman
2010/8/20 Eric Charles e...@apache.org:
Hi All,
Comments inside.
Tks,
Eric
On 08/20/2010 04:53 PM,
Author: norman
Date: Fri Aug 20 19:59:37 2010
New Revision: 987620
URL: http://svn.apache.org/viewvc?rev=987620view=rev
Log:
Add javadocs/license header
Modified:
james/imap/trunk/store/src/main/java/org/apache/james/imap/store/UpdatedFlag.java
Modified:
Author: norman
Date: Fri Aug 20 20:07:01 2010
New Revision: 987624
URL: http://svn.apache.org/viewvc?rev=987624view=rev
Log:
Add new abstract class which allow to easy write a Mailbox implementation and
not depend on the MessageMapper (IMAP-202)
Modified:
