svn commit: r1049799 - in /james/server/trunk: ./ core-api/src/main/java/org/apache/james/repository/ core-library/ core-library/src/main/java/org/apache/james/filepair/ mail-file/ mail-file/src/main/

2010-12-15 Thread norman
Author: norman Date: Thu Dec 16 07:36:25 2010 New Revision: 1049799 URL: http://svn.apache.org/viewvc?rev=1049799&view=rev Log: create new maven module called repository-api and move the interfaces from module core-api to it Added: james/server/trunk/repository-api/ james/server/trunk/r

svn commit: r1049795 - in /james/server/trunk: domainlist-jpa/pom.xml domainlist-xml/pom.xml pop3server/pom.xml remotemanager/pom.xml smtpserver/pom.xml user-jcr/pom.xml user-jpa/pom.xml

2010-12-15 Thread norman
Author: norman Date: Thu Dec 16 07:24:12 2010 New Revision: 1049795 URL: http://svn.apache.org/viewvc?rev=1049795&view=rev Log: some more dependency cleanup Modified: james/server/trunk/domainlist-jpa/pom.xml james/server/trunk/domainlist-xml/pom.xml james/server/trunk/pop3server/pom.

[PROPOSAL] Remove UsersStore in favor of just allow one UsersRepository to use

2010-12-15 Thread Norman Maurer
Hi there, as we are currently doing last changes in the API before the next release I would like to get rid of the UsersStore interface and implementation. Here some background: In previous version of James Server we allowed to configure more then one UsersRepository and lookup each by its uniqu

[jira] Created: (JAMES-1149) Replace commons-logging with jcl-over-slf4j

2010-12-15 Thread Norman Maurer (JIRA)
Replace commons-logging with jcl-over-slf4j --- Key: JAMES-1149 URL: https://issues.apache.org/jira/browse/JAMES-1149 Project: JAMES Server Issue Type: Task Affects Versions: 3.0-M2 Rep

[jira] Resolved: (JAMES-1147) Remove MailServer interface and move the methods to other Interfaces

2010-12-15 Thread Norman Maurer (JIRA)
[ https://issues.apache.org/jira/browse/JAMES-1147?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Norman Maurer resolved JAMES-1147. -- Resolution: Fixed done > Remove MailServer interface and move the methods to other Interfaces

svn commit: r1049677 - in /james/server/trunk/core-library/src: main/java/org/apache/james/services/AbstractJSR250InstanceFactory.java test/java/org/apache/james/services/AbstractJSR250InstanceFactory

2010-12-15 Thread norman
Author: norman Date: Wed Dec 15 19:41:19 2010 New Revision: 1049677 URL: http://svn.apache.org/viewvc?rev=1049677&view=rev Log: Move over to test jar as its only used in tests Added: james/server/trunk/core-library/src/test/java/org/apache/james/services/AbstractJSR250InstanceFactory.java

Re: [PROPOSAL] MailServer interface make sense / Move methods ?

2010-12-15 Thread Norman Maurer
2010/12/15 Stefano Bagnara : >>> What about moving to virtual hosting as the default (and maybe the ONLY) >>> option? >>> When you setup a mailserver you have a domain, I think it is easier to >>> understand for newbies if they create users with their full email >>> address instead of using simple

Re: svn commit: r1049622 - in /james/imap/trunk: api/src/main/java/org/apache/james/imap/api/ api/src/main/java/org/apache/james/imap/api/display/ message/src/main/java/org/apache/james/imap/decode/ m

2010-12-15 Thread Norman Maurer
Hi Niklas, comments inside :) 2010/12/15 Niklas Therning : > Hi, > > The synchronized block is actually there to prevent concurrent access to the > responder object. I realize that may not be very clear. :-) Initially I had > a synchronized block around the whole > >  if (!"DONE".equals(...)) {

Re: svn commit: r1049622 - in /james/imap/trunk: api/src/main/java/org/apache/james/imap/api/ api/src/main/java/org/apache/james/imap/api/display/ message/src/main/java/org/apache/james/imap/decode/ m

2010-12-15 Thread Niklas Therning
Hi, The synchronized block is actually there to prevent concurrent access to the responder object. I realize that may not be very clear. :-) Initially I had a synchronized block around the whole if (!"DONE".equals(...)) { ... } else { ... } block but then I realized that it was

svn commit: r1049622 - in /james/imap/trunk: api/src/main/java/org/apache/james/imap/api/ api/src/main/java/org/apache/james/imap/api/display/ message/src/main/java/org/apache/james/imap/decode/ messa

2010-12-15 Thread niklas
Author: niklas Date: Wed Dec 15 16:00:25 2010 New Revision: 1049622 URL: http://svn.apache.org/viewvc?rev=1049622&view=rev Log: Added initial support for IDLE (IMAP-239). Added: james/imap/trunk/api/src/main/java/org/apache/james/imap/api/ContinuationReader.java james/imap/trunk/message

Re: svn commit: r1049622 - in /james/imap/trunk: api/src/main/java/org/apache/james/imap/api/ api/src/main/java/org/apache/james/imap/api/display/ message/src/main/java/org/apache/james/imap/decode/ m

2010-12-15 Thread Norman Maurer
Just a minor comment from a quick review. The synchronized(session) should be removed.. You use an AtomicBoolean so you should be safe here.. Will have a deeper look later Bye, Nomrna 2010/12/15 : > Author: niklas > Date: Wed Dec 15 16:00:25 2010 > New Revision: 1049622 > > URL: http://svn.ap

[jira] Created: (IMAP-239) Implement IDLE

2010-12-15 Thread Niklas Therning (JIRA)
Implement IDLE -- Key: IMAP-239 URL: https://issues.apache.org/jira/browse/IMAP-239 Project: JAMES Imap Issue Type: New Feature Components: Protocol Reporter: Niklas Therning Assignee: Niklas The

svn commit: r1049608 - /james/server/trunk/user-jcr/pom.xml

2010-12-15 Thread norman
Author: norman Date: Wed Dec 15 15:52:06 2010 New Revision: 1049608 URL: http://svn.apache.org/viewvc?rev=1049608&view=rev Log: Fix dependency Modified: james/server/trunk/user-jcr/pom.xml Modified: james/server/trunk/user-jcr/pom.xml URL: http://svn.apache.org/viewvc/james/server/trunk/use

svn commit: r1049599 - /james/server/trunk/core-library/pom.xml

2010-12-15 Thread norman
Author: norman Date: Wed Dec 15 15:48:46 2010 New Revision: 1049599 URL: http://svn.apache.org/viewvc?rev=1049599&view=rev Log: Fix dependency Modified: james/server/trunk/core-library/pom.xml Modified: james/server/trunk/core-library/pom.xml URL: http://svn.apache.org/viewvc/james/server/t

svn commit: r1049598 - in /james/server/trunk: core-api/ core-library/ domainlist-jdbc/ domainlist-jpa/ domainlist-library/ domainlist-xml/ fetchmail/ lmtpserver/ mailbox-adapter/ mailetcontainer-libr

2010-12-15 Thread norman
Author: norman Date: Wed Dec 15 15:48:06 2010 New Revision: 1049598 URL: http://svn.apache.org/viewvc?rev=1049598&view=rev Log: Dependency cleanup Modified: james/server/trunk/core-api/pom.xml james/server/trunk/core-library/pom.xml james/server/trunk/domainlist-jdbc/pom.xml james

svn commit: r1049587 - in /james/server/trunk: container-spring/src/main/config/examples/ container-spring/src/main/config/james/ container-spring/src/main/config/james/context/ fetchmail/src/main/jav

2010-12-15 Thread norman
Author: norman Date: Wed Dec 15 15:21:49 2010 New Revision: 1049587 URL: http://svn.apache.org/viewvc?rev=1049587&view=rev Log: Use a JMX enabled ScheduledThreadPool in FetchMail so we can get some more stats. See JAMES-1057 Added: james/server/trunk/util/src/main/java/org/apache/james/util

svn commit: r1049581 - /james/server/trunk/pop3server/src/main/java/org/apache/james/pop3server/netty/POP3NettySession.java

2010-12-15 Thread norman
Author: norman Date: Wed Dec 15 15:10:40 2010 New Revision: 1049581 URL: http://svn.apache.org/viewvc?rev=1049581&view=rev Log: Remove unused import Modified: james/server/trunk/pop3server/src/main/java/org/apache/james/pop3server/netty/POP3NettySession.java Modified: james/server/trunk/po

svn commit: r1049570 - in /james/server/trunk: imapserver/src/main/java/org/apache/james/imapserver/netty/ nio-netty/src/main/java/org/apache/james/server/netty/ pop3server/src/main/java/org/apache/ja

2010-12-15 Thread norman
Author: norman Date: Wed Dec 15 14:45:34 2010 New Revision: 1049570 URL: http://svn.apache.org/viewvc?rev=1049570&view=rev Log: Move classes which are only used by the imapserver to the imapserver module Added: james/server/trunk/imapserver/src/main/java/org/apache/james/imapserver/netty/Blo

svn commit: r1049567 - in /james/server/trunk: container-spring/src/main/config/james/context/james-server-context.xml nio-netty/pom.xml

2010-12-15 Thread norman
Author: norman Date: Wed Dec 15 14:42:42 2010 New Revision: 1049567 URL: http://svn.apache.org/viewvc?rev=1049567&view=rev Log: finish rename of netty-socket to nio-netty Modified: james/server/trunk/container-spring/src/main/config/james/context/james-server-context.xml james/server/tru

Re: IMAP - Implementing IDLE

2010-12-15 Thread Norman Maurer
Just interested is it this one : http://tools.ietf.org/html/rfc2177 ? Bye, Norman 2010/12/15 Norman Maurer : > Hi Niklas, > > nice to see you got involved in the IMAP code :). In JAMES we follow > the CTR princip, so as you already have write access I think you > should just go ahead and commi

svn commit: r1049562 - /james/server/trunk/nio-netty/src/main/java/org/jboss/

2010-12-15 Thread norman
Author: norman Date: Wed Dec 15 14:33:42 2010 New Revision: 1049562 URL: http://svn.apache.org/viewvc?rev=1049562&view=rev Log: Remove empty package Removed: james/server/trunk/nio-netty/src/main/java/org/jboss/ - To unsubs

svn commit: r1049561 - in /james/server/trunk/nio-netty/src/main/java/org: apache/james/server/ apache/james/server/jmx/ apache/james/server/netty/ apache/james/socket/ jboss/netty/handler/stream/

2010-12-15 Thread norman
Author: norman Date: Wed Dec 15 14:32:06 2010 New Revision: 1049561 URL: http://svn.apache.org/viewvc?rev=1049561&view=rev Log: package moving Added: james/server/trunk/nio-netty/src/main/java/org/apache/james/server/jmx/ james/server/trunk/nio-netty/src/main/java/org/apache/james/serve

svn commit: r1049560 - in /james/server/trunk/nio-netty/src/main/java/org: apache/james/server/ apache/james/server/netty/ apache/james/socket/ apache/james/socket/netty/ jboss/netty/handler/stream/

2010-12-15 Thread norman
Author: norman Date: Wed Dec 15 14:28:47 2010 New Revision: 1049560 URL: http://svn.apache.org/viewvc?rev=1049560&view=rev Log: package moving Added: james/server/trunk/nio-netty/src/main/java/org/apache/james/server/ james/server/trunk/nio-netty/src/main/java/org/apache/james/server/Ab

svn commit: r1049559 - in /james/server/trunk: ./ container-spring/ imapserver/ imapserver/src/main/java/org/apache/james/imapserver/netty/ lmtpserver/ lmtpserver/src/main/java/org/apache/james/lmtpse

2010-12-15 Thread norman
Author: norman Date: Wed Dec 15 14:26:02 2010 New Revision: 1049559 URL: http://svn.apache.org/viewvc?rev=1049559&view=rev Log: Rename netty-socket to nio-netty to be more inline with current naming Added: james/server/trunk/nio-netty/ - copied from r1049463, james/server/trunk/netty-so

svn commit: r1049555 - in /james/server/trunk: container-spring/pom.xml core-function/ pom.xml

2010-12-15 Thread norman
Author: norman Date: Wed Dec 15 14:01:30 2010 New Revision: 1049555 URL: http://svn.apache.org/viewvc?rev=1049555&view=rev Log: Remove core-function as it is empty now Removed: james/server/trunk/core-function/ Modified: james/server/trunk/container-spring/pom.xml james/server/trunk/p

[jira] Resolved: (JAMES-1148) Move SpoolManager to mailetcontainer modules

2010-12-15 Thread Norman Maurer (JIRA)
[ https://issues.apache.org/jira/browse/JAMES-1148?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Norman Maurer resolved JAMES-1148. -- Resolution: Fixed done > Move SpoolManager to mailetcontainer modules > --

svn commit: r1049554 - in /james/server/trunk: container-spring/src/main/config/james/context/ core-api/src/main/java/org/apache/james/services/ core-function/src/main/java/org/apache/james/transport/

2010-12-15 Thread norman
Author: norman Date: Wed Dec 15 13:53:59 2010 New Revision: 1049554 URL: http://svn.apache.org/viewvc?rev=1049554&view=rev Log: Rename SpoolManager to MailSpooler and move the interface from core-api to mailetcontainer-api. The implementation was moved from core-function to mailetcontainer-libra

[jira] Created: (JAMES-1148) Move SpoolManager to mailetcontainer modules

2010-12-15 Thread Norman Maurer (JIRA)
Move SpoolManager to mailetcontainer modules Key: JAMES-1148 URL: https://issues.apache.org/jira/browse/JAMES-1148 Project: JAMES Server Issue Type: Task Affects Versions: 3.0-M2 R

svn commit: r1049530 [2/2] - in /james/server/trunk: container-spring/src/main/config/examples/ container-spring/src/main/config/james/ container-spring/src/main/config/james/context/ core-api/src/mai

2010-12-15 Thread norman
Modified: james/server/trunk/smtpserver/src/main/java/org/apache/james/smtpserver/fastfail/ValidRcptHandler.java URL: http://svn.apache.org/viewvc/james/server/trunk/smtpserver/src/main/java/org/apache/james/smtpserver/fastfail/ValidRcptHandler.java?rev=1049530&r1=1049529&r2=1049530&view=diff ===

Re: [PROPOSAL] MailServer interface make sense / Move methods ?

2010-12-15 Thread Stefano Bagnara
>> What about moving to virtual hosting as the default (and maybe the ONLY) >> option? >> When you setup a mailserver you have a domain, I think it is easier to >> understand for newbies if they create users with their full email >> address instead of using simple "usernames" and receive email for

Re: [PROPOSAL] MailServer interface make sense / Move methods ?

2010-12-15 Thread Norman Maurer
Hi Stefano, thanks for the feedback.. Just some minor comments inline 2010/12/15 Stefano Bagnara : > 2010/12/14 Norman Maurer : >> Hi there, >> >> after spending some thoughts about last optimization before the next >> release, I stumpled again over the MailServer interface. >> The Mailserver int

Re: IMAP - Implementing IDLE

2010-12-15 Thread Norman Maurer
Hi Niklas, nice to see you got involved in the IMAP code :). In JAMES we follow the CTR princip, so as you already have write access I think you should just go ahead and commit it. After that just drop an email to the ML. I would be very happy to review your code.. Thx, Norman 2010/12/15 Nikla

Re: [PROPOSAL] MailServer interface make sense / Move methods ?

2010-12-15 Thread Stefano Bagnara
2010/12/14 Norman Maurer : > Hi there, > > after spending some thoughts about last optimization before the next > release, I stumpled again over the MailServer interface. > The Mailserver interface has corrently 5 methods listed. I think a few > of them should be moved and a few should get removed

IMAP - Implementing IDLE

2010-12-15 Thread Niklas Therning
Hi, I've spent the last days implementing IDLE in James IMAP. It seems to work quite ok so far though I've only tested it with the in memory mailbox and I'm adding and deleting messages programmatically. It would be great if you guys would like to review the code and, if you think it looks ok

svn commit: r1049463 - in /james/server/trunk/netty-socket/src/main/java/org/apache/james/socket: ServerMBean.java netty/AbstractConfigurableAsyncServer.java

2010-12-15 Thread norman
Author: norman Date: Wed Dec 15 08:56:26 2010 New Revision: 1049463 URL: http://svn.apache.org/viewvc?rev=1049463&view=rev Log: Expose bound IPAddress via JMX. See JAMES-1057 Modified: james/server/trunk/netty-socket/src/main/java/org/apache/james/socket/ServerMBean.java james/server/tr

[jira] Updated: (JAMES-1147) Remove MailServer interface and move the methods to other Interfaces

2010-12-15 Thread Norman Maurer (JIRA)
[ https://issues.apache.org/jira/browse/JAMES-1147?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Norman Maurer updated JAMES-1147: - Attachment: (was: mailserver_removal.diff) > Remove MailServer interface and move the methods

[jira] Updated: (JAMES-1147) Remove MailServer interface and move the methods to other Interfaces

2010-12-15 Thread Norman Maurer (JIRA)
[ https://issues.apache.org/jira/browse/JAMES-1147?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Norman Maurer updated JAMES-1147: - Attachment: mailserver_removal.diff This is the correct one > Remove MailServer interface and mo

Re: [PROPOSAL] MailServer interface make sense / Move methods ?

2010-12-15 Thread Norman Maurer
I created an issue which has a patch attached.. https://issues.apache.org/jira/browse/JAMES-1147 If I hear nothing against it I will commit the changes.. Bye, Norman 2010/12/14 Norman Maurer : > Hi there, > > after spending some thoughts about last optimization before the next > release, I stum

[jira] Updated: (JAMES-1147) Remove MailServer interface and move the methods to other Interfaces

2010-12-15 Thread Norman Maurer (JIRA)
[ https://issues.apache.org/jira/browse/JAMES-1147?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Norman Maurer updated JAMES-1147: - Attachment: mailserver_removal.diff Proposed code changes > Remove MailServer interface and move

[jira] Created: (JAMES-1147) Remove MailServer interface and move the methods to other Interfaces

2010-12-15 Thread Norman Maurer (JIRA)
Remove MailServer interface and move the methods to other Interfaces Key: JAMES-1147 URL: https://issues.apache.org/jira/browse/JAMES-1147 Project: JAMES Server Issue Type: