OK
So AbstractStoreMessageManager doesn't implement MessageMapper (and it
was in your javadoc :)
... and implements Mailbox (the org.apache.james.imap.mailbox.Mailbox,
not the org.apache.james.imap.store.mail.model.Mailbox...)
The org.apache.james.imap.mailbox.Mailbox has much too do with
Comments inline..
2010/8/20 Eric Charles e...@apache.org:
OK
So AbstractStoreMessageManager doesn't implement MessageMapper (and it was
in your javadoc :)
... and implements Mailbox (the org.apache.james.imap.mailbox.Mailbox, not
the org.apache.james.imap.store.mail.model.Mailbox...)
yep
Hi Norman,
The following hierarchy is obvious and gives services such as create,
login, logout, search on *mailboxes*:
MailboxManager (interface)
/|\
|
DelegatingMailboxManagerimpl (abstract)
/|\
|
StoreMailboxManager (abstract)
Hi guys,
I began looking into the API stuff. I'd like to simplify the Mapper
hierarchy, which however will have no direct impact on the API. Will
upload a patch tomorrow.
I agree, we should name the interface MessageManager, that's what I
thought.
The proposal_v3 is reasonable, I think. To make
Hi All,
Comments inside.
Tks,
Eric
On 08/20/2010 04:53 PM, Tim-Christian Mundt wrote:
Hi guys,
I began looking into the API stuff. I'd like to simplify the Mapper
hierarchy, which however will have no direct impact on the API. Will
upload a patch tomorrow.
Will look at it :)
I agree, we
Ok so its seems like you like the proposal_v3 so far (just minor
naming changes etc). I will commit it then and try to improve the
javadocs a bit etc..
Thx for the review..
Bye,
Norman
2010/8/20 Eric Charles e...@apache.org:
Hi All,
Comments inside.
Tks,
Eric
On 08/20/2010 04:53 PM,
Hi,
just added another diff to the issue which show an other attemp to
make the api more flexible. I think I like it more then the first
one.. please review ;)
Bye,
Norman
2010/8/19 Norman Maurer nor...@apache.org:
Hi there,
I' currently looking for ways to make it easier to create high
Hi Norman,
I applied the last uploaded file (proposal_v3.diff):
- patch works, which is good :)
- I don't see any change on MessageMapper. Probably the modif to return
only uid was already committed (IMAP-203,...) ?
- You migrated methods from StoreMessageManager to
AbstractMessageMapper.
Let me try to explain it
The idea is to let the MessageMapper untouched, because its API is
really easy to understand and use. Its not the most Performant todo
but thats the price to pay.
So I introduced a new abstract class which can be used if you want to
write a custom store which is not
