Re: Fwd: Re: Config resource loading in dev

2010-05-10 Thread Eric Charles
Patch uploaded in JAMES-1002. Tks, Eric On 05/09/2010 05:33 PM, Norman Maurer wrote: Hi Eric, yeah I think 'we' are happy with that. We will even need to change all the file://conf stuff in other configuration files too. Bye, Norman 2010/5/9 Eric Charleseric.char...@u-mangate.com:

Re: Fwd: Re: Config resource loading in dev

2010-05-09 Thread Eric Charles
Hi Norman, I made a first approach making SpringConfigurationRegistry abstract with 2 implementations (SpringFileConfigurationRegistry and SpringClasspathConfigurationRegistry). I first wanted to use composition, but this would have asked too much refactoring, so I used inheritance. The

Re: Fwd: Re: Config resource loading in dev

2010-05-09 Thread Norman Maurer
Hi Eric, I had a quick look and it seems to make sense. could you create a jira issue and attach it there... Thx, Norman 2010/5/9 Eric Charles eric.char...@u-mangate.com: Hi Norman, I made a first approach making SpringConfigurationRegistry abstract with 2 implementations

Re: Fwd: Re: Config resource loading in dev

2010-05-09 Thread Eric Charles
Hi Norman, I will do, but I think this is a partial solution. Administrator will still have replace in spring-beans.xml file://conf/ with classpath: Are we happy with that ? Tks, Eric On 05/09/2010 03:33 PM, Norman Maurer wrote: Hi Eric, I had a quick look and it seems to make sense.

Re: Fwd: Re: Config resource loading in dev

2010-05-09 Thread Norman Maurer
Hi Eric, yeah I think 'we' are happy with that. We will even need to change all the file://conf stuff in other configuration files too. Bye, Norman 2010/5/9 Eric Charles eric.char...@u-mangate.com: Hi Norman, I will do, but I think this is a partial solution. Administrator will still have

Config resource loading in dev

2010-05-05 Thread Eric Charles
Hi, To run james in my ide (eclipse), I copied config files from server/spring-deployment/src/main/config/james to a directory called conf a level upon the root of my project. The resource loading via the file://conf was ok. After, I wanted to load via classpath to have smoother intergration

Re: Config resource loading in dev

2010-05-05 Thread Norman Maurer
Hi Eric, I like your idea about loading every config from classpath. I think you are right, we should change it. About the proposed fallback strategy I'm not sure. I think we should not try to mix up things to much. Just let use add two different ConfigurationRegistry implementations. One for